Code crashes win

[stan cartwright]

I posted a sprite demo that worked and thought make it more variable all purpose but it crashes win and ctrl-alt'del takes ages to appear. Here is the changed code and the whole program is attatched in following post.

    if frame=0 then;which sprite to draw
      erase_sprite (oldspx(temp),oldspy(temp)16,16,256) ;erase sprite at last position
;;;      spritedata_ptr=1 ;pointer to sprite 1 in table
      sprite (spx(temp),spy(temp),16,16,1,256) ;draw sprite1 at new position
    else
      erase_sprite (oldspx(temp),oldspy(temp),16,16,256) ;erase sprite at last position
;;;      spritedata_ptr=257 ;pointer to sprite 2 in table
      sprite (spx(temp),spy(temp),16,16,257,256) ;draw sprite2 at new position
    end if
;--------------------------------------
sub sprite (sprite_x,sprite_y,sprite_width,sprite_height,spritedata_ptr,sprite_size) ;fills window with sprite data
  SetAddressWindow_ILI9341 ( sprite_x,sprite_y,(sprite_x +sprite_width)-1,(sprite_y +sprite_height)-1 )
  for ptr=spritedata_ptr to spritedata_ptr + sprite_size
    ReadTable spritedata,ptr,pixel
    SendWord_ILI9341 pixel
  next ptr
end sub
;
sub erase_sprite (sprite_x,sprite_y,sprite_width,sprite_height,sprite_size) ;fills window background colour
  SetAddressWindow_ILI9341 ( sprite_x,sprite_y,(sprite_x +sprite_width)-1,(sprite_y +sprite_height)-1 )
  repeat sprite_size
    SendWord_ILI9341 GLCDBackground
  end repeat
end sub

[stan cartwright]

Compiling this file crashes win 7.

[Anobium]

Version of build?
What have you tried?

[stan cartwright]

erase_sprite (oldspx(temp),oldspy(temp),16,16,256) ;erase sprite at last position
had no comma after oldspy(temp). second line of above code. Why crash and not flag? Never mind,sorted.
I found out after commenting changes from working code. Works ok now for different size sprites. Just done a cannon with background pixel left and right side so if it moves 1 pixel at a time then no need to erase it. have to add switches next for left/right shoot. real ones

[Anobium]

Please post the exact code with the issue. And, the one change that resolves the issue. Then, I can examine for root cause.

Ta

[stan cartwright]

This line in the code has no comma "," after ,oldspy(temp) and that made win 7 crash.
Put a comma in and the code works as intended. Did the code I attatched crash your win machine?
erase_sprite (oldspx(temp),oldspy(temp)16,16,256)
*********/\

[Anobium]

Should not do this... the compiler should trap the error. And, this 'Compiling this file crashes win 7' do you actually means this? this would be very very serious. Do you really mean a 'a hung process'?

So, to ease the workload... this is a general ask for all reporting this type of issue. We need the exact code with the issue, therefore, deleted anything (from your source code) that is not required to prove the issue. We need minimal code so we can reproduce the issue. The first line of the ASM is also needed - add this to the top of code.

;Program compiled by Great Cow BASIC (0.98.<<>> 2017-11-07)
#chip mega328p, 16
#option Explicit
dim sprite_height,sprite_width as byte
dim sprite_size as word
dim temp as byte
dim oldspy(8) as word
dim oldspx(8) as word

erase_sprite (oldspx(temp),oldspy(temp),16,16,256)

sub erase_sprite (in sprite_x as word, in sprite_y as word, in sprite_width as byte,in sprite_height as byte,in sprite_size as byte)
end sub

@Stan. Well done in resolving. I have this code in the Open Issues folder. Also, look at the code segment above - you can tighten up programming style by using in and type in the Sub definitions - this will use less memory.

[stan cartwright]

Thanks for reply. I figured the error was in the lines I had changed because it worked before. I'd copy/pasted lines and wasn't looking for a deleted comma. It flagged unbalanced braces then when sorted crashed. Message "windows is looking for a solution". press cancel and it reappears in a.loop eventually clearing screen back to desktop but win 7 is unresponsive. This laptop dual boots win 10/7 but only has 1.5 G ram..so win says.
I saw a program in Sourceforge promoted as reporting what happens when win crashes.
I could video the compiler crashing.
I haven't used in and type yet or put dim var in a sub. Learning every day.

[Anobium]

I saw a program in Sourceforge promoted as reporting what happens when win crashes. . Did the compiler crash? No. It was a errant process that was comsuming 4 MB of memory every second. You dont need another application to see this.

I could video the compiler crashing. Please do not. Provide what we ask. If we think a video is needed then we would, of course, need it.

This is the code I needed - just enough to reproduce the issue

;Program compiled by Great Cow BASIC (0.98.<<>> 2017-11-07)
#chip mega328p, 16
#option Explicit
dim sprite_height,sprite_width as byte
dim sprite_size as word
dim temp as byte
dim oldspy(8) as word
dim oldspx(8) as word

erase_sprite (oldspx(temp),oldspy(temp)16,16,256)

sub erase_sprite (in sprite_x as word, in sprite_y as word, in sprite_width as byte,in sprite_height as byte,in sprite_size as byte)
end sub

But, you get a special prize. You get the first ever Patch Kit. This Patch Kit will resolve the issue.

GreatCowBASIC_Build@1701-19112017.rar - please download from personal message I have sent you. Unpack and simply place into your installation. This patch kit MUST be consistent in terms of an operational toolchain. This means using the compiler and the libraries as a consistent installation is most important - you must not, and should not, take just the compiler and not the libraries. Do not even be tempted. Things will break! I will not have time to figure what does not work with what. The patch kit NEEDS to be consistent in terms of an operational toolchain.

Anobium

[stan cartwright]

Other than the copy of the code with error I attatched I don't understand what you require.
it was v98.01 unmodified fresh download.
Please explain the patch idea in more detail as to should we all be using.
Anyone can miss a comma out. Maybe ask users missing comma error reports...pc caught fire

[Anobium]

OK. Did you read the URL in the personal message?

---

Re this comment. Other than the copy of the code with error I attatched I don't understand what you require. Did not the offer of a video. I am trying to say 'provide the minimal code to reproduce the issue.

---

See this post for more details on these Patch Kits: https://sourceforge.net/p/gcbasic/discussion/579125/thread/d2483d44/?limit=250#70d7/ca4f

The patch kit is going to contains the following components:
• Compiler
• Latest Help
• Latest demonstrations
• Updated hardware libraries
• Updated lowlevel libraries
• Updated IDE Lex
• Updated IDE Helpers
• Updated readme.txt!
• Updated PPSTool
The patch kit is NOT going to contain the following components:
-Batch files for programming
- Any tools - programmers etc

Stan you need a patch kit to fix your issue.

---

Good to see you are on the latest release v0.98.01

---

[stan cartwright]

I copy/pasted the patch to gcbv98.01 and got error report in screen shot for the missing comma but gcb didn't recover but win did

[Anobium]

Excellent. Sorted.   The first error message is correct and the others are related.

Fixed.

Thank you for testing.