Menu

#13 Parameters not encoded

open
nobody
None
5
2006-11-01
2006-11-01
No

In src/com/gcalsync/gcal/GCalClient.java, line 43, the
parameters aren't URL-encoded. If the password contains
characters needing encoding, the login will fail.

Workaround:
The parameters can be encoded by hand

Fix:
No fix ready.

Suggestions:
1. Make java.net.URLEncoder available (not possible?),
2. write a replacement for it (code duplication),
3. handle only the letters most probable to cause
problems; shifted numbers (on my european keyboard they
are: '#', '¤', '%', '&', '=', '+', '?') (reduced
version of 2)

Discussion

  • Jens Carlberg

    Jens Carlberg - 2006-11-01

    Potential solution, diff against GCalClient.java

     
  • Jens Carlberg

    Jens Carlberg - 2006-11-01

    Logged In: YES
    user_id=1634480

    After a short search, I found an encoding implementation
    shorter than the one in java.net.URLEncoder. There might be
    issues with with different default platform encodings. I
    also put all code in GCalClient.java; the encoding routine
    may be better placed in HttpUtils or HttpsUtil.

     

Log in to post a comment.