Commit [3a101d]  Maximize  Restore  History

sched: adjust when cpu_active and cpuset configurations are updated during cpu on/offlining

Currently, when a cpu goes down, cpu_active is cleared before
CPU_DOWN_PREPARE starts and cpuset configuration is updated from a
default priority cpu notifier. When a cpu is coming up, it's set
before CPU_ONLINE but cpuset configuration again is updated from the
same cpu notifier.

For cpu notifiers, this presents an inconsistent state. Threads which
a CPU_DOWN_PREPARE notifier expects to be bound to the CPU can be
migrated to other cpus because the cpu is no more inactive.

Fix it by updating cpu_active in the highest priority cpu notifier and
cpuset configuration in the second highest when a cpu is coming up.
Down path is updated similarly. This guarantees that all other cpu
notifiers see consistent cpu_active and cpuset configuration.

cpuset_track_online_cpus() notifier is converted to
cpuset_update_active_cpus() which just updates the configuration and
now called from cpuset_cpu_[in]active() notifiers registered from
sched_init_smp(). If cpuset is disabled, cpuset_update_active_cpus()
degenerates into partition_sched_domains() making separate notifier
for !CONFIG_CPUSETS unnecessary.

This problem is triggered by cmwq. During CPU_DOWN_PREPARE, hotplug
callback creates a kthread and kthread_bind()s it to the target cpu,
and the thread is expected to run on that cpu.

* Ingo's test discovered __cpuinit/exit markups were incorrect.

Signed-off-by: Tejun Heo <>
Acked-by: Peter Zijlstra <>
Cc: Rusty Russell <>
Cc: Ingo Molnar <>
Cc: Paul Menage <>

Tejun Heo Tejun Heo 2010-06-08

changed include/linux/cpu.h
changed include/linux/cpuset.h
changed kernel/cpu.c
changed kernel/cpuset.c
changed kernel/sched.c
include/linux/cpu.h Diff Switch to side-by-side view
include/linux/cpuset.h Diff Switch to side-by-side view
kernel/cpu.c Diff Switch to side-by-side view
kernel/cpuset.c Diff Switch to side-by-side view
kernel/sched.c Diff Switch to side-by-side view

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

No, thanks