Re: [Gawkextlib-developer] gawk-xml-1.1.1 distribution tarball possibly outdated

[Andrew J. S. <as...@te...>]

Hi Jürgen,

Wow -- you have a good memory! I don't know how we came up with
that solution, but it was not a good one. I hope it should be
robust now.

Cheers,
Andy

On Wed, Jan 01, 2025 at 06:00:45PM +0100, Jürgen Kahrs via Gawkextlib-developer wrote:
> Hello Andrew,
> your patch makes sense. I remember a discussion with Stefan
> about how we can determine the name of the gawk executable.
> Stefan was not happy with the old solution of guessing the name.
> At that time we did not know how to properly use Makefile.am.
> 
> Looks much better now.
> 
> 
> > Hi Manuel,
> > 
> > I just commited a patch and uploaded gawk-xml-1.1.2.tar.gz to sourceforge.
> > Can you please confirm that this fixes the problem, when you get a
> > chance?
> > 
> > Happy new year,
> > Andy
> > 
> > On Tue, Dec 31, 2024 at 02:44:41PM -0500, Andrew J. Schorr wrote:
> > > Hi,
> > > 
> > > On Tue, Dec 31, 2024 at 08:13:50PM +0100, Manuel Collado wrote:
> > > > The faulty lines of 'xml-conv-enc' start at line 13::
> > > > ---
> > > > # Stefan Tramm / March 2005
> > > > 
> > > > if test -x ../gawk ; then
> > > >    AWK=../gawk
> > > > elif type gawk >/dev/null 2>&1 ; then
> > > >    AWK=gawk
> > > > elif type nawk >/dev/null 2>&1 ; then
> > > >    AWK=nawk
> > > > else
> > > >    AWK=awk
> > > > fi
> > > > echo AWK=$AWK
> > > > ---
> > > > 
> > > > I think this is a bug. The build scrips should not refer explicitly to dirs
> > > > or files outside the source tree. Right?
> > > Yeah, that's a bug. Thanks for finding it. I think the attached patch
> > > should fix it, but I haven't tested extensively yet.
> > > 
> > > Regards,
> > > Andy
> > > diff --git a/xml/Makefile.am b/xml/Makefile.am
> > > index be4fed6..1a154eb 100644
> > > --- a/xml/Makefile.am
> > > +++ b/xml/Makefile.am
> > > @@ -7,7 +7,7 @@ include extension.makefile
> > >   pkgextension_LTLIBRARIES = xml.la
> > >   xml_enc_converted.touch: $(srcdir)/xml-conv-enc
> > > -	LANG=C LC_ALL=C $(SHELL) $(srcdir)/xml-conv-enc && touch $@
> > > +	AWK=$(GAWKPROG) LANG=C LC_ALL=C $(SHELL) $(srcdir)/xml-conv-enc && touch $@
> > >   xml_enc_handler.lo: xml_enc_converted.touch
> > > diff --git a/xml/xml-conv-enc b/xml/xml-conv-enc
> > > index faa8abe..9e75dab 100755
> > > --- a/xml/xml-conv-enc
> > > +++ b/xml/xml-conv-enc
> > > @@ -12,16 +12,12 @@
> > >   #
> > >   # Stefan Tramm / March 2005
> > > -if test -x ../gawk ; then
> > > -  AWK=../gawk
> > > -elif type gawk >/dev/null 2>&1 ; then
> > > -  AWK=gawk
> > > -elif type nawk >/dev/null 2>&1 ; then
> > > -  AWK=nawk
> > > -else
> > > -  AWK=awk
> > > -fi
> > > -echo AWK=$AWK
> > > +# AWK must be defined in the environment
> > > +echo "$0: AWK=$AWK"
> > > +$AWK 'BEGIN {exit 0}' || {
> > > +   echo "Error: AWK executable must be defined in the environment."
> > > +   exit 1
> > > +}
> > >   echo "/* generated code -- do not modify manually */" > xml_enc_tables.inc
> > 
> > > _______________________________________________
> > > Gawkextlib-developer mailing list
> > > Gaw...@li...
> > > https://lists.sourceforge.net/lists/listinfo/gawkextlib-developer
> > 
> > _______________________________________________
> > Gawkextlib-developer mailing list
> > Gaw...@li...
> > https://lists.sourceforge.net/lists/listinfo/gawkextlib-developer
> 
> 
> 
> _______________________________________________
> Gawkextlib-developer mailing list
> Gaw...@li...
> https://lists.sourceforge.net/lists/listinfo/gawkextlib-developer

-- 
Andrew Schorr                      e-mail: as...@te...
Telemetry Investments, L.L.C.      phone:  917-305-1748
147 W 35th St, Ste 1106
New York, NY 10001-2140