Recent changes to ProductHttpVerticle

ProductHttpVerticle modified by Gary Cheng

Gary Cheng — Wed, 25 Apr 2018 02:04:28 -0000

--- v3
+++ v4
@@ -5,9 +5,6 @@
 import com.ezshop.product.reactivex.ProductService;
 import io.vertx.core.Future;
 import io.vertx.core.json.JsonObject;
-import io.vertx.reactivex.RxHelper;
-import io.vertx.reactivex.core.http.HttpServer;
-import io.vertx.reactivex.core.http.HttpServerRequest;
 import io.vertx.reactivex.ext.web.Router;
 import io.vertx.reactivex.ext.web.RoutingContext;
 import org.slf4j.Logger;
@@ -25,34 +22,19 @@

     private static final String SERVICE_ADDRESS = "serviceProxyAddress";
     private static final String KEY_HTTP_SERVER = "httpServer";
-    private static final String KEY_PORT = "port";
     private ProductService productService;

     @Override
     public void start(Future<Void> startFuture) {
         super.start();
         logger.debug("Starting Product HTTP Server");
-        String serviceName = "product";
         this.productService = com.ezshop.product.ProductService.createProxy(vertx, this.config().getString(SERVICE_ADDRESS));
         JsonObject httpConfig = this.config().getJsonObject(KEY_HTTP_SERVER);
-        int port = httpConfig.getInteger(KEY_PORT);
         Router router = Router.router(vertx);
         this.configureRouter(router);
-        HttpServer server = vertx.createHttpServer();
-        server.requestStream()
-                .toFlowable()
-                .map(HttpServerRequest::pause)
-                .onBackpressureDrop(req -> req.response().setStatusCode(503).end())
-                .observeOn(RxHelper.scheduler(vertx.getDelegate()))
-                .subscribe(req -> {
-                    req.resume();
-                    router.accept(req);
-                });
-        server.rxListen(port)
-                .flatMap(httpServer -> {
-                    logger.debug("{} http server started on port {}", serviceName, port);
-                    return this.publishHttpEndPoint("product", httpConfig);
-                }).subscribe(r -> startFuture.complete(), startFuture::fail);
+        this.createHttpServer(httpConfig, router)
+                .flatMap(httpServer -> this.publishHttpEndPoint("product", httpConfig))
+                .subscribe(r -> startFuture.complete(), startFuture::fail);
     }

     private void configureRouter(Router router) {

ProductHttpVerticle modified by Gary Cheng

Gary Cheng — Tue, 24 Apr 2018 20:20:01 -0000

--- v2
+++ v3
@@ -26,14 +26,13 @@
     private static final String SERVICE_ADDRESS = "serviceProxyAddress";
     private static final String KEY_HTTP_SERVER = "httpServer";
     private static final String KEY_PORT = "port";
-    private static final String KEY_HOST = "host";
-    private static final String KEY_ROOT = "root";
     private ProductService productService;

     @Override
     public void start(Future<Void> startFuture) {
         super.start();
         logger.debug("Starting Product HTTP Server");
+        String serviceName = "product";
         this.productService = com.ezshop.product.ProductService.createProxy(vertx, this.config().getString(SERVICE_ADDRESS));
         JsonObject httpConfig = this.config().getJsonObject(KEY_HTTP_SERVER);
         int port = httpConfig.getInteger(KEY_PORT);
@@ -49,25 +48,22 @@
                     req.resume();
                     router.accept(req);
                 });
-        server.rxListen(port).subscribe(s -> {
-            logger.debug("Gateway HTTP server started on port {}", port);
-            this.publishHttpEndPoint("product", httpConfig);
-            startFuture.complete();
-        }, startFuture::fail);
+        server.rxListen(port)
+                .flatMap(httpServer -> {
+                    logger.debug("{} http server started on port {}", serviceName, port);
+                    return this.publishHttpEndPoint("product", httpConfig);
+                }).subscribe(r -> startFuture.complete(), startFuture::fail);
     }

     private void configureRouter(Router router) {
         this.enableCorsSupport(router);
-        router.post(URI_ALL_CATEGORIES).handler(this::getAllCategories);
+        router.get(URI_ALL_CATEGORIES).handler(this::getAllCategories);
     }

     private void getAllCategories(RoutingContext context) {
-        productService.rxGetAllCategories().subscribe(json -> {
-            context.response().setStatusCode(200);
-            context.response().putHeader("Content-Type", "application/json");
-            context.response().end(json.encodePrettily());
-        });
+        productService.rxGetAllCategories().subscribe(
+                jsonArray -> this.restResponseHandler(context, jsonArray.encodePrettily()),
+                error -> this.restErrorHandler(context, error));
     }
 }
-
 ~~~

ProductHttpVerticle modified by Gary Cheng

Gary Cheng — Tue, 24 Apr 2018 01:58:07 -0000

--- v1
+++ v2
@@ -9,6 +9,7 @@
 import io.vertx.reactivex.core.http.HttpServer;
 import io.vertx.reactivex.core.http.HttpServerRequest;
 import io.vertx.reactivex.ext.web.Router;
+import io.vertx.reactivex.ext.web.RoutingContext;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;

@@ -20,6 +21,8 @@
 public class ProductHttpVerticle extends BaseHttpMicroServicesVerticle {
     private static final Logger logger = LoggerFactory.getLogger(ProductHttpVerticle.class);

+    private static final String URI_ALL_CATEGORIES = "/categories";
+
     private static final String SERVICE_ADDRESS = "serviceProxyAddress";
     private static final String KEY_HTTP_SERVER = "httpServer";
     private static final String KEY_PORT = "port";
@@ -28,7 +31,7 @@
     private ProductService productService;

     @Override
-    public void start(Future<Void> startFuture) throws Exception {
+    public void start(Future<Void> startFuture) {
         super.start();
         logger.debug("Starting Product HTTP Server");
         this.productService = com.ezshop.product.ProductService.createProxy(vertx, this.config().getString(SERVICE_ADDRESS));
@@ -48,12 +51,22 @@
                 });
         server.rxListen(port).subscribe(s -> {
             logger.debug("Gateway HTTP server started on port {}", port);
+            this.publishHttpEndPoint("product", httpConfig);
             startFuture.complete();
         }, startFuture::fail);
     }

     private void configureRouter(Router router) {
         this.enableCorsSupport(router);
+        router.post(URI_ALL_CATEGORIES).handler(this::getAllCategories);
+    }
+
+    private void getAllCategories(RoutingContext context) {
+        productService.rxGetAllCategories().subscribe(json -> {
+            context.response().setStatusCode(200);
+            context.response().putHeader("Content-Type", "application/json");
+            context.response().end(json.encodePrettily());
+        });
     }
 }

ProductHttpVerticle modified by Gary Cheng

Gary Cheng — Mon, 23 Apr 2018 20:21:36 -0000

package com.ezshop.product.http;

import com.ezshop.common.BaseHttpMicroServicesVerticle;
import com.ezshop.product.reactivex.ProductService;
import io.vertx.core.Future;
import io.vertx.core.json.JsonObject;
import io.vertx.reactivex.RxHelper;
import io.vertx.reactivex.core.http.HttpServer;
import io.vertx.reactivex.core.http.HttpServerRequest;
import io.vertx.reactivex.ext.web.Router;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

/**
 * Verticle of product HTTP server
 *
 * @author Gary Cheng
 */
public class ProductHttpVerticle extends BaseHttpMicroServicesVerticle {
    private static final Logger logger = LoggerFactory.getLogger(ProductHttpVerticle.class);

    private static final String SERVICE_ADDRESS = "serviceProxyAddress";
    private static final String KEY_HTTP_SERVER = "httpServer";
    private static final String KEY_PORT = "port";
    private static final String KEY_HOST = "host";
    private static final String KEY_ROOT = "root";
    private ProductService productService;

    @Override
    public void start(Future<Void> startFuture) throws Exception {
        super.start();
        logger.debug("Starting Product HTTP Server");
        this.productService = com.ezshop.product.ProductService.createProxy(vertx, this.config().getString(SERVICE_ADDRESS));
        JsonObject httpConfig = this.config().getJsonObject(KEY_HTTP_SERVER);
        int port = httpConfig.getInteger(KEY_PORT);
        Router router = Router.router(vertx);
        this.configureRouter(router);
        HttpServer server = vertx.createHttpServer();
        server.requestStream()
                .toFlowable()
                .map(HttpServerRequest::pause)
                .onBackpressureDrop(req -> req.response().setStatusCode(503).end())
                .observeOn(RxHelper.scheduler(vertx.getDelegate()))
                .subscribe(req -> {
                    req.resume();
                    router.accept(req);
                });
        server.rxListen(port).subscribe(s -> {
            logger.debug("Gateway HTTP server started on port {}", port);
            startFuture.complete();
        }, startFuture::fail);
    }

    private void configureRouter(Router router) {
        this.enableCorsSupport(router);
    }
}