From: Bharat M. <bh...@me...> - 2002-10-23 05:48:06
|
Hello all. I've checked Jesse Mullan's AlbumDB refactoring code into CVS. I auditted his code and am happy to say that I had no edits whatsoever. Good job, Jesse -- your patch is clean and elegant! However, since this patch has far-reaching implications, I did not want to check it into the trunk until at least a few more people had a chance to play with it from CVS. So, I created a new branch called albumdb-refactoring-branch and checked it in there. I encourage you all to use it, but wisely. First, back up your albums directory: % su - # tar czf albums.tar.gz albums then get the latest code: % cd gallery % sh configure.sh && cvs update -r albumdb-refactor-branch && sh secure.sh This will not cause any harm if you're already running Jesse's patch (although you may get CVS conflicts so it might be best to back out his patch before getting the code from the branch). You will have to upgrade all your albums (browse to upgrade_album.php to do them all at once). The entire upgrade process took 2 minutes for my 1.5GB (3K photos) of data. Backing it up took longer :-) You'll still have to do the upgrade even if you were running Jesse's patch from before because the album version data numbers won't line up (he recommended a placeholder value of 4000, but we're really at version 6). If you use this branch, please report back to us with success or errors. I want to hold off on integrating this into the main branch until I hear from at least 10-15 people who've had no problems. Since there are ~150 people on this list that shouldn't take long :-). regards, -Bharat P.S. I'm not inflicting anything on you that I won't do myself; I have converted my production Gallery to this code and will be testing it myself this week. |