From: GitHub <no...@gi...> - 2013-01-31 01:17:14
|
Branch: refs/heads/master Home: https://github.com/gallery/gallery3 Commit: cf077425953a6a492dea97eaf1517e7d08c9648f https://github.com/gallery/gallery3/commit/cf077425953a6a492dea97eaf1517e7d08c9648f Author: shadlaws <sh...@sh...> Date: 2013-01-29 (Tue, 29 Jan 2013) Changed paths: M modules/gallery/helpers/gallery_event.php M modules/gallery/helpers/graphics.php M modules/gallery/helpers/item.php M modules/gallery/models/item.php M modules/gallery/tests/Graphics_Helper_Test.php Log Message: ----------- #1968 - Improve album cover generation/removal/etc. - Added stanza to Item_Model::save that handles when cover id is null. - Added logic to graphics::generate to copy/convert album cover thumbs from their item thumbs to ensure they're always jpg, and eliminate the possibility that we copy/convert a dirty thumb. - Redirected other places in code where we want to do one of the above two things to use these two functions instead (gallery_event::item_updated_data_file, item::make_album_cover, item::remove_album_cover). - Improved validation in Item_Model so only albums can have covers and all covers must be non-albums. - Added unit tests to Graphics_Helper_Test. Commit: d8d01e0aa0cac2b8576ae481527d875213cdc3a7 https://github.com/gallery/gallery3/commit/d8d01e0aa0cac2b8576ae481527d875213cdc3a7 Author: Bharat Mediratta <bh...@me...> Date: 2013-01-30 (Wed, 30 Jan 2013) Changed paths: M modules/gallery/helpers/gallery_event.php M modules/gallery/helpers/graphics.php M modules/gallery/helpers/item.php M modules/gallery/models/item.php M modules/gallery/tests/Graphics_Helper_Test.php Log Message: ----------- Merge pull request #112 from shadlaws/fix_1968 #1968 - Improve album cover generation/removal/etc. Compare: https://github.com/gallery/gallery3/compare/0ab40de11d65...d8d01e0aa0ca |