gaim-bnet-devel

[gaim-bnet-devel] Encoding issues...

[Gary K. <gr...@re...>]

Well i figured out the issues that I was having.. I'm using the history
plugin and it seems that our text that is getting logged isn't valid
utf8.. So we're going to have to come up with a way for this to work..

--=20
Gary Kramlich <gr...@re...>

Re: [gaim-bnet-devel] Encoding issues...

[Don S. <do...@se...>]

Along these same lines, buddy.c has this function:

static gboolean
bnet_nicks_equal(const gchar *nick1, const gchar *nick2) {
    return (gaim_utf8_strcasecmp(nick1, nick2) =3D=3D 0);
}

In proto.c I have a similar function, only I use gaim_utf8_collate(),
based on grim's suggestion.  I also call gaim_utf8_validate() on each
nick before hand.  I suggest changing this function to do that, as well
as exposing it so I can call it from proto.c for seeing if we sent the
emotes.

Let me know what you think.

Don.

--=20
Don Seiler
do...@se...

Public Key: http://pgp.mit.edu:11371/pks/lookup?op=3Dget&search=3D0xFC87F041
Fingerprint: 0B56 50D5 E91E 4D4C 83B7  207C 76AC 5DA2 FC87 F041

Re: [gaim-bnet-devel] Encoding issues...

[Zilo <ko...@gm...>]

On 01/14/05 16:39:45, Don Seiler wrote:
> Along these same lines, buddy.c has this function:
>=20
> static gboolean
> bnet_nicks_equal(const gchar *nick1, const gchar *nick2) {
>     return (gaim_utf8_strcasecmp(nick1, nick2) =3D=3D 0);
> }
>=20
> In proto.c I have a similar function, only I use gaim_utf8_collate(),
> based on grim's suggestion.  I also call gaim_utf8_validate() on each
> nick before hand.  I suggest changing this function to do that, as
> well as exposing it so I can call it from proto.c for seeing if we =20
> sent the emotes.

Well for nicks in hash, keys are all normalized using gaim_normalize(), =20
I don't think we need an extra-check...

Anyway it's a good idea to have a public function to check nicks.

cya