From: Russell M. <rus...@nt...> - 2003-11-14 14:25:50
|
Philip Kendall <pa...@sr...> wrote: > One change to Fuse's z80 core which was suggested by Witold Filipczyk a > while back was to move some of the memory contention calls from the main > loop into the memory read/write functions. As we often know in the > memory functions whether the chunk of memory we're writing to is > contended or not, this should enable us to reduce the number of calls > made to *_contend_memory, which is currently taking up a significant > fraction of Fuse's CPU usage: [...] > I'm just committed a version of these changes, and the results are... > not entirely convincing. [...] > (say about a 1/7 reduction in the number of calls and a 1/8 reduction in > the time spent in spec48_contend_memory) > > Any opinions on whether it's worth keeping these changes? Hmm... if makes the code harder to understand, or has any significant risk of introducing bugs, I'd say it's not worth it for such a small improvement. -Rus. |