Re: [Freevo-devel] [crash] dialog function(s) missing

[Duncan W. <du...@fr...>]

Adam Charrett wrote:
> On Fri, July 3, 2009 6:59 pm, Duncan Webb wrote:
>> Adam Charrett wrote:
>>> On Wed, July 1, 2009 10:25 pm, Richard van Paasen wrote:
>>>> Hi Adam,
>>>>
>>>> On adding a favorite, freevo crashes when the favorite is saved. See
>>>> the
>>>> trace below. The method dialog.show_working_indicator() is not
>>>> available.
>>>> After removing the call to this method from favoriteitem.py, a new
>>>> error
>>>> about the hide() method appears (see second log).
>>>>
>>> Hi Richard, I was slightly surprised by this when I ran into the other
>>> day, but didn't have time to work out what the problem was. I've just
>>> checked svn and it looks like a bad commit.
>>>
>>> Duncan, can you role back the changes you did in rev 2227 for
>>> src/dialog/__init__.py to rev 2222, looks like you've done a straight
>>> copy
>>> from the branch to trunk and removed a load of functions that are in
>>> use.
>> Normally create a patch and then apply this to the other branch. Would
>> you like to provide the freevo revision numbers of a patch? Patching is
>> pretty easy to create with svn, something like svn diff -r2227:2222.
> 
> Right I think these are the correct revision numbers:
> svn diff -r11586:11580
> 
> I was using trac on your website to work out the problem but for some
> reason the rev numbers are completely different to the real svn ones?!

You mean the freevo-1 source, this is because using svm (note the 'm')
to copy a branch rewrites the revision numbers from the transaction log.

Thanks for the revision, now updated in svn.

Duncan