Menu

#140 Compiler Warnings Generated with Keil C166 EC++ Compiler

closed
nobody
None
7
2020-03-27
2020-03-26
No

Hello,

I have noticed it would be quite nice if we could define the following macros for use:
portTICK_TYPE_ENTER_CRITICAL()
portTICK_TYPE_EXIT_CRITICAL()
portTICK_TYPE_SET_INTERRUPT_MASK_FROM_ISR()
portTICK_TYPE_CLEAR_INTERRUPT_MASK_FROM_ISR(x)

At least for my platform this would be slightly useful. Since this section is always short, It would allow me to use ATOMIC instructions instead of masking off the interrupt mask register. The cost savings are ~5-6 instructions per call (with optimization & no assert), which really isn't that much if the function isn't called that frequently.

I am unsure if the minor benefit outweighs the minor risk, however, I wanted to throw this suggestion out there for other MCUs with code-size or performance limitations.

Thanks & kind regards,
Victor B.

Discussion

  • Victor Brzeski

    Victor Brzeski - 2020-03-26

    Appologies for the incorrect title, that was for a seperate issue I submitted on GitHub.

    It would be nice if this FR could be renamed: "portTICK_TYPE Critical Section Control"

     
  • Richard Barry

    Richard Barry - 2020-03-27
    • status: open --> closed
     
  • Richard Barry

    Richard Barry - 2020-03-27

    Hi Victor - sorry for the inconvenience as I didn't realise people could still open tickets here. I would be grateful if you could open the tick here instead: https://github.com/FreeRTOS/FreeRTOS-Kernel thanks.

     

Log in to post a comment.