From: SourceForge.net <no...@so...> - 2008-10-20 10:12:46
|
Bugs item #2173896, was opened at 2008-10-17 07:19 Message generated for change (Settings changed) made by vleon1 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=544942&aid=2173896&group_id=75752 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: Latest Subversion Status: Open Resolution: None Priority: 5 Private: No Submitted By: Leon Vayman (vleon1) Assigned to: Nobody/Anonymous (nobody) >Summary: free orion and gigi wouldnt compile with boost 1.36 Initial Comment: sorry if its the wrong place, anyway gigi wouldnt compile because of some minor changes, it seems simple enough to fix but i was able to do it isnce i never used boost and am very new to programming. please fix it stable gigi also didnt compile for me with boost 1.34 and 1.36 as well ---------------------------------------------------------------------- Comment By: Leon Vayman (vleon1) Date: 2008-10-20 10:35 Message: I was to fast to submit fixes forgetting that free orion depends on boost as well. After long hours of work i created a patch, that was used to build an archlinux package as well (thus the reason it includes the PI and PS2INCH fixes as well) note most of the patch exept the last file is fixing the code to run with boost 1.36, if you dont want to patch you source now i hope it will at least prove usefull in the future (maybe link to the patch or something..) the last file is with the graphviz fixes you dont want to include from the forum AND a fix for graphviz>=2.20, this is probably not a proper fix, but could serve as a reference (you dont need to debug, the commented row is the segfault cause..) To conclude this last post in this bug tracker of mine, im not an experienced developer, i could have made mistake and use wrong implentions, please use it as a referance for a fix (still the patch could be perfectly fine,,) Thanks for the great game :) File Added: freeorion-svn.patch ---------------------------------------------------------------------- Comment By: Leon Vayman (vleon1) Date: 2008-10-19 10:05 Message: I took a deeper look into the problem and managed to fix them, im submiting a patch containing both my fixes (there are two separate changes in boost that neede to be adressed). File Added: gigi-svn.patch ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=544942&aid=2173896&group_id=75752 |
From: SourceForge.net <no...@so...> - 2008-11-22 11:59:43
|
Bugs item #2173896, was opened at 2008-10-16 22:19 Message generated for change (Comment added) made by geoffthemedio You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=544942&aid=2173896&group_id=75752 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: Latest Subversion Status: Open Resolution: None Priority: 5 Private: No Submitted By: Leon Vayman (vleon1) Assigned to: Nobody/Anonymous (nobody) Summary: free orion and gigi wouldnt compile with boost 1.36 Initial Comment: sorry if its the wrong place, anyway gigi wouldnt compile because of some minor changes, it seems simple enough to fix but i was able to do it isnce i never used boost and am very new to programming. please fix it stable gigi also didnt compile for me with boost 1.34 and 1.36 as well ---------------------------------------------------------------------- >Comment By: Geoff Topping (geoffthemedio) Date: 2008-11-22 03:59 Message: tzlaine seems to have committed GG 1.36 fixes. I don't know if he was aware of your (vleon1's) submitted patch when doing this, but thanks either way. I'll hopefully have a look at the graphviz parts of your patch as well. If they fix the problem without causing any new problems when using the older version, I don't see why we shouldn't make those relatively minor additions and change. ---------------------------------------------------------------------- Comment By: Leon Vayman (vleon1) Date: 2008-10-20 01:35 Message: I was to fast to submit fixes forgetting that free orion depends on boost as well. After long hours of work i created a patch, that was used to build an archlinux package as well (thus the reason it includes the PI and PS2INCH fixes as well) note most of the patch exept the last file is fixing the code to run with boost 1.36, if you dont want to patch you source now i hope it will at least prove usefull in the future (maybe link to the patch or something..) the last file is with the graphviz fixes you dont want to include from the forum AND a fix for graphviz>=2.20, this is probably not a proper fix, but could serve as a reference (you dont need to debug, the commented row is the segfault cause..) To conclude this last post in this bug tracker of mine, im not an experienced developer, i could have made mistake and use wrong implentions, please use it as a referance for a fix (still the patch could be perfectly fine,,) Thanks for the great game :) File Added: freeorion-svn.patch ---------------------------------------------------------------------- Comment By: Leon Vayman (vleon1) Date: 2008-10-19 01:05 Message: I took a deeper look into the problem and managed to fix them, im submiting a patch containing both my fixes (there are two separate changes in boost that neede to be adressed). File Added: gigi-svn.patch ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=544942&aid=2173896&group_id=75752 |
From: SourceForge.net <no...@so...> - 2008-11-22 12:14:54
|
Bugs item #2173896, was opened at 2008-10-17 07:19 Message generated for change (Comment added) made by vleon1 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=544942&aid=2173896&group_id=75752 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: Latest Subversion Status: Open Resolution: None Priority: 5 Private: No Submitted By: Leon Vayman (vleon1) Assigned to: Nobody/Anonymous (nobody) Summary: free orion and gigi wouldnt compile with boost 1.36 Initial Comment: sorry if its the wrong place, anyway gigi wouldnt compile because of some minor changes, it seems simple enough to fix but i was able to do it isnce i never used boost and am very new to programming. please fix it stable gigi also didnt compile for me with boost 1.34 and 1.36 as well ---------------------------------------------------------------------- >Comment By: Leon Vayman (vleon1) Date: 2008-11-22 14:14 Message: Thats awsome ^_^, i assume he fixed 1.36 issues in freeorion as well or else its kind of pointless :) anyway when you decide what to do with graphviz please tell me so i can update my package (im a packager in the arch linux gaming repo) ---------------------------------------------------------------------- Comment By: Geoff Topping (geoffthemedio) Date: 2008-11-22 13:59 Message: tzlaine seems to have committed GG 1.36 fixes. I don't know if he was aware of your (vleon1's) submitted patch when doing this, but thanks either way. I'll hopefully have a look at the graphviz parts of your patch as well. If they fix the problem without causing any new problems when using the older version, I don't see why we shouldn't make those relatively minor additions and change. ---------------------------------------------------------------------- Comment By: Leon Vayman (vleon1) Date: 2008-10-20 10:35 Message: I was to fast to submit fixes forgetting that free orion depends on boost as well. After long hours of work i created a patch, that was used to build an archlinux package as well (thus the reason it includes the PI and PS2INCH fixes as well) note most of the patch exept the last file is fixing the code to run with boost 1.36, if you dont want to patch you source now i hope it will at least prove usefull in the future (maybe link to the patch or something..) the last file is with the graphviz fixes you dont want to include from the forum AND a fix for graphviz>=2.20, this is probably not a proper fix, but could serve as a reference (you dont need to debug, the commented row is the segfault cause..) To conclude this last post in this bug tracker of mine, im not an experienced developer, i could have made mistake and use wrong implentions, please use it as a referance for a fix (still the patch could be perfectly fine,,) Thanks for the great game :) File Added: freeorion-svn.patch ---------------------------------------------------------------------- Comment By: Leon Vayman (vleon1) Date: 2008-10-19 10:05 Message: I took a deeper look into the problem and managed to fix them, im submiting a patch containing both my fixes (there are two separate changes in boost that neede to be adressed). File Added: gigi-svn.patch ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=544942&aid=2173896&group_id=75752 |
From: SourceForge.net <no...@so...> - 2008-11-23 04:31:36
|
Bugs item #2173896, was opened at 2008-10-16 22:19 Message generated for change (Comment added) made by geoffthemedio You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=544942&aid=2173896&group_id=75752 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. >Category: Client Group: Latest Subversion >Status: Pending >Resolution: Later Priority: 5 Private: No Submitted By: Leon Vayman (vleon1) Assigned to: Nobody/Anonymous (nobody) Summary: free orion and gigi wouldnt compile with boost 1.36 Initial Comment: sorry if its the wrong place, anyway gigi wouldnt compile because of some minor changes, it seems simple enough to fix but i was able to do it isnce i never used boost and am very new to programming. please fix it stable gigi also didnt compile for me with boost 1.34 and 1.36 as well ---------------------------------------------------------------------- >Comment By: Geoff Topping (geoffthemedio) Date: 2008-11-22 20:31 Message: I've committed some changes to TechTreeWnd.cpp that are similar to your posted patch. Let me know if these fix the problem. Hopefully the commented-out line while setting the "ordering" default graph property doesn't have any side effects. ---------------------------------------------------------------------- Comment By: Leon Vayman (vleon1) Date: 2008-11-22 04:14 Message: Thats awsome ^_^, i assume he fixed 1.36 issues in freeorion as well or else its kind of pointless :) anyway when you decide what to do with graphviz please tell me so i can update my package (im a packager in the arch linux gaming repo) ---------------------------------------------------------------------- Comment By: Geoff Topping (geoffthemedio) Date: 2008-11-22 03:59 Message: tzlaine seems to have committed GG 1.36 fixes. I don't know if he was aware of your (vleon1's) submitted patch when doing this, but thanks either way. I'll hopefully have a look at the graphviz parts of your patch as well. If they fix the problem without causing any new problems when using the older version, I don't see why we shouldn't make those relatively minor additions and change. ---------------------------------------------------------------------- Comment By: Leon Vayman (vleon1) Date: 2008-10-20 01:35 Message: I was to fast to submit fixes forgetting that free orion depends on boost as well. After long hours of work i created a patch, that was used to build an archlinux package as well (thus the reason it includes the PI and PS2INCH fixes as well) note most of the patch exept the last file is fixing the code to run with boost 1.36, if you dont want to patch you source now i hope it will at least prove usefull in the future (maybe link to the patch or something..) the last file is with the graphviz fixes you dont want to include from the forum AND a fix for graphviz>=2.20, this is probably not a proper fix, but could serve as a reference (you dont need to debug, the commented row is the segfault cause..) To conclude this last post in this bug tracker of mine, im not an experienced developer, i could have made mistake and use wrong implentions, please use it as a referance for a fix (still the patch could be perfectly fine,,) Thanks for the great game :) File Added: freeorion-svn.patch ---------------------------------------------------------------------- Comment By: Leon Vayman (vleon1) Date: 2008-10-19 01:05 Message: I took a deeper look into the problem and managed to fix them, im submiting a patch containing both my fixes (there are two separate changes in boost that neede to be adressed). File Added: gigi-svn.patch ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=544942&aid=2173896&group_id=75752 |
From: SourceForge.net <no...@so...> - 2008-11-23 07:44:09
|
Bugs item #2173896, was opened at 2008-10-17 07:19 Message generated for change (Comment added) made by vleon1 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=544942&aid=2173896&group_id=75752 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Client Group: Latest Subversion >Status: Open Resolution: Later Priority: 5 Private: No Submitted By: Leon Vayman (vleon1) Assigned to: Nobody/Anonymous (nobody) Summary: free orion and gigi wouldnt compile with boost 1.36 Initial Comment: sorry if its the wrong place, anyway gigi wouldnt compile because of some minor changes, it seems simple enough to fix but i was able to do it isnce i never used boost and am very new to programming. please fix it stable gigi also didnt compile for me with boost 1.34 and 1.36 as well ---------------------------------------------------------------------- >Comment By: Leon Vayman (vleon1) Date: 2008-11-23 09:44 Message: I tested it and both gigi and freeorion compiled, freeorion did not segfault on me so i can declare this thread a success :) if you decide to change something that might break freeorion on some system (like trying to make a better"ordering" line that might or might not segfault), please let me know, ill gladly test and report. now if only freeorion moved to the latest log4cpp or even just dump this ancient library and use another ^_^ and maybe move to the latest devil, this could solve so much problems. ---------------------------------------------------------------------- Comment By: Geoff Topping (geoffthemedio) Date: 2008-11-23 06:31 Message: I've committed some changes to TechTreeWnd.cpp that are similar to your posted patch. Let me know if these fix the problem. Hopefully the commented-out line while setting the "ordering" default graph property doesn't have any side effects. ---------------------------------------------------------------------- Comment By: Leon Vayman (vleon1) Date: 2008-11-22 14:14 Message: Thats awsome ^_^, i assume he fixed 1.36 issues in freeorion as well or else its kind of pointless :) anyway when you decide what to do with graphviz please tell me so i can update my package (im a packager in the arch linux gaming repo) ---------------------------------------------------------------------- Comment By: Geoff Topping (geoffthemedio) Date: 2008-11-22 13:59 Message: tzlaine seems to have committed GG 1.36 fixes. I don't know if he was aware of your (vleon1's) submitted patch when doing this, but thanks either way. I'll hopefully have a look at the graphviz parts of your patch as well. If they fix the problem without causing any new problems when using the older version, I don't see why we shouldn't make those relatively minor additions and change. ---------------------------------------------------------------------- Comment By: Leon Vayman (vleon1) Date: 2008-10-20 10:35 Message: I was to fast to submit fixes forgetting that free orion depends on boost as well. After long hours of work i created a patch, that was used to build an archlinux package as well (thus the reason it includes the PI and PS2INCH fixes as well) note most of the patch exept the last file is fixing the code to run with boost 1.36, if you dont want to patch you source now i hope it will at least prove usefull in the future (maybe link to the patch or something..) the last file is with the graphviz fixes you dont want to include from the forum AND a fix for graphviz>=2.20, this is probably not a proper fix, but could serve as a reference (you dont need to debug, the commented row is the segfault cause..) To conclude this last post in this bug tracker of mine, im not an experienced developer, i could have made mistake and use wrong implentions, please use it as a referance for a fix (still the patch could be perfectly fine,,) Thanks for the great game :) File Added: freeorion-svn.patch ---------------------------------------------------------------------- Comment By: Leon Vayman (vleon1) Date: 2008-10-19 10:05 Message: I took a deeper look into the problem and managed to fix them, im submiting a patch containing both my fixes (there are two separate changes in boost that neede to be adressed). File Added: gigi-svn.patch ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=544942&aid=2173896&group_id=75752 |
From: SourceForge.net <no...@so...> - 2008-11-23 08:00:23
|
Bugs item #2173896, was opened at 2008-10-16 22:19 Message generated for change (Comment added) made by geoffthemedio You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=544942&aid=2173896&group_id=75752 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Client Group: Latest Subversion >Status: Closed >Resolution: Fixed Priority: 5 Private: No Submitted By: Leon Vayman (vleon1) Assigned to: Nobody/Anonymous (nobody) Summary: free orion and gigi wouldnt compile with boost 1.36 Initial Comment: sorry if its the wrong place, anyway gigi wouldnt compile because of some minor changes, it seems simple enough to fix but i was able to do it isnce i never used boost and am very new to programming. please fix it stable gigi also didnt compile for me with boost 1.34 and 1.36 as well ---------------------------------------------------------------------- >Comment By: Geoff Topping (geoffthemedio) Date: 2008-11-23 00:00 Message: Is there an alternative for that ordering line that will work in newer versions of graphviz? I'd prefer to have it be there, if possible, as it took tzlaine a long time to get the layout working and I don't know what the consequences of it being changed might be. Moving to new versions of libraries often creates as many problems as it fixes, as people can't get the new versions from their repositories. That said, if licensing allows, we could perhaps put the log4cpp code into FreeOrion itself, so that it's built into the binaries instead of being an external library and dependency. We could probably even use a subset of the log4cpp code, as I don't think we're doing much more than writing text to a log file and the console with a timestamp, and I imagine log4cpp does a bit more than that, though I haven't looked into recently. ---------------------------------------------------------------------- Comment By: Leon Vayman (vleon1) Date: 2008-11-22 23:44 Message: I tested it and both gigi and freeorion compiled, freeorion did not segfault on me so i can declare this thread a success :) if you decide to change something that might break freeorion on some system (like trying to make a better"ordering" line that might or might not segfault), please let me know, ill gladly test and report. now if only freeorion moved to the latest log4cpp or even just dump this ancient library and use another ^_^ and maybe move to the latest devil, this could solve so much problems. ---------------------------------------------------------------------- Comment By: Geoff Topping (geoffthemedio) Date: 2008-11-22 20:31 Message: I've committed some changes to TechTreeWnd.cpp that are similar to your posted patch. Let me know if these fix the problem. Hopefully the commented-out line while setting the "ordering" default graph property doesn't have any side effects. ---------------------------------------------------------------------- Comment By: Leon Vayman (vleon1) Date: 2008-11-22 04:14 Message: Thats awsome ^_^, i assume he fixed 1.36 issues in freeorion as well or else its kind of pointless :) anyway when you decide what to do with graphviz please tell me so i can update my package (im a packager in the arch linux gaming repo) ---------------------------------------------------------------------- Comment By: Geoff Topping (geoffthemedio) Date: 2008-11-22 03:59 Message: tzlaine seems to have committed GG 1.36 fixes. I don't know if he was aware of your (vleon1's) submitted patch when doing this, but thanks either way. I'll hopefully have a look at the graphviz parts of your patch as well. If they fix the problem without causing any new problems when using the older version, I don't see why we shouldn't make those relatively minor additions and change. ---------------------------------------------------------------------- Comment By: Leon Vayman (vleon1) Date: 2008-10-20 01:35 Message: I was to fast to submit fixes forgetting that free orion depends on boost as well. After long hours of work i created a patch, that was used to build an archlinux package as well (thus the reason it includes the PI and PS2INCH fixes as well) note most of the patch exept the last file is fixing the code to run with boost 1.36, if you dont want to patch you source now i hope it will at least prove usefull in the future (maybe link to the patch or something..) the last file is with the graphviz fixes you dont want to include from the forum AND a fix for graphviz>=2.20, this is probably not a proper fix, but could serve as a reference (you dont need to debug, the commented row is the segfault cause..) To conclude this last post in this bug tracker of mine, im not an experienced developer, i could have made mistake and use wrong implentions, please use it as a referance for a fix (still the patch could be perfectly fine,,) Thanks for the great game :) File Added: freeorion-svn.patch ---------------------------------------------------------------------- Comment By: Leon Vayman (vleon1) Date: 2008-10-19 01:05 Message: I took a deeper look into the problem and managed to fix them, im submiting a patch containing both my fixes (there are two separate changes in boost that neede to be adressed). File Added: gigi-svn.patch ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=544942&aid=2173896&group_id=75752 |
From: SourceForge.net <no...@so...> - 2008-11-23 08:12:06
|
Bugs item #2173896, was opened at 2008-10-17 07:19 Message generated for change (Comment added) made by vleon1 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=544942&aid=2173896&group_id=75752 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Client Group: Latest Subversion Status: Closed Resolution: Fixed Priority: 5 Private: No Submitted By: Leon Vayman (vleon1) Assigned to: Nobody/Anonymous (nobody) Summary: free orion and gigi wouldnt compile with boost 1.36 Initial Comment: sorry if its the wrong place, anyway gigi wouldnt compile because of some minor changes, it seems simple enough to fix but i was able to do it isnce i never used boost and am very new to programming. please fix it stable gigi also didnt compile for me with boost 1.34 and 1.36 as well ---------------------------------------------------------------------- >Comment By: Leon Vayman (vleon1) Date: 2008-11-23 10:12 Message: i dont know if theres an alternative, i serached for one myself but i understand nothing in graphviz and their documentation is far from being the best out there (or maybe i was just lazy) i tried some combinations with no result and comparing freeorion built on a previous version of graphviz with this line and the lates graphviz without the line didnt yield any negative results i could see. it looked exacly the same, but then again mybe i just didnt know where to look ;) i think someone who knows better than me should test it out and fix if needed, just update this bug post here or send me a mail to vl...@gm... so i can test and report how it worked. about the libraries i like the approach of planeshift, their project is not considered ready so they use bleeding edge dependancies (their most important dep is crystal space, and they use the 1.4 svn branch) consider the fact that an svn version is allowed to break on some comps, as long as you have a stable source for packagers to use that is not ancient, unfortuantly in freeorions case the latest source snapshot is quite ancient :/ anyway im just suggesting im not a dev in freeorion and right now have no intentions of trying to join (have no time on my hands :/) just to conclude in linux whatever you do some people will have trouble and some wont, since there are people on debian that uses some ancient libraries, and others on arch, wich is almost always on the bleeding edge. ---------------------------------------------------------------------- Comment By: Geoff Topping (geoffthemedio) Date: 2008-11-23 10:00 Message: Is there an alternative for that ordering line that will work in newer versions of graphviz? I'd prefer to have it be there, if possible, as it took tzlaine a long time to get the layout working and I don't know what the consequences of it being changed might be. Moving to new versions of libraries often creates as many problems as it fixes, as people can't get the new versions from their repositories. That said, if licensing allows, we could perhaps put the log4cpp code into FreeOrion itself, so that it's built into the binaries instead of being an external library and dependency. We could probably even use a subset of the log4cpp code, as I don't think we're doing much more than writing text to a log file and the console with a timestamp, and I imagine log4cpp does a bit more than that, though I haven't looked into recently. ---------------------------------------------------------------------- Comment By: Leon Vayman (vleon1) Date: 2008-11-23 09:44 Message: I tested it and both gigi and freeorion compiled, freeorion did not segfault on me so i can declare this thread a success :) if you decide to change something that might break freeorion on some system (like trying to make a better"ordering" line that might or might not segfault), please let me know, ill gladly test and report. now if only freeorion moved to the latest log4cpp or even just dump this ancient library and use another ^_^ and maybe move to the latest devil, this could solve so much problems. ---------------------------------------------------------------------- Comment By: Geoff Topping (geoffthemedio) Date: 2008-11-23 06:31 Message: I've committed some changes to TechTreeWnd.cpp that are similar to your posted patch. Let me know if these fix the problem. Hopefully the commented-out line while setting the "ordering" default graph property doesn't have any side effects. ---------------------------------------------------------------------- Comment By: Leon Vayman (vleon1) Date: 2008-11-22 14:14 Message: Thats awsome ^_^, i assume he fixed 1.36 issues in freeorion as well or else its kind of pointless :) anyway when you decide what to do with graphviz please tell me so i can update my package (im a packager in the arch linux gaming repo) ---------------------------------------------------------------------- Comment By: Geoff Topping (geoffthemedio) Date: 2008-11-22 13:59 Message: tzlaine seems to have committed GG 1.36 fixes. I don't know if he was aware of your (vleon1's) submitted patch when doing this, but thanks either way. I'll hopefully have a look at the graphviz parts of your patch as well. If they fix the problem without causing any new problems when using the older version, I don't see why we shouldn't make those relatively minor additions and change. ---------------------------------------------------------------------- Comment By: Leon Vayman (vleon1) Date: 2008-10-20 10:35 Message: I was to fast to submit fixes forgetting that free orion depends on boost as well. After long hours of work i created a patch, that was used to build an archlinux package as well (thus the reason it includes the PI and PS2INCH fixes as well) note most of the patch exept the last file is fixing the code to run with boost 1.36, if you dont want to patch you source now i hope it will at least prove usefull in the future (maybe link to the patch or something..) the last file is with the graphviz fixes you dont want to include from the forum AND a fix for graphviz>=2.20, this is probably not a proper fix, but could serve as a reference (you dont need to debug, the commented row is the segfault cause..) To conclude this last post in this bug tracker of mine, im not an experienced developer, i could have made mistake and use wrong implentions, please use it as a referance for a fix (still the patch could be perfectly fine,,) Thanks for the great game :) File Added: freeorion-svn.patch ---------------------------------------------------------------------- Comment By: Leon Vayman (vleon1) Date: 2008-10-19 10:05 Message: I took a deeper look into the problem and managed to fix them, im submiting a patch containing both my fixes (there are two separate changes in boost that neede to be adressed). File Added: gigi-svn.patch ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=544942&aid=2173896&group_id=75752 |
From: SourceForge.net <no...@so...> - 2008-12-06 14:40:54
|
Bugs item #2173896, was opened at 2008-10-17 07:19 Message generated for change (Comment added) made by kroddn You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=544942&aid=2173896&group_id=75752 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Client Group: Latest Subversion Status: Closed Resolution: Fixed Priority: 5 Private: No Submitted By: Leon Vayman (vleon1) Assigned to: Nobody/Anonymous (nobody) Summary: free orion and gigi wouldnt compile with boost 1.36 Initial Comment: sorry if its the wrong place, anyway gigi wouldnt compile because of some minor changes, it seems simple enough to fix but i was able to do it isnce i never used boost and am very new to programming. please fix it stable gigi also didnt compile for me with boost 1.34 and 1.36 as well ---------------------------------------------------------------------- Comment By: Markus Sinner (kroddn) Date: 2008-12-06 15:40 Message: When discussing graphviz-problems please take into consideration that graphviz normally uses dynamic loading of shared objects. For example the "Dot-Layout" ist built as a shared object which is loaded at runtime of freeorion. So, if you compile with other versions of graphviz than installed on your machine, it might crash. The installed version of graphviz must be the same one used at compilation time. Of course, this makes sharing of FO-Binaries very complicated. I developed some code to statically link the required modules at compile time to avoid those problems. Take a look at: http://psitronic.de/div/FO/static-graphviz.c If you compile this file and link it into freeorion, the "modules" should be linked into the binary. ---------------------------------------------------------------------- Comment By: Leon Vayman (vleon1) Date: 2008-11-23 09:12 Message: i dont know if theres an alternative, i serached for one myself but i understand nothing in graphviz and their documentation is far from being the best out there (or maybe i was just lazy) i tried some combinations with no result and comparing freeorion built on a previous version of graphviz with this line and the lates graphviz without the line didnt yield any negative results i could see. it looked exacly the same, but then again mybe i just didnt know where to look ;) i think someone who knows better than me should test it out and fix if needed, just update this bug post here or send me a mail to vl...@gm... so i can test and report how it worked. about the libraries i like the approach of planeshift, their project is not considered ready so they use bleeding edge dependancies (their most important dep is crystal space, and they use the 1.4 svn branch) consider the fact that an svn version is allowed to break on some comps, as long as you have a stable source for packagers to use that is not ancient, unfortuantly in freeorions case the latest source snapshot is quite ancient :/ anyway im just suggesting im not a dev in freeorion and right now have no intentions of trying to join (have no time on my hands :/) just to conclude in linux whatever you do some people will have trouble and some wont, since there are people on debian that uses some ancient libraries, and others on arch, wich is almost always on the bleeding edge. ---------------------------------------------------------------------- Comment By: Geoff Topping (geoffthemedio) Date: 2008-11-23 09:00 Message: Is there an alternative for that ordering line that will work in newer versions of graphviz? I'd prefer to have it be there, if possible, as it took tzlaine a long time to get the layout working and I don't know what the consequences of it being changed might be. Moving to new versions of libraries often creates as many problems as it fixes, as people can't get the new versions from their repositories. That said, if licensing allows, we could perhaps put the log4cpp code into FreeOrion itself, so that it's built into the binaries instead of being an external library and dependency. We could probably even use a subset of the log4cpp code, as I don't think we're doing much more than writing text to a log file and the console with a timestamp, and I imagine log4cpp does a bit more than that, though I haven't looked into recently. ---------------------------------------------------------------------- Comment By: Leon Vayman (vleon1) Date: 2008-11-23 08:44 Message: I tested it and both gigi and freeorion compiled, freeorion did not segfault on me so i can declare this thread a success :) if you decide to change something that might break freeorion on some system (like trying to make a better"ordering" line that might or might not segfault), please let me know, ill gladly test and report. now if only freeorion moved to the latest log4cpp or even just dump this ancient library and use another ^_^ and maybe move to the latest devil, this could solve so much problems. ---------------------------------------------------------------------- Comment By: Geoff Topping (geoffthemedio) Date: 2008-11-23 05:31 Message: I've committed some changes to TechTreeWnd.cpp that are similar to your posted patch. Let me know if these fix the problem. Hopefully the commented-out line while setting the "ordering" default graph property doesn't have any side effects. ---------------------------------------------------------------------- Comment By: Leon Vayman (vleon1) Date: 2008-11-22 13:14 Message: Thats awsome ^_^, i assume he fixed 1.36 issues in freeorion as well or else its kind of pointless :) anyway when you decide what to do with graphviz please tell me so i can update my package (im a packager in the arch linux gaming repo) ---------------------------------------------------------------------- Comment By: Geoff Topping (geoffthemedio) Date: 2008-11-22 12:59 Message: tzlaine seems to have committed GG 1.36 fixes. I don't know if he was aware of your (vleon1's) submitted patch when doing this, but thanks either way. I'll hopefully have a look at the graphviz parts of your patch as well. If they fix the problem without causing any new problems when using the older version, I don't see why we shouldn't make those relatively minor additions and change. ---------------------------------------------------------------------- Comment By: Leon Vayman (vleon1) Date: 2008-10-20 10:35 Message: I was to fast to submit fixes forgetting that free orion depends on boost as well. After long hours of work i created a patch, that was used to build an archlinux package as well (thus the reason it includes the PI and PS2INCH fixes as well) note most of the patch exept the last file is fixing the code to run with boost 1.36, if you dont want to patch you source now i hope it will at least prove usefull in the future (maybe link to the patch or something..) the last file is with the graphviz fixes you dont want to include from the forum AND a fix for graphviz>=2.20, this is probably not a proper fix, but could serve as a reference (you dont need to debug, the commented row is the segfault cause..) To conclude this last post in this bug tracker of mine, im not an experienced developer, i could have made mistake and use wrong implentions, please use it as a referance for a fix (still the patch could be perfectly fine,,) Thanks for the great game :) File Added: freeorion-svn.patch ---------------------------------------------------------------------- Comment By: Leon Vayman (vleon1) Date: 2008-10-19 10:05 Message: I took a deeper look into the problem and managed to fix them, im submiting a patch containing both my fixes (there are two separate changes in boost that neede to be adressed). File Added: gigi-svn.patch ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=544942&aid=2173896&group_id=75752 |