#357 segfault turn after pressing colonize

Latest Subversion
closed-fixed
Client (126)
8
2008-05-30
2008-05-02
Anonymous
No

new game->select a planet->click colonize
next turn.

I think it might be because of
UniverseObject::GetMeter (this=0x0, type=METER_FUEL) at universe/UniverseObject.cpp:228

called from

Universe::InitMeterEstimatesAndDiscrepancies at universe/Universe.cpp:558

so it seems there is a meter for a NULL UniverseObject somehow getting into m_effect_accounting_map, or maybe needs to test the UniverseObject for null before calling GetMeter

Discussion

  • Geoff Topping

    Geoff Topping - 2008-05-03

    Logged In: YES
    user_id=913462
    Originator: NO

    This is likely due to me recently making it possible for ships to have effects, and the effect accounting not dealing with ships disappearing / reappearing when colonizing.

     
  • Geoff Topping

    Geoff Topping - 2008-05-03
    • priority: 5 --> 8
     
  • Geoff Topping

    Geoff Topping - 2008-05-03
    • assigned_to: nobody --> geoffthemedio
     
  • Geoff Topping

    Geoff Topping - 2008-05-15

    Logged In: YES
    user_id=913462
    Originator: NO

    I believe this is fixed in SVN. I'm not sure if the cause was what I thought, but my recent commits seem to have stopped the crash, although more testing may show this not to be the case. Accordingly, I've marked this pending.

     
  • Geoff Topping

    Geoff Topping - 2008-05-15
    • status: open --> pending-fixed
     
  • Markus Sinner

    Markus Sinner - 2008-05-15

    Logged In: YES
    user_id=853243
    Originator: NO

    In rev 2548 it seems to be working.

     
  • Markus Sinner

    Markus Sinner - 2008-05-15
    • status: pending-fixed --> open-fixed
     
  • Geoff Topping

    Geoff Topping - 2008-05-15

    Logged In: YES
    user_id=913462
    Originator: NO

    re-marked pending since last time apparently didn't stick...

     
  • Geoff Topping

    Geoff Topping - 2008-05-15
    • status: open-fixed --> pending-fixed
     
  • SourceForge Robot

    Logged In: YES
    user_id=1312539
    Originator: NO

    This Tracker item was closed automatically by the system. It was
    previously set to a Pending status, and the original submitter
    did not respond within 14 days (the time period specified by
    the administrator of this Tracker).

     
  • SourceForge Robot

    • status: pending-fixed --> closed-fixed
     

Log in to post a comment.