#256 Fleet Arrival Sitrep ERROR if Fleet Lost

Latest Subversion
closed-fixed
nobody
None
3
2008-06-15
2006-06-04
No

If a fleet arrives in a system where another empire's
combat fleet is waiting, and the arriving fleet is
destroyed, the destroyed fleet's player gets a sitrep
message about the fleet arriving, but since the fleet
was destroyed, the listed fleet is "ERROR"

Discussion

  • guardian24

    guardian24 - 2006-06-09

    Logged In: YES
    user_id=1536944

    It is possible, as the Sitrep entry is added at the
    Movement phase, which is before the Combat phase.
    This Sitrep is added at line 1766 in ServerApp.cpp.
    I suggest adding a new Sitrep: "Fleet A arrived at sytem B,
    but was destroyed by the C empire's fleet." :))

     
  • Geoff Topping

    Geoff Topping - 2006-06-09

    Logged In: YES
    user_id=913462

    Yes, that's the initial part of what's happening... The
    sitrep gets generated on the server with a reference to a
    fleet, and is then sent to and decoded by the client. If
    the fleet is destroyed after the sitrep is generated, then
    the universe that the server sends to the client does not
    contain that fleet. Then, when the sitrep's text is
    generated by the client, it searches for the fleet
    referenced in the sitrep, but can't find it because it's not
    in the client's local universe.

    To resolve this, I'm in the midst of adding to the Universe
    class a map of "deleted objects" that is sent to players.
    This will have a few benefits, including fixing this sitrep
    bug, and also making it possible for clients ot have a list
    of all UniverseObjects that they know have been destroyed,
    such as their own fleets, ships, planets, etc.

     
  • Geoff Topping

    Geoff Topping - 2006-06-09

    Logged In: YES
    user_id=913462

    Addendum: The combined arriving & destroyed fleet sitrep
    suggestion wouldn't help, because you'd still need to
    reference the fleet as an object for the sitrep about it to
    be generated. If the fleet is destroyed by the server and
    not sent to the player, then there's no way the player's
    client can (presently) know anything about that fleet. By
    adding the deleted items map, it will be possible to have a
    sitrep that refers to a deleted / destroyed object; right
    now it's not even possible to have a "fleet X was destroyed"
    sitrep, let alone a "fleet X moved here and then was
    destroyed" combination one...

     
  • Geoff Topping

    Geoff Topping - 2008-04-13
    • status: open --> closed-fixed
     
  • Geoff Topping

    Geoff Topping - 2008-04-13

    Logged In: YES
    user_id=913462
    Originator: YES

    This has been fixed in SVN (for some time now...)

     
  • Geoff Topping

    Geoff Topping - 2008-05-15

    Logged In: YES
    user_id=913462
    Originator: YES

    This is apparently not fixed, as I'm seeing it in the SVN build...

     
  • Geoff Topping

    Geoff Topping - 2008-05-15
    • status: closed-fixed --> open
     
  • Geoff Topping

    Geoff Topping - 2008-06-15
    • status: open --> closed-fixed
     
  • Geoff Topping

    Geoff Topping - 2008-06-15

    Logged In: YES
    user_id=913462
    Originator: YES

    Fixed in SVN about two weeks ago... (hopefully for reals this time)

     

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks