#589 More XHTML

[Stalkie]

The previous issue got close quite fast :-)

I've manually processed all the WebGUI files, and have made a few more patches.
I'm not sute that I've catched all compliancy issues, but this should fix a really large piece of them.

[Stalkie]

XHTML fixes 1/3

[Stalkie]

XHTML fixes 2/3

[Stalkie]

XHTML fixes 3/3

[Volker]

Thanks, but are you sure you did test your changes? I did a quick review and found the following modification is services_dynamicdns.php

• <?php html_inputbox("domainname", gettext("Domain name"), $pconfig['domainname'], gettext("A host name alias. This option can appear multiple times, for each domain that has the same IP. Use a space to separate multiple alias names."), true, 40);?>
• <?php html_inputbox("domainname", gettext("Domain name"), $pconfig['domainname'], gettext("A host name alias. This option can appear multiple="multiple" times, for each domain that has the same IP. Use a space to separate multiple="multiple" alias names."), true, 40);?>

I'm sure 'gettext("A host name alias. This option can appear multiple="multiple" times, for each d...' will cause a PHP error.

Please validate every change will help me to reduce time of commiting your code. Doing a review will take about 30min till 1h of my time (unreviewed code will be never commited).

Regards
Volker

[Stalkie]

Hi Volker

Yes, I can see the problem. I had a friend of mine to review the code, but I guess he wasn't as thorough as I had hoped. I do apologise for this.

Also I'm sorry for this late reply, I've just been really busy at work.

I'll do a complete review myself, and report back to you, hopefully with some fixed patches.