Re: [Freemint-discuss] Bug report and patch

[Roger B. <an...@xp...>]

On 11 Mar 2018 at 19:22, David Gálvez wrote:

> 2018-03-11 18:46 GMT+01:00 Roger Burrows <an...@xp...>:
> > On 7 Mar 2018 at 18:08, Roger Burrows wrote:
> >
> >> The attached patch fixes a bug in the TOSONLY code in usb_storage.c.
> >
> > No response to this at all.  I don't have access to the FreeMiNT repository,
> so
> > can't apply the patch myself.  Can someone look at this please?
> >
> 
> Hi Roger, I can apply the patch, but I didn't do it because I wasn't
> sure if it's the maintainer who must review and commit the patches
> submitted to the list.
> I didn't want to give myself those "rights" ;-). As Alan seems to be
> very busy and if nobody complains I'll commit it.
> 
Thanks, David.  I was a bit concerned that the message hadn't made it to the 
list (SF was very flaky for a couple of weeks), so that in part prompted my 
followup.

Like you, I don't know the protocol for patch submission, so if it's best that 
Alan does the commit, I'm happy to wait.  The patch in fact *should* only 
affect users of Alan's TOS4USB code, which is at the moment limited to Unicorn 
users I think.  So if you would rather wait for a Alan, I guess that's another 
reason, although I also get the impression that he doesn't have much time ATM.

For general interest, a friend of mine is currently working on getting the 
NetUSB hardware to work with the same code, which is how I ran into this bug.

> Don't you prefer to generate the patch with "git format-patch" so it
> will be have your Github user information added?
> 
Since I don't normally have a requirement for the latest version of FreeMiNT, I 
just downloaded the tarball for the sources and patched that, so git wouldn't 
have worked.

Roger