I reviewed the task and checked after some trivial changes.
The name attribute of the scenario is also made a XmlElement and removed
(though i have not made this attribute as a required).
What it means is that the name should be initialized from the scenario.xml
One thing that came to my notice is that while designing the tasks, we
decided to keep a list<player> as well as the scenario in the configuration
But the scenario already has the players in it. and the clients can/should
choose only from these players to play.
So i think we need not keep the List<Player> in the configuration room, but
rather get it from the scenario itself.
So i suggest we should make this change.
Also for the ServerRequestConfRoomService, i suggest to add some players to
the scenario created to test thoroughly.
For this it would be better so create a scenario by unmarshalling a
scenario xml file.
On Mon, Mar 4, 2013 at 10:35 AM, premkumar bhaskal
> i think once i am done with task 170, you can pick up the task 171.
> I'll inform when i am done with it.
> On Monday, March 4, 2013, Javier Montero wrote:
>> I have an exam on wednesday but in the meantime tell me which task I
>> could develop.
>> 2013/3/3 premkumar bhaskal <pbhaskal@...>
>>> sure. i'll check it in.
>>> On 3/3/13, Javier Montero <javier1689@...> wrote:
>>> > Hello:
>>> > I am still not sure how the test should work so I have sent you the
>>> > It is all done except, maybe, the last part of the test.
>>> > I still can not commit so it is attached.
>>> > Best regards.
>>> > --
>>> > Javier Montero
>>> Premkumar Bhaskal
>> Javier Montero
> Premkumar Bhaskal
Get latest updates about Open Source Projects, Conferences and News.