#318 Heap use-after-free in BitmapAccess.cpp:498

[freeKim]

Heap use-after-free in BitmapAccess.cpp:498

Summary:

There is a heap-use-after-free in BitmapAccess.cpp:498 while loading image with FreeImage_Load function。

Version Affected: 3.19.0 (r1828)

ASAN Details

==17491==ERROR: AddressSanitizer: heap-use-after-free on address 0x602000000010 at pc 0x000000507b76 bp 0x7ffda760d2b0 sp 0x7ffda760d2a8
READ of size 8 at 0x602000000010 thread T0
    #0 0x507b75 in FreeImage_Unload /home/src/freeimage-svn/FreeImage/trunk/Source/FreeImage/BitmapAccess.cpp:498:20
    #1 0x506424 in main /home/src/freeimage-svn/FreeImage/trunk/load-test.c:18:3
    #2 0x7fa5e9f52b6a in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x26b6a)
    #3 0x428569 in _start (/home/src/freeimage-svn/FreeImage/trunk/load-test+0x428569)

0x602000000010 is located 0 bytes inside of 8-byte region [0x602000000010,0x602000000018)
freed by thread T0 here:
    #0 0x4d3b92 in free /build/llvm-toolchain-8-F3l7P1/llvm-toolchain-8-8/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:124:3
    #1 0x507fe4 in FreeImage_Unload /home/src/freeimage-svn/FreeImage/trunk/Source/FreeImage/BitmapAccess.cpp:529:3
    #2 0x5de4fe in void loadRLE<8>(FIBITMAP*, int, int, FreeImageIO*, void*, long, int) /home/src/freeimage-svn/FreeImage/trunk/Source/FreeImage/PluginTARGA.cpp:596:3
    #3 0x5d7a22 in Load(FreeImageIO*, void*, int, int, void*) /home/src/freeimage-svn/FreeImage/trunk/Source/FreeImage/PluginTARGA.cpp:861:7
    #4 0x5252fc in FreeImage_LoadFromHandle /home/src/freeimage-svn/FreeImage/trunk/Source/FreeImage/Plugin.cpp:388:24
    #5 0x52550c in FreeImage_Load /home/src/freeimage-svn/FreeImage/trunk/Source/FreeImage/Plugin.cpp:408:22
    #6 0x50640c in main /home/src/freeimage-svn/FreeImage/trunk/load-test.c:16:18
    #7 0x7fa5e9f52b6a in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x26b6a)

previously allocated by thread T0 here:
    #0 0x4d3f13 in __interceptor_malloc /build/llvm-toolchain-8-F3l7P1/llvm-toolchain-8-8/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:146:3
    #1 0x5068fa in FreeImage_AllocateBitmap(int, unsigned char*, unsigned int, FREE_IMAGE_TYPE, int, int, int, unsigned int, unsigned int, unsigned int) /home/src/freeimage-svn/FreeImage/trunk/Source/FreeImage/BitmapAccess.cpp:371:33
    #2 0x50789d in FreeImage_AllocateHeader /home/src/freeimage-svn/FreeImage/trunk/Source/FreeImage/BitmapAccess.cpp:482:9
    #3 0x5d5b3b in Load(FreeImageIO*, void*, int, int, void*) /home/src/freeimage-svn/FreeImage/trunk/Source/FreeImage/PluginTARGA.cpp:740:11
    #4 0x5252fc in FreeImage_LoadFromHandle /home/src/freeimage-svn/FreeImage/trunk/Source/FreeImage/Plugin.cpp:388:24
    #5 0x52550c in FreeImage_Load /home/src/freeimage-svn/FreeImage/trunk/Source/FreeImage/Plugin.cpp:408:22
    #6 0x50640c in main /home/src/freeimage-svn/FreeImage/trunk/load-test.c:16:18
    #7 0x7fa5e9f52b6a in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x26b6a)

SUMMARY: AddressSanitizer: heap-use-after-free /home/src/freeimage-svn/FreeImage/trunk/Source/FreeImage/BitmapAccess.cpp:498:20 in FreeImage_Unload
Shadow bytes around the buggy address:
  0x0c047fff7fb0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c047fff7fc0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c047fff7fd0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c047fff7fe0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c047fff7ff0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
=>0x0c047fff8000: fa fa[fd]fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c047fff8010: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c047fff8020: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c047fff8030: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c047fff8040: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c047fff8050: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
Shadow byte legend (one shadow byte represents 8 application bytes):
  Addressable:           00
  Partially addressable: 01 02 03 04 05 06 07 
  Heap left redzone:       fa
  Freed heap region:       fd
  Stack left redzone:      f1
  Stack mid redzone:       f2
  Stack right redzone:     f3
  Stack after return:      f5
  Stack use after scope:   f8
  Global redzone:          f9
  Global init order:       f6
  Poisoned by user:        f7
  Container overflow:      fc
  Array cookie:            ac
  Intra object redzone:    bb
  ASan internal:           fe
  Left alloca redzone:     ca
  Right alloca redzone:    cb
  Shadow gap:              cc
==17491==ABORTING

Reproduce

To reproduce it ,compile FreeImage with ASAN. Then compile and execute the test file in the attachment as follows:

Clang++ -g -fsanitize=address load-test.c -lfreeimage -L. -lm -o load-test
./load-test UAF_BitmapAccess.cpp_498

Credit

ADLab of Venustech

[Hervé Drolon]

see https://sourceforge.net/p/freeimage/patches/142/