Just caught this while browsing the trunk. Not an issue yet, but something to keep in mind.
static int xrandr_resize(int xsz, int ysz, int rate, int just_checking)
58 /* we only heed the rate if we CAN actually use it (Xrandr >= 1.1) and
59 * the user actually cares about it (rate > 0)
61 use_rate = rate > 0 && ver_major >= 1 && ver_minor >= 1;
Shouldn't this be:
use_rate = rate > 0 && ( ver_major > 1 || (ver_major == 1 && ver_minor >= 1) );
Otherwise version 2.0 (if it gets up that high) will yield false cause minor is not one or greater?
Also for same reason, these conditional compile statements:
#if RANDR_MAJOR >= 1 && RANDR_MINOR >= 1
should be something like:
#if RANDR_MAJOR > 1 || (RANDR_MAJOR == 1 && RANDR_MINOR >= 1)
Log in to post a comment.