Receiving an error when I attempt to compile via Ant command as of [80620a]. src\net\sf\frecol\common\ioFreeColDatafile.java is the issue. Map.of() seems to have the issue.
Not only Java 8, but Java 8 is the minimum supported. So, a Java 9-ism like Map.of() is a mistake... at least right now. However Java 8 will no longer be supported in a few months, so we probably should jump to the next LTS version soon, which is 11. FTR, Java 11 works fine for me, and has for some time. Is it available for you?
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I'd think, fixing this now and upgrading when the release is done would be the logical way forward. Remember we have that security fix waiting still. Upgrading and changing everything to use new features would only delay the release.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
While I understand that perspective, I've already begun marking the need for Java 9. An full admin on SF will need to update some messaging here, but we don't need to use any new language features other than what's been added.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Pardon me if i missed it, but is this a Java 8 vs. 9 issue? I thought Freecol was only Java 8?
Looks like Map.of() was introduced via [7c0a1].
Not only Java 8, but Java 8 is the minimum supported. So, a Java 9-ism like Map.of() is a mistake... at least right now. However Java 8 will no longer be supported in a few months, so we probably should jump to the next LTS version soon, which is 11. FTR, Java 11 works fine for me, and has for some time. Is it available for you?
I can upgrade to it. I just never updated the JDK because all I used it for was Freecol.
I'd think, fixing this now and upgrading when the release is done would be the logical way forward. Remember we have that security fix waiting still. Upgrading and changing everything to use new features would only delay the release.
While I understand that perspective, I've already begun marking the need for Java 9. An full admin on SF will need to update some messaging here, but we don't need to use any new language features other than what's been added.
@mpope I upgraded to JRE 11 and the most recent version of Ant and could compile successfully.
Release is imminent. git.6621e7e bumps the minimum required Java to 11. Setting to Pending.