#44 various patches

closed-accepted
None
5
2008-07-15
2008-07-14
No

This various patches contains:

Edit.patch (replacing previous 2014995):

With this patch, editfloat is now set to -1 by default, which accepts unlimited number of decimals.
Number of decimals can still be set to a limited number, even to 0.
Also, on changing the value of editcurrency by program, text displays with the decimals as it it should

EditCombo.patch:

Add Autocompletion and AllowNew settings at CreateEditCombo, to make it more convenient.
Make FocusItem set to last item when a newitem is accepted

Gfx_Widget.patch:

Add FFocusable condition so that Focusable set to False works for more components (EditCombo for instance).

Discussion

  • Jean-Marc Levecque

    zip file contains gfx_widget, editcombo, and edit patches

     
  • Jean-Marc Levecque

    gui_label patch to work with gfx_widget patch

     
  • Jean-Marc Levecque

    Logged In: YES
    user_id=2004773
    Originator: YES

    This additional patch is needed to allow mouse click on a label
    File Added: gui_label.patch

     
  • Jean-Marc Levecque

    Logged In: YES
    user_id=2004773
    Originator: YES

    Using the currencyedit, I found a bug when setting a value by program.
    This patch includes the modification to clear this bug

    File Added: gui_edit.patch

     
  • Jean-Marc Levecque

    upadated gui_edit patch

     
  • Graeme Geldenhuys

    • assigned_to: nobody --> graemeg
    • status: open --> pending
     
  • Graeme Geldenhuys

    Logged In: YES
    user_id=184122
    Originator: NO

    The following relates to the 'various' patch:

    I rejected the following change to gfx_widget.pas
    procedure TfpgWidget.HandleLMouseUp(x, y: integer; shiftstate: TShiftState);
    begin
    - if Assigned(FOnClick) then
    + if Assigned(FOnClick) and Focusable then
    FOnClick(self);
    end;

    Just because it's not focusable, doesn't mean we must not allow it to be clickable. eg: Say you create a Icon Edit Canvas component. It wouldn't be focusable (keyboard usage makes no sense - I think), but you would want users to click in the Canvas and draw with the mouse.
    Or in the case of HyperLabel. You don't want it focusable, but you want it clickable.

    I couldn't manage to apply the gui_edit patch. I got to many failures. Could you recreate that files patch please using the latest svn revision. Many thanks.

     
  • Graeme Geldenhuys

    Logged In: YES
    user_id=184122
    Originator: NO

    The following relates to the 'gui_label.patch' patch:

    I fail to understand why you would want a Label component focusable? It requires no input. And due to the previous reject changes in gfx_widget, even though it's not focusable, it is still clickable. So hyperlabel will continue to work.

     
  • Graeme Geldenhuys

    Logged In: YES
    user_id=184122
    Originator: NO

    This relates to the 'gui_edit.patch' latest patch.

    I can't apply this either, due to to many failures. Could you recreate the patch using the latest svn revision please. Thanks again for all your work.

     
  • Jean-Marc Levecque

    • status: pending --> open
     
  • Jean-Marc Levecque

    gui_edit patch update to last revision

     
  • Jean-Marc Levecque

    Logged In: YES
    user_id=2004773
    Originator: YES

    Attached is a new gui_edit patch produced with last svn revision
    After retest, I agree with your comments about gfx_widget and label patches.
    Busy porting an app, I was a bit confusing things.
    Sorry for the inconvenience

    File Added: gui_edit1.patch

     
  • Graeme Geldenhuys

    • status: open --> closed-accepted
     
  • Graeme Geldenhuys

    Logged In: YES
    user_id=184122
    Originator: NO

    gui_edit1.patch committed in revision 887. Thank you. ;-)

     

Log in to post a comment.