[Formsess-devel] Variables in tag attributes, automated tests

[David <da...@df...>]

Hello Pierre,

thanks for the feedback! I removed the uneeded code (just forgot it
yesterday) and modified the example to use the SmartyFormsess class in
libs/ to make it work again.

I cc'ed formsess-devel again, this might be interessting for others as
well..

About your proposal: In fact I did lots of work to allow smarty syntax
in most of the tag attributes to make formsess as flexible as possible.
The only attributes that must contain fixed values are those processed
by the prefilter.
It's type, name and check afaik, they're used to add the javascript
validation code (for this the field types must be checked).

I'd be happy to extend the flexibility however the formsess code should
be kept simple for both performance and maintance reason.

I'm looking forward to have a look at your proposal!

About test units/scripts: we don't have any (at least not that I know..)
Betrand?
I'm not familar with automated testing. Would you use PEAR's php unit(2)?
What kind of tests would you create for formsess? (maybe you can just
include your tests for the validate tag you talked about)

- david

On Fri, 4 Jun 2004 13:45:23 +0200
"Raoul Pierre" <pie...@wa...> wrote:

> Hello David,
>=20
> > I found some time to look over that again and it should really work
> > now.
> >=20
> > I don't have time to heavily test it at the moment. You could help a
> > lot by trying if it works for you now.
>=20
> First tests seem ok.  Just remove
>=20
>     elseif ($type =3D=3D 'input_checkbox') {=20
>       //this matches both undefined and defined indexes
>       if (preg_match('!\[(.*)\]$!', $this->getAttributeValue('name'),
>       $m_offset)) {
>         $this->setAttributeValue('cb_offset', $m_offset[1]);
>       }
>=20
> from FormsessTagInput::getTag=20
>=20
> Or add somewhere in smarty_function_fs_input_checkbox the code:
>    =20
>     unset(params['cb_offset'])
>=20
> Note: now that Smarty_formsess.class.php is no more in Samples dir,
> the sample is broken. So I added a new Smarty_formsess.class.php file
> with...
>=20
>   <?php
>   require FORMSESS_SMARTY_PATH.'Smarty.class.php';
>   require '../libs/SmartyFormsess.class.php';
>=20
>   class Smarty_Formsess extends SmartyFormsess {
>=20
>     function Smarty_formsess() {
>       $this->SmartyFormsess();
>     }
>   }
> ?>
>=20
> > (I changed only that one file, so you could quickly grab it from
> > svn. If that's a problem tell me, then I can eMail it to you.)
>=20
> I have no more problem to access to the svn repository (the new text
> in the download page on Formsess Web site is now ok).=20
>=20
> For your information, I have tested the function.fs_input_checkbox.php
> file from 25-05-04's Formsess-Trunk.tgz and it was already ok for me.
> So ...
>=20
>            *****
>=20
> I take advantage of this answer to ask your opinion about an idea.
>=20
> I am working on an program with a Presentation/Business/Data access
> layers pattern. I want to specify:
>=20
> - the validation of inputs from the Business layer (likely with some
> wrapping in the Presentation layer). All the knowledge about data has
> to be confined in the Business layer.
>=20
> - the type of HTML input from the workflow part of the Presentation
> layer.=20
>=20
> I'm working with Copix framework (http://copix.aston.fr). Copix is
> built on the MVC pattern. It uses heavely Smarty as template engine.
>=20
> About Formsess: I need to be able to set very late the value of
> attributs in the template tags. In fact nothing coded in the template
> itself: all the mandatory attributs must be specify by variable. Even
> the type of input tag.
>=20
> At the moment, it's not possible to do it with Formsess. I'm using the
> Formsess-Trunk.tgz from 25-05-04.
>=20
> >From a rapid look, I think it would not be too hard to improve
> >Formsess in this way. I have already tested some changes needed to
> >this (mainly by setting Smarty variable very late: at run time, from
> >the Smarty function).=20
>=20
> Currently I am working on the fs:validate itself. I think I will have
> some working and tested(=B0) version of fs:validate at the end of next
> week. In a first step, with some strong restrictions (as the
> impossibility to use the same variable to specify name of differents
> tags as soon as the first one has a validate tag), but easy to deal
> with.
>=20
> Are you interested by such a job? If yes, have you any recommandation
> on the way to sent it.
>=20
> Note (=B0): I didn't see any unit test class in the SVN repository. Have
> you any? If not, have you any test script(s)?
>=20
> Regards
>=20
> Pierre
>=20
>=20
>=20