Re: [Formsess-devel] coding style: intendation

[David <da...@df...>]

On Sat, 24 Apr 2004 13:30:59 +0200
Katana <ka...@ka...> wrote:

> > The intendation of the code is rather inconsistent atm, there're
> > some tabs and different numbers of spaces used.
> As far as I'm concerned, I always use 2 spaces for 1 tab. But it is 
> posisble that I've edited a few files with an editor that was not 
> properly configured.

Guess mainly I messed up the intendation, I didn't even know we use 2
spaces.. ;)
(the pear standard says 4, personally I'm fine with 2, though it's
somehow inconvenient..)


> > Except of the intendation, that we don't use the one-true-brace
> > convention for functions and some naming issues the code follows the
> > pear cs, I guess. It won't be a bad idea to run it through some code
> > beautifier to see if everything's fine however.
> Hmmm there are parts of the PEAR CS I don't appreciate, and 
> one-true-brace is one of them. Err one true brace is
> function foo()
> {
> ...
> }
> right ? I never remember if it's that or the other way around, but 
> whatever :)

Yes.


> As long as the coding style is consistent I don't think we HAVE to
> stick to one CS, what do you think ?

Yes I agree, I didn't want to say it has to be changend I justed wanted
to mention that we differ in that way..
(though renaming the internal stuff using studlyCaps would be nice,
someday..)


> I could run PHPEdit's CodeBeautifier on 
> the files but there are a few details in the syntax that are not
> handled properly :-(

Maybe you can let it just correct the intendation, then see what else
it suggests and decide whether it makes sense or not.

- david