From: Katana <ka...@ka...> - 2004-04-24 11:29:03
|
> The intendation of the code is rather inconsistent atm, there're some > tabs and different numbers of spaces used. As far as I'm concerned, I always use 2 spaces for 1 tab. But it is posisble that I've edited a few files with an editor that was not properly configured. > We should correct that before releasing 2.0, someone might have a look > at the code and we don't want to scare people away, do we? ;) Indeed :) > Except of the intendation, that we don't use the one-true-brace > convention for functions and some naming issues the code follows the > pear cs, I guess. It won't be a bad idea to run it through some code > beautifier to see if everything's fine however. Hmmm there are parts of the PEAR CS I don't appreciate, and one-true-brace is one of them. Err one true brace is function foo() { ... } right ? I never remember if it's that or the other way around, but whatever :) As long as the coding style is consistent I don't think we HAVE to stick to one CS, what do you think ? I could run PHPEdit's CodeBeautifier on the files but there are a few details in the syntax that are not handled properly :-( Katana |