[Formsess-devel] A few things I noticed

[Katana <ka...@ka...>]

 > - in input.class.php the parent constructor is called with passing
 > $fs_filter by ref:
 >     parent::FormsessTag(&$fs_filter);
 > Doesn't make sense since the argument is defined to be passed by ref.

Fixed

 > - in validate.class.php in the definition of the constructor $fs_filter
 > is NOT defined to be passed by ref:
 >     function FormsessTagValidate($fs_filter) {

Fixed

 > - defining FS_INC_FORMSESS_TAG in FormsessTag.class.php and checking for
 > being defined in the extending classes can be replace by a check using
 > class_exists('FormsessTag').

Yes, indeed. However, both work and I don't feel like editing all the 
files at the moment :)

 > - names of variables differ, most of them use underlines and some studly
 > caps f.e. $_enableJSValidation

Yes. In the beggining I was using underscore as a separator but I'm no 
longer using it. I'll work on refactoring all property names but it's a 
bit useless at the moment since big parts of the code are gonna get 
modified soon. I am and will be using the caps method.

-- 
  Katana