[Formsess-devel] A few things I noticed
Status: Beta
Brought to you by:
mrkatana
|
From: David <da...@df...> - 2003-12-09 22:05:58
|
Hello,
here are just a few thing I noticed while browsing through formsess:
- in input.class.php the parent constructor is called with passing
$fs_filter by ref:
parent::FormsessTag(&$fs_filter);
Doesn't make sense since the argument is defined to be passed by ref.
- in validate.class.php in the definition of the constructor $fs_filter
is NOT defined to be passed by ref:
function FormsessTagValidate($fs_filter) {
- defining FS_INC_FORMSESS_TAG in FormsessTag.class.php and checking for
being defined in the extending classes can be replace by a check using
class_exists('FormsessTag').
- names of variables differ, most of them use underlines and some studly
caps f.e. $_enableJSValidation
david
|