From: Nick B. <ni...@co...> - 2002-01-14 22:40:05
|
Right, There's a saying "Code to an interface, not an implementation". It applies here. The reason for the inderection is because other people will want to include Anthony's system within theirs and will not be able to unify the logging if there is a direct dependency on log4j in FormProc, _even if they want to use log4j in their own systems_. > Eric, > > The LogManager is there to support multiple logging systems. I added > this as a suggestion from one of FormProc's users who pointed out that > developers may be required to use a particular logging system other > than Log4J and FormProc should be flexible enough to handle those other > systems. > > Rather than only use Log4J I would prefer to improve the LogManager and > the way it is integrated with FormProc. For example it would probably > be a good idea to automatically configure FormProc to use a logger > specified in the formproc.xml file. In addition I could improve the > System.out logger so that it can understand property files. Finally I > can improve the > documentation so that logging is easier to understand (of course > integrating LogManager into FormProc better might remove the need for > this last step.) > > As for contributions: initially I would prefer if you send the code so > that I can determine if it fits well into FormProc, both logically and >stylistically. If you do this at least once and it works out fine then >I have no problem adding you in as a developer. The more people >involved the better. > > Sincerely, > Anthony Eden > >> -----Original Message----- >> From: for...@li... >> [mailto:for...@li...]On Behalf Of >> Eric Beaumier >> Sent: Monday, January 14, 2002 4:51 PM >> To: for...@li... >> Subject: RE: [FormProc-developer] Log4J & LogManager in FormProc >> >> >> >> >> >Make sure that the following line is in your main() method: >> > >> >LogManager.setLoggerClassName("com.anthonyeden.lib.log.Log4JLogger"); >> > >> >It should really be the very first line in the main() method. >> > >> >The default logger is actually just a System.out logger and it does >> >not understand property file configuration. I am considering making >> Log4J the >> >default logger in the LogManager...what do you think? >> >> Yes. Why the LogManager, to support more than one Logger component? >> >> I think the better way, it to let entirely the job to Log4J, by >> removing the >> LogManager step. Not because the code is not correct, >> but this class don't give value added. >> >> Actually, by logging all at the console, the problem here, it slow >> down considerably the validation process. Because all are logged in >> the System.out and this one is a Synchronized method ... With one >> Thread, it's not a problem, but when you have a lot of it, it can be a >> bottleneck. >> >> This what I think, correct me if I'm wrong. >> >> >> Do you accept contributor in your Open Source? Or do you prefer than >> we send you the code and you will do the update? >> >> Thanks. >> >> >> >> >> >> >> >> >> >> _________________________________________________________________ MSN >> Photos is the easiest way to share and print your photos: >> http://photos.msn.com/support/worldwide.aspx >> >> >> _______________________________________________ >> FormProc-developer mailing list >> For...@li... >> https://lists.sourceforge.net/lists/listinfo/formproc-developer >> > > > _______________________________________________ > FormProc-developer mailing list > For...@li... > https://lists.sourceforge.net/lists/listinfo/formproc-developer -- Nick Bauman Cortexity Development Intellectual Process is more important than Intellectual Property -- you'll see. http://www.cortexity.com/ |