#6309 REST: install_tool:mount_point restrictions are not same as via web interface

fixed
cygwin-ports
2014-01-09
2013-12-19
No

Following up on the cygwin-ports upgrade:

I have been unable to create Git repos via the REST API whose mount_point param contain an underscore, even though such repo names are legal and can be created via the admin/tools web interface. The cause appears to be allura/ext/admin/admin_main.py (line 776 in git master):

    if not h.re_tool_mount_point.match(mount_point) or c.project.app_instance(mount_point) is not None:
        return {'success': False,
                'info': 'Incorrect mount point name, or mount point already exists.'
                 }

Should that not be something like this instead:

    if c.project.app_instance(mount_point) is not None:
        return {'success': False,
                'info': 'Mount point already exists.'
                 }
    if not h.re_relaxed_tool_mount_point.match(mount_point):
        return {'success': False,
                'info': 'Incorrect mount point name.'
                 }

IOW, separate the errors for easier diagnosis, and more importantly, use re_relaxed_tool_mount_point to match the web interface.

Discussion

  • Anonymous - 2013-12-19
    • labels: --> engr, nf-7007
    • status: unread --> assigned
     
  • Anonymous - 2013-12-19

    Thank you for your concern, this is being raised to our engineering team here: [allura:tickets:#7007]

    Regards,
    Chris Tsai, SourceForge.net Support

     
  • Anonymous - 2014-01-09
    • status: assigned --> fixed
     
  • Anonymous - 2014-01-09

    This change is live on site.

    Regards,
    Chris Tsai, SourceForge.net Support

     

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks