Menu

#866 Create palette entries through extensionpoint.

1.6
closed-accepted
nobody
None
4DIAC-IDE
Patch
5
2014-07-16
2014-06-18
No

This patch includes a new extension point for creating palette entries and an modified method which uses this extension point for all implemented palette entries in 4Diac.
The advantage is that the palette entries are no more hardcoded in Palette.java and it is easy to create new palette entries from external plug-ins.

1 Attachments

Discussion

  • Zoitl Alois

    Zoitl Alois - 2014-06-18

    Thanks for this patch. You are definitely right this makes it much more easy to extend 4DIAC-IDE.

    I reviewed your patch and found some issues. Could you please fix these and resubmit a cleand-up patch?

    First of all it seams that the schema file (PaletteEntryCreator.exsd) of the new extension point is missing. This could be a problem of mercurial. If this is so please just attach it separately to this issue.

    The content tag in your new extension point is called <editpartcreator>. For me this seams a little bit missleading as we have a PaletteEntryCreator. </editpartcreator>

    I like to put all strings together in the TypeLibraryTags class. But as the members are public static wouldn't it be nicer to just use the values instead of inheriting from this interface?

    Your patch contains to files from the org.fordiac.ide.ui.controls plugin which seam unrelated to your changes. Could you please remove these from the patch.

     
  • Waldemar Eisenmenger

    Thanks for reviewing and commenting.
    Here is my cleaned up patch: I added the missing schema file, and renamed the content tag of the new extension point.
    I had created the TypeLibraryTags class because the included constants are also used in the TypeLibrary class.

     
  • Zoitl Alois

    Zoitl Alois - 2014-06-23
    • status: open --> closed-accepted
     
  • Zoitl Alois

    Zoitl Alois - 2014-06-23

    Thanks for the improvements.

    Applied the 2nd revision in cset [fordiac-ide:06d90e]

     

    Related

    Commit: [06d90e]

  • Waldemar Eisenmenger

    Hi,
    I had forgot to add two files with the last patch. Sorry!
    Here is the next patch.

     

Log in to post a comment.

MongoDB Logo MongoDB