#861 Import via typenavigator-view

[Waldemar Eisenmenger]

right-click in typenavigator-view --> Import --> Distributed Control System --> Import IEC 61499 Types --> and then any click in the wizard throws the following exception:

org.eclipse.core.runtime.AssertionFailedException: null argument:
at org.eclipse.core.runtime.Assert.isNotNull(Assert.java:85)
at org.eclipse.core.runtime.Assert.isNotNull(Assert.java:73)
at org.eclipse.jface.viewers.StructuredViewer.assertElementsNotNull(StructuredViewer.java:597)
at org.eclipse.jface.viewers.StructuredViewer.getRawChildren(StructuredViewer.java:1011)
at org.eclipse.jface.viewers.ColumnViewer.getRawChildren(ColumnViewer.java:721)
at org.eclipse.jface.viewers.AbstractTreeViewer.getRawChildren(AbstractTreeViewer.java:1351)
at org.eclipse.jface.viewers.TreeViewer.getRawChildren(TreeViewer.java:391)
at org.eclipse.jface.viewers.StructuredViewer.getFilteredChildren(StructuredViewer.java:917)
at org.eclipse.jface.viewers.AbstractTreeViewer.getSortedChildren(AbstractTreeViewer.java:620)
at org.eclipse.jface.viewers.AbstractTreeViewer$1.run(AbstractTreeViewer.java:820)
at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:70)
...

[Monika Wenger]

as far as I know the "Import IEC 61499 Types" is not required for the Import of FBs since this can be achieved by copy&pasted within the Type Navigator. But since this functionality is still required for the XML System Import it might be a solution to remove the wizard for the "Import IEC 61499 Types". Any conerns about such a solution?

[Zoitl Alois]

AFAIK this wizard window is also shown when the XML system import does not automatically find all types. Therefore I think the bug needs a fix.

However I would also recommend to remove this wizard from the wizard list as the copy paste features are much more intuitive.

[Monika Wenger]

I removed the type Import from the wizard list in cset [fordiac-ide:6a9e04] and tried to Import a *.sys file with and without library. The System Import only lists the missing FBs but does not Show the FB Import wizard any more. If I did not miss a case where it Shows up, I'll Close this issue.

[Zoitl Alois]

@Monika: I had a look at the code as your comment made me curious you are right we where using only a small part of the type import code for handling missing types (about 30 lines of code).

I took this as chance and moved this code to the system import. In cset [fordiac-ide:962083] you can find this approach. However I was not able to test it. I would be glad if somebody could test if the system import is still working.

If this is the case we could get rid of the whole typeimport plugin.

[Monika Wenger]

typeimport plugin removed,

cset [fordiac-ide:6a9e04]
cset [fordiac-ide:962083]
cset [fordiac-ide:c18c94]