Re: [foo-devel] OK to commit? a few cleanings...

[Gerhard E. <ec...@ie...>]

Dear Martin,

from my side: go ahead!

Best regards,

Gerhard

On Mar 23, 2009, at 7:54 PM, Martin Rumori wrote:

> Dear fooers,
>
> as we discussed approx. one year ago or so, for consistency I prepared
> the following cleanups:
>
> 1. foo-default-soundfile-format
>
> -> was a variable, is now a function, with setter/getter methods:
>
> (foo-default-soundfile format)
> (set-foo-default-soundfile format!)
>
> and the corresponding "internal" functions:
>
> (foo:default-soundfile format)
> (foo:set-default-soundfile format!)
>
>
> 2. foo-default-soundfile-filetype
>
> -> same as above, plus:
>
> -> I moved these definitions from util/soundfile-funs.foo to
>   kernel/elkfoo.scm in order to have these definitions in one place
>   (was distributed over both files before)
>
> -> as I saw from Ramon's definitions in util/soundfile-funs.foo, the
>   name "foo-default-soundfile-filetype" reads a bit strange, so I
>   changed it to "foo-default-soundfile-type", which is more
>   intuitive.
>
> -> for consistency, this also meant to change "soundfile-filetype" to
>   "soundfile-type" and the kernel function "foo:soundfile-filetype"
>   to "foo:soundfile-type" in elkfoo/src/soundfile.m
>
> -> all this hassle was caused by myself, but for the reason, that
>   there was the distinction between "snd-type" and "snd-filetype",
>   where "snd-type" means the Substrate class of a snd substrate.  But
>   I think the risk of mixing both up is low or it should be fixed
>   here (e.g. "snd-class") instead of using "soundfile-filetype",
>   which is rather ugly....
>
>
> 3. foo-default-play-command
>
> -> same as 1.
>
>
> 4. foo-default-edit-command
>
> -> same as 1.
>
>
> 5. I changed all occurrences of the abovementioned variables/functions
>   which I could find with grep in the scheme code.  I just wanted to
>   know whether you use these functions extensively in your code,
>   which would be broken by these changes, or
>   whether it would be o.k. to commit these changes to CVS.
>
>
> Thanks for a notice, all the best,
>
> Martin
> ------------------------------------------------------------------------------
> Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM)  
> are
> powering Web 2.0 with engaging, cross-platform capabilities. Quickly  
> and
> easily build your RIAs with Flex Builder, the Eclipse(TM)based  
> development
> software that enables intelligent coding and step-through debugging.
> Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com_______________________________________________
> foo-devel mailing list
> foo...@li...
> https://lists.sourceforge.net/lists/listinfo/foo-devel