Hi Behdad,

I applied the following 2to3 fixes to make the code compliant:

http://docs.python.org/2/library/2to3.html#2to3fixer-dict
http://docs.python.org/2/library/2to3.html#2to3fixer-map

Replacing map with list comprehensions is probably better.  I'm not that familiar with either map or list comprehensions so I've left them as they are for now.

Thanks,

Andrew



On 22 November 2013 00:32, Behdad Esfahbod <behdad@behdad.org> wrote:
On 13-11-21 11:04 AM, Andrew Miller wrote:
> I have been working on a number of fixes to make FontTools compatible with
> Python 3.x.  I am having trouble creating a fork in Sourceforge (getting a
> HTTP 500 error), so for now I have hosted a git repository on BitBucket at
> https://bitbucket.org/Milla/fonttools.

Hi Andrew,

I took a quick look.  Looks good.  A few comments:

  - Instead of "Wrapped map methods with calls to list()", perhaps just
replace them with list comprehension?  Ie. instead of list(map(string.atoi,
things)), do [string.atoi(x) for x in things]?

  - Re "Wrapped dict methods with calls to list()", is there not a better way
recommended to do this?  I don't know.  Just asking.

I plan to pick these up in my tree (github.com/behdad/fonttools) soon.

Cheers,

--
behdad
http://behdad.org/