From: Evan R. <eva...@gm...> - 2006-05-03 11:59:41
|
@Andrew: i tend to like partials, since i did it on an asp project over 5 years ago which was displaying various items (replacement parts) from a corporate datawarehouse. it's a good concept which makes the code easy to use...but i'm not sure if it would also be overkill for us, since all of our items are identical and rather small snipets of code. it may be very useful if we want to develop different views of an item...say with tagging on and off, or with images filtered out, or a compact view which truncs only the first 200 chars, or whatever. but as long as theres not much option or filtering there, then it really just adds more layers that aren't really useful. but, i like the concept...but only if there's a good need for it. On 5/3/06, Andrew Turner <ajt...@hi...> wrote: > Good start, glad to see a framework up. > > A couple of things I see can be done: > > * put an id on the body tag so we can then use that to style special > elements for a page. > * the class login will really be a form. I don't think it needs a > special "login" class > * What about an image replacement technique for the logo image > (Bowman, Leahy, Phark, whichever suits you) > > Also, as you're putting together the CSS - it may be nice to break > apart the structure from the color into separate CSS files. Will make > it easier in the future for someone to "style" it themselves :) > > Programmers - since we've brought up newer frameworks as possible > inspiration, what do you think of using "partials". Basically, a > partial would be an _item.php file that just had the markup to display > an item. Then the view.php would do (pseudocode): > > <? > for $item in $items > include "_item.php"; > ?> > > and _item.php is > > <div class=3D"item" id=3D"item_<?=3D$item->id?>"> > <?=3D $item->content?> > </div> > > I'm not sure how this would be best done in PHP. > > Andrew > > > > > On 5/3/06, Broken Kode <kha...@gm...> wrote: > > Ok I had a bit of time this evening, so I played around with some code > > and got the pages I need to create set up. > > > > The one that's more or less there is the login page. Yes I know I've > > created far too many classes so soon in the game but I can see areas > > where some of them (like remember and forgot) can be renamed and reused > > once I get round to creating the setup and admin pages, but until I get > > there I'm just going to keep adding to get it all right and then > > optimize at the end. > > > > If anyone can see areas where you can cut down please don't be shy. > > > > You can download it from here: (I sent it like 3 times before I > > remembered that we can't send any attachments on the mailing list. > > Andrew any chance we can sort this out?) > > www.brokenkode.com/downloads/HTMLv0-1.zip > > > > Can someone also validate my css, the .login background is giving me > > some problem which I can't sort out. > > > > Also can someone have a look at the index page. I'm not that great at > > iframes so I can't seem to get the blasted things to do what I want the= m > > to do (mainly show no borders and the top frame to be set where the > > navigation will have a fixed height, 60px or whatever). > > > > khaled > > > > > > ------------------------------------------------------- > > Using Tomcat but need to do more? Need to support web services, securit= y? > > Get stuff done quickly with pre-integrated technology to make your job = easier > > Download IBM WebSphere Application Server v.1.0.1 based on Apache Geron= imo > > http://sel.as-us.falkag.net/sel?cmd=3Dlnk&kid=3D120709&bid=3D263057&dat= =3D121642 > > _______________________________________________ > > Fofredux-devel mailing list > > Fof...@li... > > https://lists.sourceforge.net/lists/listinfo/fofredux-devel > > > > > -- > Andrew Turner > ajt...@hi... 42.4266N x 83.4931W > http://highearthorbit.com Northville, Michigan, USA > > > ------------------------------------------------------- > Using Tomcat but need to do more? Need to support web services, security? > Get stuff done quickly with pre-integrated technology to make your job ea= sier > Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronim= o > http://sel.as-us.falkag.net/sel?cmdlnk&kid=120709&bid&3057&dat=121642 > _______________________________________________ > Fofredux-devel mailing list > Fof...@li... > https://lists.sourceforge.net/lists/listinfo/fofredux-devel > |