Re: [Fofredux-devel] time parsing with RSS1.0 and Atom feeds

[Kevin <ke...@dr...>]

Evan Roth wrote:
> Hi Guys,
>
> my first time jumping in here, so allow me to first say thanks for 
> picking up this great project again.  (if you guys are still 
> active...saw that the dev mails were only up til late Feb at sf.net 
> <http://sf.net>).
>
Welcome Evan.  The list has been a bit slow over the last few weeks.  I 
expect things will pick up after the 0.3 release. (hint hint: Andrew)

> In the course of doing a complete overhaul of my server this week, it 
> was time to get a fresher feeds reader, and naturally i went with 
> something i knew, as i had been using fof for well over a year now.
>
> After installing fofredux, and importing my feeds and their 
> corresponding items (i don't delete anything), i noticed that updates 
> on some of the feeds were losing their dates.  They were in fact 
> defaulting to 01-01-1970, and it was all atom (see anything at 
> blogger.com <http://blogger.com>) and RSS1.0 (e.g. slashdot), which is 
> actually the Atom format.  RSS 2.0 feeds are fine.
>
What version of fofredux are you using?   I subscribe to slashdot also 
and don't see this behavior with a recent CVS snapshot.

> Digging through the code, i realized it's not entirely our problem, as 
> we call the magpie parsing function parse_w3cdtf for those two types 
> of feeds, which is not functioning as desired.  In fact, these dates 
> are not w3c standard:  w3c contains no : in the timezone, whereas Atom 
> time does.
>
> The fix for this problem...at least so far on my side...is to simply 
> replace this function with the native PHP strtotime() twice in init.php.
> I've tested on PHP 5.0.5 and 5.1.2 with success.  Don't have any php 
> 4.X.X running here. 
>
> I guess the real fix would be to repair the magpie function...but I'm 
> not sure it's necessary when php provides native support.
>
> Hope that might help anyone else out there with a similar 
> problem...and let me know if i've destroyed something in the process. 
I'm fine with converting to a php builtin function as long as it behaves 
the same.   According to the php site, strtotime() has been around since 
version 3.  There has to be some reason why magpierss includes it's own 
implementation.

--Kevin