Re: [Fofredux-devel] Hold off on commits

[Kevin <ke...@dr...>]

Katie Bechtold wrote:

>On Sat, Dec 10, 2005 at 01:20:42PM -0700, Kevin wrote:
>  
>
>>Problem:   The feed image handling needs work.  It doesn't work for me 
>>and the way it's implemented just has a bad smell.  I'm of the opinion 
>>we should back that out until after the release.
>>    
>>
>
>When you say the image handling doesn't work for you, is it not
>displying images for feeds that you know have them?  Or are you
>getting some error?
>
>Could you share what you don't like about how it's implemented?
>
>  
>
1) My beef with the way it is implemented basically boils down to this:  
The way the image url is stored in the DB goes against standard 
normalization practices.  The feed image URL is stored as a column in 
the items table.  If the feed has 1000 items,  the identical image URL 
is stored 1000 times in the db, when it really should only be stored 
once. (in the feed table, not the items table)

I think this change should be made before release.  It will be alot 
harder to do afterwards.


2) I have one feed where it shows the broken image icon, when the url is 
correct.  What's strange is, this is the only feed out of 15 which have 
images that I know of.. I don't get what's different with this one 
feed.  I've tried Firefox 1.5, Opera 8, and IE6.  All do the same 
thing:  When I view the feed items, it either shows a broken image icon, 
or nothing at all.

Here's the rss url that is the problem: http://www.fark.com/fark.rss