From: Benjamin S. <bs...@cr...> - 2005-12-02 19:08:39
|
On Fri, Dec 02, 2005 at 01:28:50PM -0500, Katie Bechtold wrote: > Hi! I'm a bit late to the party, but I'm a new developer on > fofredux. I've been a feedonfeeds user for a while, and like many > of you, I was impatient to see some development happen, so I > tinkered with my own installation while awaiting a fork of the > project, which I'm excited to see. I've migrated several bugs and > feature requests from feedonfeeds to fofredux. I'll leave it to Andy or someone else to say a more extended thanks, but the short version is: Awesome, thanks! > One of the "customizations" I hacked on to my installation of > feedonfeeds was to add my own cookies in magpierss's > _fetch_remote_file() function, because I wanted LiveJournal to > recognize me and give me my friends' friends-locked-entry feed items > in addition to the public ones. Oh, good hack -- I had exactly the same problem, and tried using variations on some of the published hacks for passing passwords to feeds, but they don't work for LJ (as discussed somewhere on LJ). On the one hand, though, I think that that patch should end up in magpie. On the other hand, there *has* to be an interface for getting those cookies into your subscriptions, so at least part of it has to be in the magpie clients. I've never looked at magpie's code, and I don't know how you implemetned it, but off the top of my head, there should be an API separation here that should look something like this: Magpie's methods should take cookies for feeds as an optional argument, and then FORF can store and pass those cookies to magpie. > I'd be interested in adding this sort of functionality in a less > kludge-y and more generalized way, but I'm still looking into whether > and how magpierss might support that. Er, right. See above. Magpie probably shouldn't know anything about storage of cookies, and should only take them as another parameter. --Benjy |