Re: [Fofredux-devel] Re: v0.2

[Benjamin S. <bs...@cr...>]

> I like it.  There must be a way to streamline the js code. At least 
> consolidate it into one js file.  Pulling in 10 different files is a bit 
> much.  I didn't notice the problem Andrew had where the shortcuts didn't 
> work with many items.  Although, I only tested on a feed with 135 items.

Okay, so the two quick comments in response to this and what Andy said,
are:

1.  I suspect that that "todo rem" alert that Andy mentioned was because
you tried to use the javascript before the page was finished loading.
This is obviously undesirable, and I had an idea of a way to work around
this.

2.  The javascript is indeed excessive, because it's *all* of refeed's
javascript.  I could strip this down a *lot*, but didn't because I kind
of need to do it on a function by function basis to get rid of things
that for sure aren't used.  Refeed's code, while reusable, was a little
excessively heavy.

And the third thing was yes, other keyboard shortcut stuff will be
implemented.  This was just the basic version that did the basic
navigation features, and I was going to add that other stuff once we
figured out what that other stuff is.

So I can and will invest a bunch of time in cutting that javascript down
/ streamlining it, but for a functional prototype, I can't argue with
basically writing no new code.  I'm very good at getting *rid* of code
and making it more efficient:  I had a net negative codeline
contribution at my previous job.  =)

--Benjy