Re: [Fofredux-devel] Re: v0.2

[Kevin <ke...@dr...>]

Andrew Turner (nilspace) wrote:

>Good start, but a couple of things:
>
>It worked on a page with 2 items, but then on a longer page, a
>notification message comes down:
>
>TODO REM no listed things on this page
>
>Also, pages seemed to be loading rather slowly, I checked out the new
>code and there is now 60K of javascript files that are getting
>included in every page load. This seems kind of hefty and is obviously
>a lot of code for a browser to churn through.
>
>I had thought kbd nav would also include selecting different feeds,
>etc. I tend to use Page Up and Page Down for scrolling through pages.
>I read this page:
>http://www.quirksmode.org/viewport/compatibility.html
>
>Which discusses compliant means for doing scrolling methods. Combined
>with "Access Keys", it's possible to do:
>--
><script type="text/javascript">
>function fr_scroll(inc)
>{
>        var x,y;
>
>        if (self.pageYOffset) // all except Explorer
>        {
>                x = self.pageXOffset;
>                y = self.pageYOffset;
>        }
>        else if (document.documentElement &&
>document.documentElement.scrollTop)        // Explorer 6 Strict
>        {
>                x = document.documentElement.scrollLeft;
>                y = document.documentElement.scrollTop;
>        }
>        else if (document.body) // all other Explorers
>        {
>                x = document.body.scrollLeft;
>                y = document.body.scrollTop;
>        }
>        scrollTo(0,y+inc);
>}
></script>
><a href="javascript:scroll(0,0)" accesskey="h">Top</a>
><a href="javascript:fr_scroll(-200)" accesskey="j">Up</a>
><a href="javascript:fr_scroll(200)" accesskey="k">Down</a>
>--
>
>I think the marking is *very* good idea - though I couldn't test it on
>a large number of feeds. How does it know to jump to the next feed
>item to be read? I guess it can get the X,Y page location of the next
>check-box and then scrollTo(x,y) that location.
>
>In the end, I'm not sure what all the ReFeeds js stuff is including,
>but I think it's too heavy handed for just up/down and marking stuff.
>I think we'll be better served by writing up our own JS code that's
>smaller. The above code does scroll up/down (albeit with ctrl-j,
>ctrl-k) and I would think the mark would be straight-forward?
>
>Andy
>
>  
>
I like it.  There must be a way to streamline the js code. At least 
consolidate it into one js file.  Pulling in 10 different files is a bit 
much.  I didn't notice the problem Andrew had where the shortcuts didn't 
work with many items.  Although, I only tested on a feed with 135 items.