[Fofredux-devel] Re: v0.2

SourceForge Headquarters 225 Broadway Suite 1600 San Diego, CA 92101 +1 (858) 422-6466

Good start, but a couple of things:

It worked on a page with 2 items, but then on a longer page, a
notification message comes down:

TODO REM no listed things on this page

Also, pages seemed to be loading rather slowly, I checked out the new
code and there is now 60K of javascript files that are getting
included in every page load. This seems kind of hefty and is obviously
a lot of code for a browser to churn through.

I had thought kbd nav would also include selecting different feeds,
etc. I tend to use Page Up and Page Down for scrolling through pages.
I read this page:
http://www.quirksmode.org/viewport/compatibility.html

Which discusses compliant means for doing scrolling methods. Combined
with "Access Keys", it's possible to do:
--
<script type=3D"text/javascript">
function fr_scroll(inc)
{
        var x,y;

        if (self.pageYOffset) // all except Explorer
        {
                x =3D self.pageXOffset;
                y =3D self.pageYOffset;
        }
        else if (document.documentElement &&
document.documentElement.scrollTop)        // Explorer 6 Strict
        {
                x =3D document.documentElement.scrollLeft;
                y =3D document.documentElement.scrollTop;
        }
        else if (document.body) // all other Explorers
        {
                x =3D document.body.scrollLeft;
                y =3D document.body.scrollTop;
        }
        scrollTo(0,y+inc);
}
</script>
<a href=3D"javascript:scroll(0,0)" accesskey=3D"h">Top</a>
<a href=3D"javascript:fr_scroll(-200)" accesskey=3D"j">Up</a>
<a href=3D"javascript:fr_scroll(200)" accesskey=3D"k">Down</a>
--

I think the marking is *very* good idea - though I couldn't test it on
a large number of feeds. How does it know to jump to the next feed
item to be read? I guess it can get the X,Y page location of the next
check-box and then scrollTo(x,y) that location.

In the end, I'm not sure what all the ReFeeds js stuff is including,
but I think it's too heavy handed for just up/down and marking stuff.
I think we'll be better served by writing up our own JS code that's
smaller. The above code does scroll up/down (albeit with ctrl-j,
ctrl-k) and I would think the mark would be straight-forward?

Andy

On 11/29/05, Benjamin Stewart <bs...@cr...> wrote:
> So if that code looks good to y'all, I'll see about merging it onto HEAD
> tonight (like, after midnight PST).  If you have other comments /
> suggestions / bugs, let me know?  Otherwise, it's in branch la la land,
> so can just be thrown out if that's what we want.  =3D)
>
> --Benjy
>
> On Tue, Nov 29, 2005 at 05:20:52PM -0800, Benjamin Stewart wrote:
> > Keyboard shortcuts have been checked in on my branch, between these two
> > tags:
> >
> > cvs diff -u -r PRE_INITIAL_KS -r PRE_CR_INITIAL_KS  | less
> >
> > uh, for some reason I'm not seeing my changes in cvsweb yet... that
> > above diff isn't showing the new javascript files I added (which are
> > copied from refeed, with just a few changes you'll be able to see by
> > comparing the initial versions of those files with the second versions)=
.
> >
> > To check out my branch, do this:
> >
> > cvs co -d fofks -r bsii_keyboardshortcuts_dev fofredux
> >
> > it'll check out into fofks/
> >
> > Feel free to comment.
> >
> > Oh, shortcuts and javascript is only on the view page, and j is down, k
> > is up, and m is mark + down.  More shortcuts can be added / discussed,
> > but for now I was just getting the code to you.
> >
> > --Benjy
> >
> > On Tue, Nov 29, 2005 at 03:11:54PM -0500, Andrew Turner wrote:
> > > I would say check in your changes with the version that has
> > > categories, since that's what you have done.
> > >
> > > Andy
> > >
> > >
> > > On 11/29/05, Benjamin Stewart <bs...@cr...> wrote:
> > > > So here's a concern:  currently my keyboard changes were implemente=
d
> > > > against a version that *did* have categories.  Should I target them=
 to a
> > > > version without categories?  I'm not sure I'll have time to do *tha=
t*
> > > > if I'm going to check in this afternoon, and I have plans tonight.
> > > >
> > > > --Benjy
> > > >
> > > > On Tue, Nov 29, 2005 at 12:40:53PM -0700, Kevin wrote:
> > > > >
> > > > > > Definitely - As Kevin pointed out - let's get the Keyboard shor=
tcuts
> > > > > > in, code freeze, test, bug fix and document and do a 0.2 releas=
e. We
> > > > > > can then announce on the the FoF Forums and put up news/etc. on=
 the
> > > > > > FoFRedux SF page.
> > > > > >
> > > > > > I suggest we put up a "demo" version of FoFRedux at
> > > > > > http://fofredux.sf.net with read-only ability for modifying the=
 DB
> > > > > > (perhaps via special code hack for the time being).
> > > > >
> > > > > http://fofredux.sourceforge.net/demo/
> > > > >
> > > > > Andrew, will you take care of getting a SF mysql account?  Us low=
ely
> > > > > developers don't have permission to do so.
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Kevin
> > > > >
> > > > >
> > > > >
> > > > > -------------------------------------------------------
> > > > > This SF.net email is sponsored by: Splunk Inc. Do you grep throug=
h log files
> > > > > for problems?  Stop!  Download the new AJAX search engine that ma=
kes
> > > > > searching your log files as easy as surfing the  web.  DOWNLOAD S=
PLUNK!
> > > > > http://ads.osdn.com/?ad_idv37&alloc_id=16865&op=3Dclick
> > > > > _______________________________________________
> > > > > Fofredux-devel mailing list
> > > > > Fof...@li...
> > > > > https://lists.sourceforge.net/lists/listinfo/fofredux-devel
> > > >
> > > >
> > > > -------------------------------------------------------
> > > > This SF.net email is sponsored by: Splunk Inc. Do you grep through =
log files
> > > > for problems?  Stop!  Download the new AJAX search engine that make=
s
> > > > searching your log files as easy as surfing the  web.  DOWNLOAD SPL=
UNK!
> > > > http://ads.osdn.com/?ad_idv37&alloc_id=16865&opclick
> > > > _______________________________________________
> > > > Fofredux-devel mailing list
> > > > Fof...@li...
> > > > https://lists.sourceforge.net/lists/listinfo/fofredux-devel
> > > >
> > >
> > >
> > > --
> > > Andrew Turner
> > > ajt...@hi...        42.4266N x 83.4931W
> > > http://highearthorbit.com              Northville, Michigan, USA
> > >
> > > Photos - http://flickr.com/photos/ajturner
> > > Travel   - http://highearthorbit.com/projects/location/
>

--
Andrew Turner
ajt...@hi...        42.4266N x 83.4931W
http://highearthorbit.com              Northville, Michigan, USA

Photos - http://flickr.com/photos/ajturner
Travel   - http://highearthorbit.com/projects/location/