Re: [Fofredux-devel] Devs assigned

[Kevin <ke...@dr...>]

Benjamin Stewart wrote:

>Do we have plans for code reviewing going forward?    Like, here's my
>diff, here are comments from someone else, dev responds to comments,
>changes made, and done?  
>
>Here's what I've found works really well when working with branches in
>cvs:
>
>1. once you're ready to submit, make a LIST of your files.
>2. add a tag PRE_CHECKINLABEL to ONLY those files (using your list)
>3. check in 
>4. add a tag PRE_CR_CHECKINLABEL (Code Review) to ONLY those files
>5. make changes as appropriate for the CR and check in again and get CR
>approval
>6. add a tag POST_CHECKINLABEL to ONLY those files
>
>This way, you can double -j when merging those changes around based on
>the tags, and you're not relying on cvs's insane file versions, and the
>pre cr tag allows you to back a change out a lot easier.  And I *think*
>the reason to only tag your specific files is because it makes it easier
>to figure out what files are changed by any given change, though I'm not
>sure that's it -- whatever it was, we had a really good reaosn for that
>policy (and I don't think it was just that some of my fellow engineers
>were idiots and I didn't trust them not to check in all of their global
>changes if they weren't using file lists).
>
>  
>
It looks like a good idea for major enhancements or code 
refactoring.(like tags, for instance)  For those of us with less CVS 
experience, could you give examples of what cvs commands are run at each 
step?

Thanks,
    Kevin