Re: [Fofredux-devel] Devs assigned

[Benjamin S. <bs...@cr...>]

Do we have plans for code reviewing going forward?    Like, here's my
diff, here are comments from someone else, dev responds to comments,
changes made, and done? =20

Here's what I've found works really well when working with branches in
cvs:

1. once you're ready to submit, make a LIST of your files.
2. add a tag PRE_CHECKINLABEL to ONLY those files (using your list)
3. check in=20
4. add a tag PRE_CR_CHECKINLABEL (Code Review) to ONLY those files
5. make changes as appropriate for the CR and check in again and get CR
approval
6. add a tag POST_CHECKINLABEL to ONLY those files

This way, you can double -j when merging those changes around based on
the tags, and you're not relying on cvs's insane file versions, and the
pre cr tag allows you to back a change out a lot easier.  And I *think*
the reason to only tag your specific files is because it makes it easier
to figure out what files are changed by any given change, though I'm not
sure that's it -- whatever it was, we had a really good reaosn for that
policy (and I don't think it was just that some of my fellow engineers
were idiots and I didn't trust them not to check in all of their global
changes if they weren't using file lists).

That said, I highly advocate you ONLY use cvs with a file list if you're
doing operations that add/delete/commit/tag/otherwise write data to the
repository.  It's not worth the mistake of accidentally checking in
something you didn't mean to check in -- everyone's done it.


My plan is to spend a little bit of time over thanksgiving merging my
keyboard shortcuts onto what Andy did, and hopefully have a checkin on a
branch by Monday or Tuesday of next week. =20

In general, though, what I've done will be pretty easy to redo with
whatever changes other people make, so it's not a big deal if that gets
delayed a touch.

For an initial release, I think having *any* keyboard shortcuts without
ajax features is fine;  We can add ajax features later, and I think the
ability to fly through posts is a bigger deal.

-Benjy

On Tue, Nov 22, 2005 at 11:04:13PM -0500, Andrew Turner (nilspace) wrote:
> Hi all,
> I've added Carlos & Kevin to the FoFRedux developers. You will be able
> to check in and out now.
>=20
> I've also assigned your respective tasks. Carlos, can you apply the
> timestamp patch of yours? Also, Kevin, I think you mentioned you could
> add tags?
>=20
> Andy
>=20
> --
> Andrew Turner
> ajt...@hi...        42.4266N x 83.4931W
> http://highearthorbit.com              Northville, Michigan, USA
> idealistic technocrat
>=20
> Photos - http://flickr.com/photos/ajturner
> Travel   - http://highearthorbit.com/projects/location/
>=20
>=20
> -------------------------------------------------------
> This SF.Net email is sponsored by the JBoss Inc.  Get Certified Today
> Register for a JBoss Training Course.  Free Certification Exam
> for All Training Attendees Through End of 2005. For more info visit:
> http://ads.osdn.com/?ad_idv28&alloc_id=16845&op=3Dclick
> _______________________________________________
> Fofredux-devel mailing list
> Fof...@li...
> https://lists.sourceforge.net/lists/listinfo/fofredux-devel