Menu
▾
▴
fofredux-devel
|
From: Andrew T. <ajt...@hi...> - 2005-11-29 20:12:02
|
I would say check in your changes with the version that has categories, since that's what you have done. Andy On 11/29/05, Benjamin Stewart <bs...@cr...> wrote: > So here's a concern: currently my keyboard changes were implemented > against a version that *did* have categories. Should I target them to a > version without categories? I'm not sure I'll have time to do *that* > if I'm going to check in this afternoon, and I have plans tonight. > > --Benjy > > On Tue, Nov 29, 2005 at 12:40:53PM -0700, Kevin wrote: > > > > > Definitely - As Kevin pointed out - let's get the Keyboard shortcuts > > > in, code freeze, test, bug fix and document and do a 0.2 release. We > > > can then announce on the the FoF Forums and put up news/etc. on the > > > FoFRedux SF page. > > > > > > I suggest we put up a "demo" version of FoFRedux at > > > http://fofredux.sf.net with read-only ability for modifying the DB > > > (perhaps via special code hack for the time being). > > > > http://fofredux.sourceforge.net/demo/ > > > > Andrew, will you take care of getting a SF mysql account? Us lowely > > developers don't have permission to do so. > > > > > > > > -- > > Kevin > > > > > > > > ------------------------------------------------------- > > This SF.net email is sponsored by: Splunk Inc. Do you grep through log = files > > for problems? Stop! Download the new AJAX search engine that makes > > searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! > > http://ads.osdn.com/?ad_idv37&alloc_id=16865&op=3Dclick > > _______________________________________________ > > Fofredux-devel mailing list > > Fof...@li... > > https://lists.sourceforge.net/lists/listinfo/fofredux-devel > > > ------------------------------------------------------- > This SF.net email is sponsored by: Splunk Inc. Do you grep through log fi= les > for problems? Stop! Download the new AJAX search engine that makes > searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! > http://ads.osdn.com/?ad_idv37&alloc_id=16865&opclick > _______________________________________________ > Fofredux-devel mailing list > Fof...@li... > https://lists.sourceforge.net/lists/listinfo/fofredux-devel > -- Andrew Turner ajt...@hi... 42.4266N x 83.4931W http://highearthorbit.com Northville, Michigan, USA Photos - http://flickr.com/photos/ajturner Travel - http://highearthorbit.com/projects/location/ |
|
From: Benjamin S. <bs...@cr...> - 2005-11-30 01:20:54
|
Keyboard shortcuts have been checked in on my branch, between these two tags: cvs diff -u -r PRE_INITIAL_KS -r PRE_CR_INITIAL_KS | less uh, for some reason I'm not seeing my changes in cvsweb yet... that above diff isn't showing the new javascript files I added (which are copied from refeed, with just a few changes you'll be able to see by comparing the initial versions of those files with the second versions). To check out my branch, do this: cvs co -d fofks -r bsii_keyboardshortcuts_dev fofredux it'll check out into fofks/ Feel free to comment. Oh, shortcuts and javascript is only on the view page, and j is down, k is up, and m is mark + down. More shortcuts can be added / discussed, but for now I was just getting the code to you. --Benjy On Tue, Nov 29, 2005 at 03:11:54PM -0500, Andrew Turner wrote: > I would say check in your changes with the version that has > categories, since that's what you have done. >=20 > Andy >=20 >=20 > On 11/29/05, Benjamin Stewart <bs...@cr...> wrote: > > So here's a concern: currently my keyboard changes were implemented > > against a version that *did* have categories. Should I target them to a > > version without categories? I'm not sure I'll have time to do *that* > > if I'm going to check in this afternoon, and I have plans tonight. > > > > --Benjy > > > > On Tue, Nov 29, 2005 at 12:40:53PM -0700, Kevin wrote: > > > > > > > Definitely - As Kevin pointed out - let's get the Keyboard shortcuts > > > > in, code freeze, test, bug fix and document and do a 0.2 release. We > > > > can then announce on the the FoF Forums and put up news/etc. on the > > > > FoFRedux SF page. > > > > > > > > I suggest we put up a "demo" version of FoFRedux at > > > > http://fofredux.sf.net with read-only ability for modifying the DB > > > > (perhaps via special code hack for the time being). > > > > > > http://fofredux.sourceforge.net/demo/ > > > > > > Andrew, will you take care of getting a SF mysql account? Us lowely > > > developers don't have permission to do so. > > > > > > > > > > > > -- > > > Kevin > > > > > > > > > > > > ------------------------------------------------------- > > > This SF.net email is sponsored by: Splunk Inc. Do you grep through lo= g files > > > for problems? Stop! Download the new AJAX search engine that makes > > > searching your log files as easy as surfing the web. DOWNLOAD SPLUN= K! > > > http://ads.osdn.com/?ad_idv37&alloc_id=16865&op=3Dclick > > > _______________________________________________ > > > Fofredux-devel mailing list > > > Fof...@li... > > > https://lists.sourceforge.net/lists/listinfo/fofredux-devel > > > > > > ------------------------------------------------------- > > This SF.net email is sponsored by: Splunk Inc. Do you grep through log = files > > for problems? Stop! Download the new AJAX search engine that makes > > searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! > > http://ads.osdn.com/?ad_idv37&alloc_id=16865&opclick > > _______________________________________________ > > Fofredux-devel mailing list > > Fof...@li... > > https://lists.sourceforge.net/lists/listinfo/fofredux-devel > > >=20 >=20 > -- > Andrew Turner > ajt...@hi... 42.4266N x 83.4931W > http://highearthorbit.com Northville, Michigan, USA >=20 > Photos - http://flickr.com/photos/ajturner > Travel - http://highearthorbit.com/projects/location/ |
|
From: Benjamin S. <bs...@cr...> - 2005-11-30 01:41:03
|
So if that code looks good to y'all, I'll see about merging it onto HEAD tonight (like, after midnight PST). If you have other comments / suggestions / bugs, let me know? Otherwise, it's in branch la la land, so can just be thrown out if that's what we want. =3D) --Benjy On Tue, Nov 29, 2005 at 05:20:52PM -0800, Benjamin Stewart wrote: > Keyboard shortcuts have been checked in on my branch, between these two > tags: >=20 > cvs diff -u -r PRE_INITIAL_KS -r PRE_CR_INITIAL_KS | less >=20 > uh, for some reason I'm not seeing my changes in cvsweb yet... that > above diff isn't showing the new javascript files I added (which are > copied from refeed, with just a few changes you'll be able to see by > comparing the initial versions of those files with the second versions). >=20 > To check out my branch, do this: >=20 > cvs co -d fofks -r bsii_keyboardshortcuts_dev fofredux >=20 > it'll check out into fofks/ >=20 > Feel free to comment. >=20 > Oh, shortcuts and javascript is only on the view page, and j is down, k > is up, and m is mark + down. More shortcuts can be added / discussed, > but for now I was just getting the code to you. >=20 > --Benjy >=20 > On Tue, Nov 29, 2005 at 03:11:54PM -0500, Andrew Turner wrote: > > I would say check in your changes with the version that has > > categories, since that's what you have done. > >=20 > > Andy > >=20 > >=20 > > On 11/29/05, Benjamin Stewart <bs...@cr...> wrote: > > > So here's a concern: currently my keyboard changes were implemented > > > against a version that *did* have categories. Should I target them t= o a > > > version without categories? I'm not sure I'll have time to do *that* > > > if I'm going to check in this afternoon, and I have plans tonight. > > > > > > --Benjy > > > > > > On Tue, Nov 29, 2005 at 12:40:53PM -0700, Kevin wrote: > > > > > > > > > Definitely - As Kevin pointed out - let's get the Keyboard shortc= uts > > > > > in, code freeze, test, bug fix and document and do a 0.2 release.= We > > > > > can then announce on the the FoF Forums and put up news/etc. on t= he > > > > > FoFRedux SF page. > > > > > > > > > > I suggest we put up a "demo" version of FoFRedux at > > > > > http://fofredux.sf.net with read-only ability for modifying the DB > > > > > (perhaps via special code hack for the time being). > > > > > > > > http://fofredux.sourceforge.net/demo/ > > > > > > > > Andrew, will you take care of getting a SF mysql account? Us lowely > > > > developers don't have permission to do so. > > > > > > > > > > > > > > > > -- > > > > Kevin > > > > > > > > > > > > > > > > ------------------------------------------------------- > > > > This SF.net email is sponsored by: Splunk Inc. Do you grep through = log files > > > > for problems? Stop! Download the new AJAX search engine that makes > > > > searching your log files as easy as surfing the web. DOWNLOAD SPL= UNK! > > > > http://ads.osdn.com/?ad_idv37&alloc_id=16865&op=3Dclick > > > > _______________________________________________ > > > > Fofredux-devel mailing list > > > > Fof...@li... > > > > https://lists.sourceforge.net/lists/listinfo/fofredux-devel > > > > > > > > > ------------------------------------------------------- > > > This SF.net email is sponsored by: Splunk Inc. Do you grep through lo= g files > > > for problems? Stop! Download the new AJAX search engine that makes > > > searching your log files as easy as surfing the web. DOWNLOAD SPLUN= K! > > > http://ads.osdn.com/?ad_idv37&alloc_id=16865&opclick > > > _______________________________________________ > > > Fofredux-devel mailing list > > > Fof...@li... > > > https://lists.sourceforge.net/lists/listinfo/fofredux-devel > > > > >=20 > >=20 > > -- > > Andrew Turner > > ajt...@hi... 42.4266N x 83.4931W > > http://highearthorbit.com Northville, Michigan, USA > >=20 > > Photos - http://flickr.com/photos/ajturner > > Travel - http://highearthorbit.com/projects/location/ |
|
From: Andrew T. (nilspace) <nil...@us...> - 2005-11-30 02:49:11
|
Good start, but a couple of things: It worked on a page with 2 items, but then on a longer page, a notification message comes down: TODO REM no listed things on this page Also, pages seemed to be loading rather slowly, I checked out the new code and there is now 60K of javascript files that are getting included in every page load. This seems kind of hefty and is obviously a lot of code for a browser to churn through. I had thought kbd nav would also include selecting different feeds, etc. I tend to use Page Up and Page Down for scrolling through pages. I read this page: http://www.quirksmode.org/viewport/compatibility.html Which discusses compliant means for doing scrolling methods. Combined with "Access Keys", it's possible to do: -- <script type=3D"text/javascript"> function fr_scroll(inc) { var x,y; if (self.pageYOffset) // all except Explorer { x =3D self.pageXOffset; y =3D self.pageYOffset; } else if (document.documentElement && document.documentElement.scrollTop) // Explorer 6 Strict { x =3D document.documentElement.scrollLeft; y =3D document.documentElement.scrollTop; } else if (document.body) // all other Explorers { x =3D document.body.scrollLeft; y =3D document.body.scrollTop; } scrollTo(0,y+inc); } </script> <a href=3D"javascript:scroll(0,0)" accesskey=3D"h">Top</a> <a href=3D"javascript:fr_scroll(-200)" accesskey=3D"j">Up</a> <a href=3D"javascript:fr_scroll(200)" accesskey=3D"k">Down</a> -- I think the marking is *very* good idea - though I couldn't test it on a large number of feeds. How does it know to jump to the next feed item to be read? I guess it can get the X,Y page location of the next check-box and then scrollTo(x,y) that location. In the end, I'm not sure what all the ReFeeds js stuff is including, but I think it's too heavy handed for just up/down and marking stuff. I think we'll be better served by writing up our own JS code that's smaller. The above code does scroll up/down (albeit with ctrl-j, ctrl-k) and I would think the mark would be straight-forward? Andy On 11/29/05, Benjamin Stewart <bs...@cr...> wrote: > So if that code looks good to y'all, I'll see about merging it onto HEAD > tonight (like, after midnight PST). If you have other comments / > suggestions / bugs, let me know? Otherwise, it's in branch la la land, > so can just be thrown out if that's what we want. =3D) > > --Benjy > > On Tue, Nov 29, 2005 at 05:20:52PM -0800, Benjamin Stewart wrote: > > Keyboard shortcuts have been checked in on my branch, between these two > > tags: > > > > cvs diff -u -r PRE_INITIAL_KS -r PRE_CR_INITIAL_KS | less > > > > uh, for some reason I'm not seeing my changes in cvsweb yet... that > > above diff isn't showing the new javascript files I added (which are > > copied from refeed, with just a few changes you'll be able to see by > > comparing the initial versions of those files with the second versions)= . > > > > To check out my branch, do this: > > > > cvs co -d fofks -r bsii_keyboardshortcuts_dev fofredux > > > > it'll check out into fofks/ > > > > Feel free to comment. > > > > Oh, shortcuts and javascript is only on the view page, and j is down, k > > is up, and m is mark + down. More shortcuts can be added / discussed, > > but for now I was just getting the code to you. > > > > --Benjy > > > > On Tue, Nov 29, 2005 at 03:11:54PM -0500, Andrew Turner wrote: > > > I would say check in your changes with the version that has > > > categories, since that's what you have done. > > > > > > Andy > > > > > > > > > On 11/29/05, Benjamin Stewart <bs...@cr...> wrote: > > > > So here's a concern: currently my keyboard changes were implemente= d > > > > against a version that *did* have categories. Should I target them= to a > > > > version without categories? I'm not sure I'll have time to do *tha= t* > > > > if I'm going to check in this afternoon, and I have plans tonight. > > > > > > > > --Benjy > > > > > > > > On Tue, Nov 29, 2005 at 12:40:53PM -0700, Kevin wrote: > > > > > > > > > > > Definitely - As Kevin pointed out - let's get the Keyboard shor= tcuts > > > > > > in, code freeze, test, bug fix and document and do a 0.2 releas= e. We > > > > > > can then announce on the the FoF Forums and put up news/etc. on= the > > > > > > FoFRedux SF page. > > > > > > > > > > > > I suggest we put up a "demo" version of FoFRedux at > > > > > > http://fofredux.sf.net with read-only ability for modifying the= DB > > > > > > (perhaps via special code hack for the time being). > > > > > > > > > > http://fofredux.sourceforge.net/demo/ > > > > > > > > > > Andrew, will you take care of getting a SF mysql account? Us low= ely > > > > > developers don't have permission to do so. > > > > > > > > > > > > > > > > > > > > -- > > > > > Kevin > > > > > > > > > > > > > > > > > > > > ------------------------------------------------------- > > > > > This SF.net email is sponsored by: Splunk Inc. Do you grep throug= h log files > > > > > for problems? Stop! Download the new AJAX search engine that ma= kes > > > > > searching your log files as easy as surfing the web. DOWNLOAD S= PLUNK! > > > > > http://ads.osdn.com/?ad_idv37&alloc_id=16865&op=3Dclick > > > > > _______________________________________________ > > > > > Fofredux-devel mailing list > > > > > Fof...@li... > > > > > https://lists.sourceforge.net/lists/listinfo/fofredux-devel > > > > > > > > > > > > ------------------------------------------------------- > > > > This SF.net email is sponsored by: Splunk Inc. Do you grep through = log files > > > > for problems? Stop! Download the new AJAX search engine that make= s > > > > searching your log files as easy as surfing the web. DOWNLOAD SPL= UNK! > > > > http://ads.osdn.com/?ad_idv37&alloc_id=16865&opclick > > > > _______________________________________________ > > > > Fofredux-devel mailing list > > > > Fof...@li... > > > > https://lists.sourceforge.net/lists/listinfo/fofredux-devel > > > > > > > > > > > > > -- > > > Andrew Turner > > > ajt...@hi... 42.4266N x 83.4931W > > > http://highearthorbit.com Northville, Michigan, USA > > > > > > Photos - http://flickr.com/photos/ajturner > > > Travel - http://highearthorbit.com/projects/location/ > -- Andrew Turner ajt...@hi... 42.4266N x 83.4931W http://highearthorbit.com Northville, Michigan, USA Photos - http://flickr.com/photos/ajturner Travel - http://highearthorbit.com/projects/location/ |
|
From: Kevin <ke...@dr...> - 2005-11-30 05:26:48
|
Andrew Turner (nilspace) wrote: >Good start, but a couple of things: > >It worked on a page with 2 items, but then on a longer page, a >notification message comes down: > >TODO REM no listed things on this page > >Also, pages seemed to be loading rather slowly, I checked out the new >code and there is now 60K of javascript files that are getting >included in every page load. This seems kind of hefty and is obviously >a lot of code for a browser to churn through. > >I had thought kbd nav would also include selecting different feeds, >etc. I tend to use Page Up and Page Down for scrolling through pages. >I read this page: >http://www.quirksmode.org/viewport/compatibility.html > >Which discusses compliant means for doing scrolling methods. Combined >with "Access Keys", it's possible to do: >-- ><script type="text/javascript"> >function fr_scroll(inc) >{ > var x,y; > > if (self.pageYOffset) // all except Explorer > { > x = self.pageXOffset; > y = self.pageYOffset; > } > else if (document.documentElement && >document.documentElement.scrollTop) // Explorer 6 Strict > { > x = document.documentElement.scrollLeft; > y = document.documentElement.scrollTop; > } > else if (document.body) // all other Explorers > { > x = document.body.scrollLeft; > y = document.body.scrollTop; > } > scrollTo(0,y+inc); >} ></script> ><a href="javascript:scroll(0,0)" accesskey="h">Top</a> ><a href="javascript:fr_scroll(-200)" accesskey="j">Up</a> ><a href="javascript:fr_scroll(200)" accesskey="k">Down</a> >-- > >I think the marking is *very* good idea - though I couldn't test it on >a large number of feeds. How does it know to jump to the next feed >item to be read? I guess it can get the X,Y page location of the next >check-box and then scrollTo(x,y) that location. > >In the end, I'm not sure what all the ReFeeds js stuff is including, >but I think it's too heavy handed for just up/down and marking stuff. >I think we'll be better served by writing up our own JS code that's >smaller. The above code does scroll up/down (albeit with ctrl-j, >ctrl-k) and I would think the mark would be straight-forward? > >Andy > > > I like it. There must be a way to streamline the js code. At least consolidate it into one js file. Pulling in 10 different files is a bit much. I didn't notice the problem Andrew had where the shortcuts didn't work with many items. Although, I only tested on a feed with 135 items. |
|
From: Benjamin S. <bs...@cr...> - 2005-11-30 09:13:18
|
> I like it. There must be a way to streamline the js code. At least > consolidate it into one js file. Pulling in 10 different files is a bit > much. I didn't notice the problem Andrew had where the shortcuts didn't > work with many items. Although, I only tested on a feed with 135 items. Okay, so the two quick comments in response to this and what Andy said, are: 1. I suspect that that "todo rem" alert that Andy mentioned was because you tried to use the javascript before the page was finished loading. This is obviously undesirable, and I had an idea of a way to work around this. 2. The javascript is indeed excessive, because it's *all* of refeed's javascript. I could strip this down a *lot*, but didn't because I kind of need to do it on a function by function basis to get rid of things that for sure aren't used. Refeed's code, while reusable, was a little excessively heavy. And the third thing was yes, other keyboard shortcut stuff will be implemented. This was just the basic version that did the basic navigation features, and I was going to add that other stuff once we figured out what that other stuff is. So I can and will invest a bunch of time in cutting that javascript down / streamlining it, but for a functional prototype, I can't argue with basically writing no new code. I'm very good at getting *rid* of code and making it more efficient: I had a net negative codeline contribution at my previous job. =) --Benjy |
|
From: Benjamin S. <bs...@cr...> - 2005-12-01 21:25:43
|
> I had thought kbd nav would also include selecting different feeds, > etc. I tend to use Page Up and Page Down for scrolling through pages. Might I suggest space and shift+space for just jumping through pages? shift+space rules. > I read this page: > http://www.quirksmode.org/viewport/compatibility.html quirksmode is pretty super useful. > Which discusses compliant means for doing scrolling methods. Combined > with "Access Keys", it's possible to do: > -- > <script type="text/javascript"> > function fr_scroll(inc) > { > var x,y; .... > } > </script> > <a href="javascript:scroll(0,0)" accesskey="h">Top</a> > <a href="javascript:fr_scroll(-200)" accesskey="j">Up</a> > <a href="javascript:fr_scroll(200)" accesskey="k">Down</a> > -- So uh, that code could probably be adapted pretty easily, since all I need to do is build a list of items on the page and then be able to jump to those items. I'll see about using this code tonight to see how hard it is. I used the refeed code just because it was there and did what I wanted and allowed for a quick proof of concept. > I think the marking is *very* good idea - though I couldn't test it on > a large number of feeds. How does it know to jump to the next feed > item to be read? Oh, it doesn't actually do that. It just jumps to the next item. So I kind of made an oversight here, which has to do with how I read my news: When I read, I read "today's unread items" instead of "today's items." On my personal menu, I added a link to /view.php?what=all&when=today&what=unread -- the what=unread is super useful. On top of that, I have a second hack where I can *ajax* mark something read, which causes it to disappear from the page. Taken together, these two things mean that I never see "read" items when I'm reading, which means I don't have to skip read items. In the current implementation, read items would be visible if I weren't using what=unread, and marked items are visible no matter what. I'll be able to make it so that read items AND mark items get skipped, and 'j' can be "next unread / unmarked" and something else (control-j?) is absolute next item... But implementing the "I only want to see my unread news" by just putting the "today unread" link in the menu would be a nice feature to toss in there. I'll do it in my next commit. > I guess it can get the X,Y page location of the next > check-box and then scrollTo(x,y) that location. I'm not scrolling to the checkbox; I'm scrolling to the top of the div. > In the end, I'm not sure what all the ReFeeds js stuff is including, A lot of crap. =) > but I think it's too heavy handed for just up/down and marking stuff. > I think we'll be better served by writing up our own JS code that's > smaller. The above code does scroll up/down (albeit with ctrl-j, > ctrl-k) and I would think the mark would be straight-forward? As mentioned, I'll follow up on optimizing this tonight. But as implemented, I should be able to change the implementing javascript without changing the HTML at all -- I'll just need to remove the extra javascript includes. --Benjy |
|
From: Andrew T. <ajt...@hi...> - 2005-12-01 21:59:49
|
Very good suggestions. I really like changing the link to "Today's Unread items". And the ajax stuff sounds intriguing, though I imagine you don't actually need Ajax. Or do you actually wait for a server response before removing the div from the DOM? (ba-dim-dim :) This would be very nice - as long as it degrades to non-js browsers. Good ideas on Keyboard as well. My suggestion at this point - let's roll-out v0.2 as is. We'll make a branch for the keyboard stuff and allow adventuresome types to try it out and give us feedback on what scheme they like/use and we can twiddle the branch until it feels solid & useable by many. Once that happens, we can roll it into 0.3+? Andy On 12/1/05, Benjamin Stewart <bs...@cr...> wrote: > > I had thought kbd nav would also include selecting different feeds, > > etc. I tend to use Page Up and Page Down for scrolling through pages. > > Might I suggest space and shift+space for just jumping through pages? > shift+space rules. > > > I read this page: > > http://www.quirksmode.org/viewport/compatibility.html > > quirksmode is pretty super useful. > > > Which discusses compliant means for doing scrolling methods. Combined > > with "Access Keys", it's possible to do: > > -- > > <script type=3D"text/javascript"> > > function fr_scroll(inc) > > { > > var x,y; > .... > > } > > </script> > > <a href=3D"javascript:scroll(0,0)" accesskey=3D"h">Top</a> > > <a href=3D"javascript:fr_scroll(-200)" accesskey=3D"j">Up</a> > > <a href=3D"javascript:fr_scroll(200)" accesskey=3D"k">Down</a> > > -- > > So uh, that code could probably be adapted pretty easily, since all I > need to do is build a list of items on the page and then be able to jump > to those items. > > I'll see about using this code tonight to see how hard it is. I used > the refeed code just because it was there and did what I wanted and > allowed for a quick proof of concept. > > > I think the marking is *very* good idea - though I couldn't test it on > > a large number of feeds. How does it know to jump to the next feed > > item to be read? > > Oh, it doesn't actually do that. It just jumps to the next item. > > So I kind of made an oversight here, which has to do with how I read my > news: > > When I read, I read "today's unread items" instead of "today's items." > On my personal menu, I added a link to > /view.php?what=3Dall&when=3Dtoday&what=3Dunread -- the what=3Dunread is s= uper > useful. On top of that, I have a second hack where I can *ajax* mark > something read, which causes it to disappear from the page. > > Taken together, these two things mean that I never see "read" items when > I'm reading, which means I don't have to skip read items. In the > current implementation, read items would be visible if I weren't using > what=3Dunread, and marked items are visible no matter what. > > I'll be able to make it so that read items AND mark items get skipped, > and 'j' can be "next unread / unmarked" and something else (control-j?) > is absolute next item... But implementing the "I only want to see my > unread news" by just putting the "today unread" link in the menu would > be a nice feature to toss in there. > > I'll do it in my next commit. > > > I guess it can get the X,Y page location of the next > > check-box and then scrollTo(x,y) that location. > > I'm not scrolling to the checkbox; I'm scrolling to the top of the div. > > > In the end, I'm not sure what all the ReFeeds js stuff is including, > > A lot of crap. =3D) > > > but I think it's too heavy handed for just up/down and marking stuff. > > I think we'll be better served by writing up our own JS code that's > > smaller. The above code does scroll up/down (albeit with ctrl-j, > > ctrl-k) and I would think the mark would be straight-forward? > > As mentioned, I'll follow up on optimizing this tonight. But as > implemented, I should be able to change the implementing javascript > without changing the HTML at all -- I'll just need to remove the extra > javascript includes. > > --Benjy > -- Andrew Turner ajt...@hi... 42.4266N x 83.4931W http://highearthorbit.com Northville, Michigan, USA Photos - http://flickr.com/photos/ajturner Travel - http://highearthorbit.com/projects/location/ |
|
From: Kevin <ke...@dr...> - 2005-12-01 22:33:49
|
> Very good suggestions. I really like changing the link to "Today's > Unread items". And the ajax stuff sounds intriguing, though I imagine > you don't actually need Ajax. Or do you actually wait for a server > response before removing the div from the DOM? (ba-dim-dim :) This > would be very nice - as long as it degrades to non-js browsers. I'm playing with xajax on a side project at work. I'm impressed with how easy it is to manipulate the DOM from the server side. So with very little effort we could do exactly what you describe above. An event on the client sends a request to the server marking an item as read, then th= e server sends a response back to the client telling it to hide/remove the item from the page. All without a refresh on view.php. Nice, huh? --=20 Kevin |
|
From: Andrew T. <ajt...@hi...> - 2005-12-01 22:38:41
|
I'm definitely a fan of Ajax in general - I just wrote an article on it for MacTech magazine. My point was just that XML isn't required, esp. in this case - though not necessarily a bad idea. I guess we could return a list of the items that were successfully marked as read in the database. We also don't have to support a server response - remove it from the DOM/view and send the mark read but don't handle any response. On 12/1/05, Kevin <ke...@dr...> wrote: > > > Very good suggestions. I really like changing the link to "Today's > > Unread items". And the ajax stuff sounds intriguing, though I imagine > > you don't actually need Ajax. Or do you actually wait for a server > > response before removing the div from the DOM? (ba-dim-dim :) This > > would be very nice - as long as it degrades to non-js browsers. > > I'm playing with xajax on a side project at work. I'm impressed with how > easy it is to manipulate the DOM from the server side. So with very > little effort we could do exactly what you describe above. An event on > the client sends a request to the server marking an item as read, then th= e > server sends a response back to the client telling it to hide/remove the > item from the page. All without a refresh on view.php. Nice, huh? > > > > -- > Kevin > > > > ------------------------------------------------------- > This SF.net email is sponsored by: Splunk Inc. Do you grep through log fi= les > for problems? Stop! Download the new AJAX search engine that makes > searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! > http://ads.osdn.com/?ad_idv37&alloc_id=16865&opclick > _______________________________________________ > Fofredux-devel mailing list > Fof...@li... > https://lists.sourceforge.net/lists/listinfo/fofredux-devel > -- Andrew Turner ajt...@hi... 42.4266N x 83.4931W http://highearthorbit.com Northville, Michigan, USA Photos - http://flickr.com/photos/ajturner Travel - http://highearthorbit.com/projects/location/ |
|
From: Benjamin S. <bs...@cr...> - 2005-12-01 22:40:47
|
On Thu, Dec 01, 2005 at 03:33:46PM -0700, Kevin wrote: > > Very good suggestions. I really like changing the link to "Today's > > Unread items". And the ajax stuff sounds intriguing, though I imagine > > you don't actually need Ajax. Or do you actually wait for a server > > response before removing the div from the DOM? (ba-dim-dim :) This > > would be very nice - as long as it degrades to non-js browsers. > > I'm playing with xajax on a side project at work. I'm impressed with how > easy it is to manipulate the DOM from the server side. So with very > little effort we could do exactly what you describe above. An event on > the client sends a request to the server marking an item as read, then the > server sends a response back to the client telling it to hide/remove the > item from the page. All without a refresh on view.php. Nice, huh? This is exactly what I already had implemented. Yes, it waited to remove the div until it got a "confirmed that this is marked as read" from the server, but it could instead be done by just building up a list without actually making the remote call (move the "read" articles down to the bottom of the page into a "read" bin or something). I have not used xajax, but here's what I have used: In my on disk hack against old FOF, I used prototype.js, which was poorly documented and I believe originated out of Rails. I would not use this again. For my last work project, I used Sajax, which I liked a lot because it made it really easy to bind ajax functions to specific php/perl/whatever functions on the server, and it generated all the ajax functions for you, and you were able to specify an arbitrary callback function. I especially liked the ability to specify the arbitrary callback function, because it gave me a lot more flexibility to do exactly what I needed to do. And making it degrade is easy, because we could just make the AJAX read functionality be hidden unless javascript is available to enable it. No matter how I do this, I 1. already have at least one version of it implemented, and 2. it's pretty easy. I'll work on it some tonight. --Benjy |
×
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.
Thanks for helping keep SourceForge clean.
X