From: Miles B. <mil...@gm...> - 2006-04-07 16:55:49
|
I marked an item as read in a feed that I had meant to leave alone. So I went into the feed showing all the articles and clicked on the checkbox for the article then tried Mark as Unread. Going back to the Panel mode did not show the article. |
From: Andrew T. (nilspace) <nil...@us...> - 2006-04-07 17:10:50
|
Can you be a little more explicit on what actions you took to get to where? For example: 1) Clicked "Show new items" 2) Clicked on a feed checkbox 3) Clicked "marked flagged items as read" 4) hit the back button on the web browser? 5) click the feed checkbox 6) clicked the "mark flagged items as unread" 7) clicked the "Panel" button 8) Feed line showed no new items Is this what happened, or something different? Andrew On 4/7/06, Miles Beck <mil...@gm...> wrote: > I marked an item as read in a feed that I had meant to leave alone. So > I went into the feed showing all the articles and clicked on the > checkbox for the article then tried Mark as Unread. Going back to the > Panel mode did not show the article. > > > ------------------------------------------------------- > This SF.Net email is sponsored by xPML, a groundbreaking scripting langua= ge > that extends applications into web and mobile media. Attend the live webc= ast > and join the prime developer group breaking into this new coding territor= y! > http://sel.as-us.falkag.net/sel?cmdlnk&kid=110944&bid$1720&dat=121642 > _______________________________________________ > Fofredux-devel mailing list > Fof...@li... > https://lists.sourceforge.net/lists/listinfo/fofredux-devel > -- Andrew Turner ajt...@hi... 42.4266N x 83.4931W http://highearthorbit.com Northville, Michigan, USA |
From: Miles B. <mil...@gm...> - 2006-04-07 17:24:53
|
On 4/7/06, Andrew Turner (nilspace) <nil...@us...> wrote: > Can you be a little more explicit on what actions you took to get to wher= e? 1. From the panel view I clicked on the link (1 new) which is opening "view.php?feed=3D34". 2. Mark the item as read by clicking "Flag all Items" then click "Mark as read", then click on the panel link. 3. Click on the link that has all the articles for that feed "view.php?feed=3D34&what=3Dall". 4. Select the checkbox for the item I marked as read previously and then click the "Mark as Unread" checkbox. 5. Click on the Panel link and I should see the article that I marked as unread but I don't see anything new. It shows (0 new) with no hyperlink active. -Miles |
From: Andrew T. <ajt...@hi...> - 2006-04-07 17:32:51
|
Confirmed - I see this behavior as well, thanks for pointing it out I will look into it Andrew On 4/7/06, Miles Beck <mil...@gm...> wrote: > On 4/7/06, Andrew Turner (nilspace) <nil...@us...> wrot= e: > > Can you be a little more explicit on what actions you took to get to wh= ere? > > 1. From the panel view I clicked on the link (1 new) which is opening > "view.php?feed=3D34". > 2. Mark the item as read by clicking "Flag all Items" then click "Mark > as read", then click on the panel link. > 3. Click on the link that has all the articles for that feed > "view.php?feed=3D34&what=3Dall". > 4. Select the checkbox for the item I marked as read previously and > then click the "Mark as Unread" checkbox. > 5. Click on the Panel link and I should see the article that I marked > as unread but I don't see anything new. It shows (0 new) with no > hyperlink active. > > -Miles > > > ------------------------------------------------------- > This SF.Net email is sponsored by xPML, a groundbreaking scripting langua= ge > that extends applications into web and mobile media. Attend the live webc= ast > and join the prime developer group breaking into this new coding territor= y! > http://sel.as-us.falkag.net/sel?cmdlnk&kid=110944&bid$1720&dat=121642 > _______________________________________________ > Fofredux-devel mailing list > Fof...@li... > https://lists.sourceforge.net/lists/listinfo/fofredux-devel > -- Andrew Turner ajt...@hi... 42.4266N x 83.4931W http://highearthorbit.com Northville, Michigan, USA |
From: Andrew T. (nilspace) <nil...@us...> - 2006-04-07 18:22:45
|
The potential solution has been committed to CVS. It will be released in 0.3 (which is 'imminent' and also 'emminent' ;) Please keep up the great effort testing the Release Candidate. Dev notes: For some reason, even though the item was flagged to "unread" it wasn't then being picked up as unread. I think this was due to ADODB using "0" instead of "NULL" when it set the flag in the MySQL db. Therefore, items flagged as 'unread' will use 0 (thought still via the FOF_UNREAD_FLAG) to address this issue. Andrew On 4/7/06, Andrew Turner <ajt...@hi...> wrote: > Confirmed - I see this behavior as well, thanks for pointing it out I > will look into it > > Andrew > > > On 4/7/06, Miles Beck <mil...@gm...> wrote: > > On 4/7/06, Andrew Turner (nilspace) <nil...@us...> wr= ote: > > > Can you be a little more explicit on what actions you took to get to = where? > > > > 1. From the panel view I clicked on the link (1 new) which is opening > > "view.php?feed=3D34". > > 2. Mark the item as read by clicking "Flag all Items" then click "Mark > > as read", then click on the panel link. > > 3. Click on the link that has all the articles for that feed > > "view.php?feed=3D34&what=3Dall". > > 4. Select the checkbox for the item I marked as read previously and > > then click the "Mark as Unread" checkbox. > > 5. Click on the Panel link and I should see the article that I marked > > as unread but I don't see anything new. It shows (0 new) with no > > hyperlink active. > > > > -Miles > > > > > > ------------------------------------------------------- > > This SF.Net email is sponsored by xPML, a groundbreaking scripting lang= uage > > that extends applications into web and mobile media. Attend the live we= bcast > > and join the prime developer group breaking into this new coding territ= ory! > > http://sel.as-us.falkag.net/sel?cmdlnk&kid=110944&bid$1720&dat=121642 > > _______________________________________________ > > Fofredux-devel mailing list > > Fof...@li... > > https://lists.sourceforge.net/lists/listinfo/fofredux-devel > > > > > -- > Andrew Turner > ajt...@hi... 42.4266N x 83.4931W > http://highearthorbit.com Northville, Michigan, USA > -- Andrew Turner ajt...@hi... 42.4266N x 83.4931W http://highearthorbit.com Northville, Michigan, USA |
From: Kevin <ke...@dr...> - 2006-04-07 18:49:26
|
> The potential solution has been committed to CVS. It will be released > in 0.3 (which is 'imminent' and also 'emminent' ;) Please keep up the > great effort testing the Release Candidate. > > Dev notes: > For some reason, even though the item was flagged to "unread" it > wasn't then being picked up as unread. I think this was due to ADODB > using "0" instead of "NULL" when it set the flag in the MySQL db. > Therefore, items flagged as 'unread' will use 0 (thought still via the > FOF_UNREAD_FLAG) to address this issue. What is the behavior of items in the database with the flag still set to the old value indicating unread (NULL)? --=20 Kevin |
From: Andrew T. (nilspace) <nil...@us...> - 2006-04-07 18:59:32
|
Well, by default, the column values are NULL, so when the "view unread" gets all the NULL, then that's ok. However, the fof_update_item_flag takes FOF_UNREAD_FLAG, which was NULL (I changed it in init.php to 0). With NULL, and the SQL query via ADODB sets the flag to 0 (at least in my testing), which then doesn't have it show up when the get_items() looks for all items with flag =3D NULL. So, ADODB on MySQL appears to set NULL as 0. Andrew On 4/7/06, Kevin <ke...@dr...> wrote: > > > The potential solution has been committed to CVS. It will be released > > in 0.3 (which is 'imminent' and also 'emminent' ;) Please keep up the > > great effort testing the Release Candidate. > > > > Dev notes: > > For some reason, even though the item was flagged to "unread" it > > wasn't then being picked up as unread. I think this was due to ADODB > > using "0" instead of "NULL" when it set the flag in the MySQL db. > > Therefore, items flagged as 'unread' will use 0 (thought still via the > > FOF_UNREAD_FLAG) to address this issue. > > What is the behavior of items in the database with the flag still set to > the old value indicating unread (NULL)? > > > -- > Kevin > > > > ------------------------------------------------------- > This SF.Net email is sponsored by xPML, a groundbreaking scripting langua= ge > that extends applications into web and mobile media. Attend the live webc= ast > and join the prime developer group breaking into this new coding territor= y! > http://sel.as-us.falkag.net/sel?cmdlnk&kid=110944&bid$1720&dat=121642 > _______________________________________________ > Fofredux-devel mailing list > Fof...@li... > https://lists.sourceforge.net/lists/listinfo/fofredux-devel > -- Andrew Turner ajt...@hi... 42.4266N x 83.4931W http://highearthorbit.com Northville, Michigan, USA |
From: Kevin <ke...@dr...> - 2006-04-07 19:49:22
|
> Well, by default, the column values are NULL, so when the "view > unread" gets all the NULL, then that's ok. However, the > fof_update_item_flag takes FOF_UNREAD_FLAG, which was NULL (I changed > it in init.php to 0). > > With NULL, and the SQL query via ADODB sets the flag to 0 (at least in > my testing), which then doesn't have it show up when the get_items() > looks for all items with flag =3D NULL. > > So, ADODB on MySQL appears to set NULL as 0. I believe ADODB is doing the right thing. We defined the FOF_UNREAD_FLAG as the string 'NULL', instead of using a real null data type. ADODB see= s the parameter is a string and escapes and quotes before sending the query to the database. The database sees the string value 'NULL', which is an invalid integer, and defaults to use the integer value 0. If the FOF_UNREAD_FLAG constant was changed so it's value was a real null= , not a string, it should fix the reported problem. That said, I think it's a good design decision to switch the unread indicator from NULL to 0. In SQL, NULL is special case indicating the absense of any value. We are using it to indicate a value of "unread", which is incorrect. --=20 Kevin |
From: Andrew T. <ajt...@hi...> - 2006-04-07 20:23:03
|
Agreed, I've already changed the FOF_UNREAD_FLAG to 0 and changed the get unread to check for Null or 0. What should be done then for the future is to modify the default flag column value should be 0 and remove the check for "is null" in the read column. As I mentioned, my current changes are in CVS and will be in 0.3. Thanks again to Miles for pointing out this bug. Guess no one else has recently tried to "mark as unread" :) Andrew On 4/7/06, Kevin <ke...@dr...> wrote: > > > Well, by default, the column values are NULL, so when the "view > > unread" gets all the NULL, then that's ok. However, the > > fof_update_item_flag takes FOF_UNREAD_FLAG, which was NULL (I changed > > it in init.php to 0). > > > > With NULL, and the SQL query via ADODB sets the flag to 0 (at least in > > my testing), which then doesn't have it show up when the get_items() > > looks for all items with flag =3D NULL. > > > > So, ADODB on MySQL appears to set NULL as 0. > > I believe ADODB is doing the right thing. We defined the FOF_UNREAD_FLAG > as the string 'NULL', instead of using a real null data type. ADODB see= s > the parameter is a string and escapes and quotes before sending the query > to the database. The database sees the string value 'NULL', which is an > invalid integer, and defaults to use the integer value 0. > > If the FOF_UNREAD_FLAG constant was changed so it's value was a real null= , > not a string, it should fix the reported problem. > > That said, I think it's a good design decision to switch the unread > indicator from NULL to 0. In SQL, NULL is special case indicating the > absense of any value. We are using it to indicate a value of "unread", > which is incorrect. > > > -- > Kevin > > -- Andrew Turner ajt...@hi... 42.4266N x 83.4931W http://highearthorbit.com Northville, Michigan, USA |
From: Evan R. <eva...@gm...> - 2006-04-07 21:51:11
|
Hey Guys, a quick thought on flags, while we're on the topic. in fof-r you've change= d the read flag from NULL or 1 to simply 'flag' with 0 or 1 (currently). That's all good and fine, but here comes the hitch. I was contemplating fixing my install, as i'd like to be able to mark items with other flags...but not exclusively. For example, it would be great to flag something "interesting" or "save for later" or whatever, but not lose the read/unread status. But in the end it's ridiculous to tack all these potential statuses on to the items table. Perhaps 1 flag, for user-defined stuff and 1 as is for read/unread. But then such a flag is border-line tag= , but on the item rather than feed... Any thoughts? It's something i can jump on after the 0.3 release perhaps, as it seems nigh, and i'm still quite under the weather. regards, evan On 4/7/06, Andrew Turner <ajt...@hi...> wrote: > > Agreed, I've already changed the FOF_UNREAD_FLAG to 0 and changed the > get unread to check for Null or 0. What should be done then for the > future is to modify the default flag column value should be 0 and > remove the check for "is null" in the read column. > > As I mentioned, my current changes are in CVS and will be in 0.3. > Thanks again to Miles for pointing out this bug. Guess no one else has > recently tried to "mark as unread" :) > > Andrew > > On 4/7/06, Kevin <ke...@dr...> wrote: > > > > > Well, by default, the column values are NULL, so when the "view > > > unread" gets all the NULL, then that's ok. However, the > > > fof_update_item_flag takes FOF_UNREAD_FLAG, which was NULL (I changed > > > it in init.php to 0). > > > > > > With NULL, and the SQL query via ADODB sets the flag to 0 (at least i= n > > > my testing), which then doesn't have it show up when the get_items() > > > looks for all items with flag =3D NULL. > > > > > > So, ADODB on MySQL appears to set NULL as 0. > > > > I believe ADODB is doing the right thing. We defined the > FOF_UNREAD_FLAG > > as the string 'NULL', instead of using a real null data type. ADODB > sees > > the parameter is a string and escapes and quotes before sending the > query > > to the database. The database sees the string value 'NULL', which is a= n > > invalid integer, and defaults to use the integer value 0. > > > > If the FOF_UNREAD_FLAG constant was changed so it's value was a real > null, > > not a string, it should fix the reported problem. > > > > That said, I think it's a good design decision to switch the unread > > indicator from NULL to 0. In SQL, NULL is special case indicating the > > absense of any value. We are using it to indicate a value of "unread", > > which is incorrect. > > > > > > -- > > Kevin > > > > > > > -- > Andrew Turner > ajt...@hi... 42.4266N x 83.4931W > http://highearthorbit.com Northville, Michigan, USA > > > ------------------------------------------------------- > This SF.Net email is sponsored by xPML, a groundbreaking scripting > language > that extends applications into web and mobile media. Attend the live > webcast > and join the prime developer group breaking into this new coding > territory! > http://sel.as-us.falkag.net/sel?cmdlnk&kid=110944&bid$1720&dat=121642 > _______________________________________________ > Fofredux-devel mailing list > Fof...@li... > https://lists.sourceforge.net/lists/listinfo/fofredux-devel > |
From: Kevin <ke...@dr...> - 2006-04-08 15:35:25
|
Evan Roth wrote: > Hey Guys, > > a quick thought on flags, while we're on the topic. in fof-r you've > changed the read flag from NULL or 1 to simply 'flag' with 0 or 1 > (currently). That's all good and fine, but here comes the hitch. I > was contemplating fixing my install, as i'd like to be able to mark > items with other flags...but not exclusively. For example, it would > be great to flag something "interesting" or "save for later" or > whatever, but not lose the read/unread status. But in the end it's > ridiculous to tack all these potential statuses on to the items > table. Perhaps 1 flag, for user-defined stuff and 1 as is for > read/unread. But then such a flag is border-line tag, but on the item > rather than feed... Any thoughts? > It's something i can jump on after the 0.3 release perhaps, as it > seems nigh, and i'm still quite under the weather. > What you describe can be easily be accomplished with tags. Tags are associated with items and it is a many-to-many relationship so you can have as many tags on an item as you want. It does not affect the read/unread status of the item. In fact we bounced around the idea of converting the read/unread/saved flag to be built in tags. > regards, > evan > > > On 4/7/06, * Andrew Turner* <ajt...@hi... > <mailto:ajt...@hi...>> wrote: > > Agreed, I've already changed the FOF_UNREAD_FLAG to 0 and changed the > get unread to check for Null or 0. What should be done then for the > future is to modify the default flag column value should be 0 and > remove the check for "is null" in the read column. > > As I mentioned, my current changes are in CVS and will be in 0.3. > Thanks again to Miles for pointing out this bug. Guess no one else has > recently tried to "mark as unread" :) > > Andrew > > On 4/7/06, Kevin < ke...@dr... <mailto:ke...@dr...>> wrote: > > > > > Well, by default, the column values are NULL, so when the "view > > > unread" gets all the NULL, then that's ok. However, the > > > fof_update_item_flag takes FOF_UNREAD_FLAG, which was NULL (I > changed > > > it in init.php to 0). > > > > > > With NULL, and the SQL query via ADODB sets the flag to 0 (at > least in > > > my testing), which then doesn't have it show up when the > get_items() > > > looks for all items with flag = NULL. > > > > > > So, ADODB on MySQL appears to set NULL as 0. > > > > I believe ADODB is doing the right thing. We defined the > FOF_UNREAD_FLAG > > as the string 'NULL', instead of using a real null data type. > ADODB sees > > the parameter is a string and escapes and quotes before sending > the query > > to the database. The database sees the string value 'NULL', > which is an > > invalid integer, and defaults to use the integer value 0. > > > > If the FOF_UNREAD_FLAG constant was changed so it's value was a > real null, > > not a string, it should fix the reported problem. > > > > That said, I think it's a good design decision to switch the unread > > indicator from NULL to 0. In SQL, NULL is special case > indicating the > > absense of any value. We are using it to indicate a value of > "unread", > > which is incorrect. > > > > > > -- > > Kevin > > > > > > > -- > Andrew Turner > ajt...@hi... > <mailto:ajt...@hi...> 42.4266N x 83.4931W > http://highearthorbit.com > <http://highearthorbit.com> Northville, Michigan, USA > > > ------------------------------------------------------- > This SF.Net email is sponsored by xPML, a groundbreaking scripting > language > that extends applications into web and mobile media. Attend the > live webcast > and join the prime developer group breaking into this new coding > territory! > http://sel.as-us.falkag.net/sel?cmdlnk&kid0944&bid$1720&dat1642 > <http://sel.as-us.falkag.net/sel?cmdlnk&kid%110944&bid$1720&dat%121642> > _______________________________________________ > Fofredux-devel mailing list > Fof...@li... > <mailto:Fof...@li...> > https://lists.sourceforge.net/lists/listinfo/fofredux-devel > > |
From: Andrew T. <ajt...@hi...> - 2006-04-08 20:04:56
|
Correct, tags will be probably be used in v0.4+ as they offer more versatility, etc. Currently, the use has the option to mark: unread, read, saved. There was a request to put in a "Saved" RSS feed, but this will wait until complex searches based on tags, etc. will be implemented in 0.4. Lots of very cool features coming up in 0.4. Just waiting for any little bugs to shake themselves out of 0.3. Also, I don't think Khaled has all of the design finished, does he? Khaled? you awake? :) Andrew |
From: khaled A. A. <bro...@gm...> - 2006-04-08 20:19:13
|
Sorry guys I'm on holiday right now (chilling out my parent's house), but I'll read through these tonight and get back to you guys later on about what's been said. I've been reading the various emails to keep in check wit= h what's going on, but to be honest I'm letting the pros get the coding done and argue about the minutae details (I'd just get in the way as I couldn't code myself out of a paper back). So yeah I'm around just keeping quiet :). On 4/8/06, Andrew Turner <ajt...@hi...> wrote: > > Correct, tags will be probably be used in v0.4+ as they offer more > versatility, etc. > > Currently, the use has the option to mark: unread, read, saved. There > was a request to put in a "Saved" RSS feed, but this will wait until > complex searches based on tags, etc. will be implemented in 0.4. > > Lots of very cool features coming up in 0.4. Just waiting for any > little bugs to shake themselves out of 0.3. Also, I don't think Khaled > has all of the design finished, does he? > > Khaled? you awake? :) > > Andrew > > > ------------------------------------------------------- > This SF.Net email is sponsored by xPML, a groundbreaking scripting > language > that extends applications into web and mobile media. Attend the live > webcast > and join the prime developer group breaking into this new coding > territory! > http://sel.as-us.falkag.net/sel?cmdlnk&kid=110944&bid$1720&dat=121642 > _______________________________________________ > Fofredux-devel mailing list > Fof...@li... > https://lists.sourceforge.net/lists/listinfo/fofredux-devel > |
From: khaled A. A. <bro...@gm...> - 2006-04-09 16:39:17
|
Right just read through the various comments from above. I've not completed the design. There is still: - the full view - the mobile version - a couple of pages in the admin panel section (organise and import feeds) as well. Apart from that I think we're nearly there. I always thought that flagged items would be changed to be seen as read. They're a different beast althogether. They are your 'SAVED' items and as such they're meant to be feed items that contain information that you're going to use again and again (at least that's how I see it all). I could be wrong (and have been on multiple occasions). Have we got a battle plan as to what elements will be integrated into the programme first? The reason I'm saying this is because that way we can all play around with it and see what is necessary or what can be enhanced. I will say that I really would like the login functionality integrated into the whole system first but that's just me :). On 4/8/06, khaled Abou Alfa <bro...@gm...> wrote: > > Sorry guys I'm on holiday right now (chilling out my parent's house), but > I'll read through these tonight and get back to you guys later on about > what's been said. I've been reading the various emails to keep in check w= ith > what's going on, but to be honest I'm letting the pros get the coding don= e > and argue about the minutae details (I'd just get in the way as I couldn'= t > code myself out of a paper back). So yeah I'm around just keeping quiet := ). > > > On 4/8/06, Andrew Turner <ajt...@hi...> wrote: > > > > Correct, tags will be probably be used in v0.4+ as they offer more > > versatility, etc. > > > > Currently, the use has the option to mark: unread, read, saved. There > > was a request to put in a "Saved" RSS feed, but this will wait until > > complex searches based on tags, etc. will be implemented in 0.4. > > > > Lots of very cool features coming up in 0.4. Just waiting for any > > little bugs to shake themselves out of 0.3. Also, I don't think Khaled > > has all of the design finished, does he? > > > > Khaled? you awake? :) > > > > Andrew > > > > > > ------------------------------------------------------- > > This SF.Net email is sponsored by xPML, a groundbreaking scripting > > language > > that extends applications into web and mobile media. Attend the live > > webcast > > and join the prime developer group breaking into this new coding > > territory! > > http://sel.as-us.falkag.net/sel?cmdlnk&kid=110944&bid$1720&dat=121642 > > <http://sel.as-us.falkag.net/sel?cmdlnk&kid%110944&bid$1720&dat%121642> > > _______________________________________________ > > Fofredux-devel mailing list > > Fof...@li... > > https://lists.sourceforge.net/lists/listinfo/fofredux-devel > > > > |