fofredux-devel

[Fofredux-devel] Errors occuring as of the 0519 snapshot and beyond.

[Miles B. <mil...@gm...>]

Is anyone else using php4?

I'd like to see if we can get the errors I am reporting sorted out
before too much work is done on other stuff and this gets left behind.

Currently I cannot use any snapshot past the 19th due to errors I am seeing=
.

When trying to use the 0520 snapshot I see the below error.

Fatal error: Call to a member function on a non-object in
/var/www/fofredux-20060520/lib/model/feed.php on line 441

Then when I turn on debugging I see this before the links box.

(mysql): SELECT name, value FROM fr_config
Error (0):

Warning: Cannot modify header information - headers already sent by
(output started at
/var/www/fofredux-20060520/adodb_lite/adodb.inc.php:307) in
/var/www/fofredux-20060520/header.php on line 83

And then this after the search field.

(mysql): SELECT feed.id, feed.url, feed.title, feed.link,
feed.category_id, feed.latitude, feed.longitude, feed.update_enabled,
feed.auto_tag, feed.last_update FROM fr_feeds feed WHERE 1 =3D 1 ORDER
BY title ASC
Error (0):

(mysql): SELECT * FROM fr_categories WHERE id =3D '1'
Error (0):

Fatal error: Call to a member function on a non-object in
/var/www/fofredux-20060520/lib/model/feed.php on line 441

Evan said he was unable to duplicate the issue I was having with the
Options page. Could someone else try this and see if it breaks for
them?

If I use the following links, "view new items", "view all items,
paged", "view today's items" and "view saved items". I am then able to
see articles but between every article are errors like this:

(mysql): SELECT id, name FROM fr_tags ORDER BY name
Error (0):

(mysql): SELECT tag_id FROM fr_x_tag_item WHERE item_id =3D '42136'
Error (0):

and

(mysql): SELECT tag_id FROM fr_x_tag_item WHERE item_id =3D '42162'
Error (0):

and

(mysql): SELECT tag_id FROM fr_x_tag_item WHERE item_id =3D '42025'
Error (0):

This continues for every article displayed.

Do a backup of your database first, because if you are able to
duplicate the problem with the Options page you may not be able to use
the database again. At least I was not able to use it again and
restored from a backup.

Thanks for all your help and work on the project.

-Miles

Re: [Fofredux-devel] Errors occuring as of the 0519 snapshot and beyond.

[Andrew T. <ajt...@hi...>]

Along these lines - what happened to using the testing framework Kevin
put in place around v0.2? We should make sure whenever a function is
added that appropriate tests are added, and run on a regular basis
(nightly, bi-nightly, and/or with checkins)

Andrew

On 5/21/06, Miles Beck <mil...@gm...> wrote:
> Is anyone else using php4?
>
> I'd like to see if we can get the errors I am reporting sorted out
> before too much work is done on other stuff and this gets left behind.
>
> Currently I cannot use any snapshot past the 19th due to errors I am seei=
ng.
>
> When trying to use the 0520 snapshot I see the below error.
>
> Fatal error: Call to a member function on a non-object in
> /var/www/fofredux-20060520/lib/model/feed.php on line 441
>
> Then when I turn on debugging I see this before the links box.
>
> (mysql): SELECT name, value FROM fr_config
> Error (0):
>
> Warning: Cannot modify header information - headers already sent by
> (output started at
> /var/www/fofredux-20060520/adodb_lite/adodb.inc.php:307) in
> /var/www/fofredux-20060520/header.php on line 83
>
> And then this after the search field.
>
> (mysql): SELECT feed.id, feed.url, feed.title, feed.link,
> feed.category_id, feed.latitude, feed.longitude, feed.update_enabled,
> feed.auto_tag, feed.last_update FROM fr_feeds feed WHERE 1 =3D 1 ORDER
> BY title ASC
> Error (0):
>
> (mysql): SELECT * FROM fr_categories WHERE id =3D '1'
> Error (0):
>
> Fatal error: Call to a member function on a non-object in
> /var/www/fofredux-20060520/lib/model/feed.php on line 441
>
> Evan said he was unable to duplicate the issue I was having with the
> Options page. Could someone else try this and see if it breaks for
> them?
>
> If I use the following links, "view new items", "view all items,
> paged", "view today's items" and "view saved items". I am then able to
> see articles but between every article are errors like this:
>
> (mysql): SELECT id, name FROM fr_tags ORDER BY name
> Error (0):
>
> (mysql): SELECT tag_id FROM fr_x_tag_item WHERE item_id =3D '42136'
> Error (0):
>
> and
>
> (mysql): SELECT tag_id FROM fr_x_tag_item WHERE item_id =3D '42162'
> Error (0):
>
> and
>
> (mysql): SELECT tag_id FROM fr_x_tag_item WHERE item_id =3D '42025'
> Error (0):
>
> This continues for every article displayed.
>
> Do a backup of your database first, because if you are able to
> duplicate the problem with the Options page you may not be able to use
> the database again. At least I was not able to use it again and
> restored from a backup.
>
> Thanks for all your help and work on the project.
>
> -Miles
>
>
> -------------------------------------------------------
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job ea=
sier
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronim=
o
> http://sel.as-us.falkag.net/sel?cmdlnk&kid=120709&bid&3057&dat=121642
> _______________________________________________
> Fofredux-devel mailing list
> Fof...@li...
> https://lists.sourceforge.net/lists/listinfo/fofredux-devel
>


--=20
Andrew Turner
ajt...@hi...        42.4266N x 83.4931W
http://highearthorbit.com              Northville, Michigan, USA

Re: [Fofredux-devel] Errors occuring as of the 0519 snapshot and beyond.

[Evan R. <eva...@gm...>]

Miles, keep in mind error(0) is essentially no error, and when you have
debugging of sql enabled, it will spill it all out, even when valid.  what
you are seeing for the tags (Sql on every item) is normal, as it's grabbing
all tags for an item upon displaying it.

the warning with the header.php should probably be fixed but it's not going
to break anything.  my first guess is that we sent a page header before
enabling gzip or vice versa.

the error that is stopping you is obviously Fatal error: Call to a member
function on a non-object in
/var/www/fofredux-20060520/lib/model/feed.php on line 441

For Kev, so you don't need to do any searching...the function that is
blowing up is:
   function getDescription()
   {
      $rss =3D& FOF_ModelFactory::getRssModel();
      $rss_feed =3D& $rss->getRssFeed($this->getUrl());
      return $rss_feed->getDescription();
   }
it seems to only be in php4, since i have not had probs yet in php5.
perhaps you recognize the problem quickly...on the return line.
my naive guess is that the object $rss_feed is not being correctly initiate=
d
with $rss->getRssFeed, perhaps since the URL is non-existant or invalid.

Miles, can you give me the URL to the feed that you are trying to
view/update when you got this error?
Kev, shall we add some better error handling there, so that if the object i=
s
not created, we return a description of a Null-string?  or is there really
no reason that the object is not valid?

/evan




On 5/21/06, Andrew Turner <ajt...@hi...> wrote:
>
> Along these lines - what happened to using the testing framework Kevin
> put in place around v0.2? We should make sure whenever a function is
> added that appropriate tests are added, and run on a regular basis
> (nightly, bi-nightly, and/or with checkins)
>
> Andrew
>
> On 5/21/06, Miles Beck <mil...@gm...> wrote:
> > Is anyone else using php4?
> >
> > I'd like to see if we can get the errors I am reporting sorted out
> > before too much work is done on other stuff and this gets left behind.
> >
> > Currently I cannot use any snapshot past the 19th due to errors I am
> seeing.
> >
> > When trying to use the 0520 snapshot I see the below error.
> >
> > Fatal error: Call to a member function on a non-object in
> > /var/www/fofredux-20060520/lib/model/feed.php on line 441
> >
> > Then when I turn on debugging I see this before the links box.
> >
> > (mysql): SELECT name, value FROM fr_config
> > Error (0):
> >
> > Warning: Cannot modify header information - headers already sent by
> > (output started at
> > /var/www/fofredux-20060520/adodb_lite/adodb.inc.php:307) in
> > /var/www/fofredux-20060520/header.php on line 83
> >
> > And then this after the search field.
> >
> > (mysql): SELECT feed.id, feed.url, feed.title, feed.link,
> > feed.category_id, feed.latitude, feed.longitude, feed.update_enabled,
> > feed.auto_tag, feed.last_update FROM fr_feeds feed WHERE 1 =3D 1 ORDER
> > BY title ASC
> > Error (0):
> >
> > (mysql): SELECT * FROM fr_categories WHERE id =3D '1'
> > Error (0):
> >
> > Fatal error: Call to a member function on a non-object in
> > /var/www/fofredux-20060520/lib/model/feed.php on line 441
> >
> > Evan said he was unable to duplicate the issue I was having with the
> > Options page. Could someone else try this and see if it breaks for
> > them?
> >
> > If I use the following links, "view new items", "view all items,
> > paged", "view today's items" and "view saved items". I am then able to
> > see articles but between every article are errors like this:
> >
> > (mysql): SELECT id, name FROM fr_tags ORDER BY name
> > Error (0):
> >
> > (mysql): SELECT tag_id FROM fr_x_tag_item WHERE item_id =3D '42136'
> > Error (0):
> >
> > and
> >
> > (mysql): SELECT tag_id FROM fr_x_tag_item WHERE item_id =3D '42162'
> > Error (0):
> >
> > and
> >
> > (mysql): SELECT tag_id FROM fr_x_tag_item WHERE item_id =3D '42025'
> > Error (0):
> >
> > This continues for every article displayed.
> >
> > Do a backup of your database first, because if you are able to
> > duplicate the problem with the Options page you may not be able to use
> > the database again. At least I was not able to use it again and
> > restored from a backup.
> >
> > Thanks for all your help and work on the project.
> >
> > -Miles
> >
> >
> > -------------------------------------------------------
> > Using Tomcat but need to do more? Need to support web services,
> security?
> > Get stuff done quickly with pre-integrated technology to make your job
> easier
> > Download IBM WebSphere Application Server v.1.0.1 based on Apache
> Geronimo
> > http://sel.as-us.falkag.net/sel?cmdlnk&kid=120709&bid&3057&dat=121642
> > _______________________________________________
> > Fofredux-devel mailing list
> > Fof...@li...
> > https://lists.sourceforge.net/lists/listinfo/fofredux-devel
> >
>
>
> --
> Andrew Turner
> ajt...@hi...        42.4266N x 83.4931W
> http://highearthorbit.com              Northville, Michigan, USA
>
>
> -------------------------------------------------------
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job
> easier
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronim=
o
> http://sel.as-us.falkag.net/sel?cmdlnk&kid=120709&bid&3057&dat=121642
> _______________________________________________
> Fofredux-devel mailing list
> Fof...@li...
> https://lists.sourceforge.net/lists/listinfo/fofredux-devel
>

Re: [Fofredux-devel] Errors occuring as of the 0519 snapshot and beyond.

[Miles B. <mil...@gm...>]

On 5/21/06, Evan Roth <eva...@gm...> wrote:
> Miles, can you give me the URL to the feed that you are trying to
> view/update when you got this error?

The 441 error occurs when trying to go to the login page in the panel
view http://65.39.84.166/fofredux-20060520/

and the frames view at:

http://65.39.84.166/fofredux-20060520/index.php?view=3Dframes.

It's not tied to a specific feed.

-Miles

Re: [Fofredux-devel] Errors occuring as of the 0519 snapshot and beyond.

[Kevin <ke...@dr...>]

Evan Roth wrote:
> Kev, shall we add some better error handling there, so that if the 
> object is not created, we return a description of a Null-string?  or 
> is there really no reason that the object is not valid?
If the feed is not cached by magpierss, then FOF_RssModel::getRssFeed() 
will return false.   So, that is possible and should be checked for.  I 
have updated lib/model/feed.php.  So, the next snapshot should work a 
little better.

-Kevin

Re: [Fofredux-devel] Errors occuring as of the 0519 snapshot and beyond.

[Kevin <ke...@dr...>]

Andrew Turner wrote:
> Along these lines - what happened to using the testing framework Kevin
> put in place around v0.2? We should make sure whenever a function is
> added that appropriate tests are added, and run on a regular basis
> (nightly, bi-nightly, and/or with checkins)
>
That was the idea.  I've started a test case for item search.  I've run 
all the test cases recently and they still all pass.  The problem is we 
only have about 5-10% test coverage.  Perhaps this should be a formal 
feature/support request to write test cases for the rest of the code?

The test cases are easy to run once simple test is installed.  Should we 
bundle simpletest to make this easier for users/devs?

-Kevin

Re: [Fofredux-devel] Errors occuring as of the 0519 snapshot and beyond.

[Miles B. <mil...@gm...>]

On 5/21/06, Kevin <ke...@dr...> wrote:
> That was the idea.  I've started a test case for item search.  I've run
> all the test cases recently and they still all pass.  The problem is we
> only have about 5-10% test coverage.  Perhaps this should be a formal
> feature/support request to write test cases for the rest of the code?
>
> The test cases are easy to run once simple test is installed.  Should we
> bundle simpletest to make this easier for users/devs?
>
> -Kevin

Would it be a lot of work to bundle it for the development snapshots
and then remove it for a release?

I'd certainly run it on each snapshot and report any results if it was bund=
led.

-Miles

Re: [Fofredux-devel] Errors occuring as of the 0519 snapshot and beyond.

[Kevin <ke...@dr...>]

Miles Beck wrote:
> On 5/21/06, Kevin <ke...@dr...> wrote:
>> That was the idea.  I've started a test case for item search.  I've run
>> all the test cases recently and they still all pass.  The problem is we
>> only have about 5-10% test coverage.  Perhaps this should be a formal
>> feature/support request to write test cases for the rest of the code?
>>
>> The test cases are easy to run once simple test is installed.  Should we
>> bundle simpletest to make this easier for users/devs?
>>
>> -Kevin
>
> Would it be a lot of work to bundle it for the development snapshots
> and then remove it for a release?
>
> I'd certainly run it on each snapshot and report any results if it was 
> bundled.
>
Not much work to bundle it.  We already maintain 3-4 third party 
software packages already.  It would just add an extra step to exclude 
it when packaging a release.

-Kevin

Re: [Fofredux-devel] Errors occuring as of the 0519 snapshot and beyond.

[Andrew T. <ajt...@hi...>]

Yes, let's add simpletest to the vendor directory. I'll put in a
"formal"... umm.. I guess feature request - since it's not just an
answer or small bug fix, but major additions to some chunk of code.

Thanks!
Andrew

On 5/22/06, Kevin <ke...@dr...> wrote:
> Miles Beck wrote:
> > On 5/21/06, Kevin <ke...@dr...> wrote:
> >> That was the idea.  I've started a test case for item search.  I've ru=
n
> >> all the test cases recently and they still all pass.  The problem is w=
e
> >> only have about 5-10% test coverage.  Perhaps this should be a formal
> >> feature/support request to write test cases for the rest of the code?
> >>
> >> The test cases are easy to run once simple test is installed.  Should =
we
> >> bundle simpletest to make this easier for users/devs?
> >>
> >> -Kevin
> >
> > Would it be a lot of work to bundle it for the development snapshots
> > and then remove it for a release?
> >
> > I'd certainly run it on each snapshot and report any results if it was
> > bundled.
> >
> Not much work to bundle it.  We already maintain 3-4 third party
> software packages already.  It would just add an extra step to exclude
> it when packaging a release.
>
> -Kevin
>
>
> -------------------------------------------------------
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job ea=
sier
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronim=
o
> http://sel.as-us.falkag.net/sel?cmd=3Dlnk&kid=3D120709&bid=3D263057&dat=
=3D121642
> _______________________________________________
> Fofredux-devel mailing list
> Fof...@li...
> https://lists.sourceforge.net/lists/listinfo/fofredux-devel
>


--=20
Andrew Turner
ajt...@hi...        42.4266N x 83.4931W
http://highearthorbit.com              Northville, Michigan, USA

Re: [Fofredux-devel] Errors occuring as of the 0519 snapshot and beyond.

[Evan R. <eva...@gm...>]

Miles,  i see that kev has made a few validity checks before executing the
fatal code.  can you give some feedback as to whether or not you are still
getting the error with the latest snapshot?  code revision of
lib/model/feed.php is 424

/evan

On 5/22/06, Kevin <ke...@dr...> wrote:
>
> Miles Beck wrote:
> > On 5/21/06, Kevin <ke...@dr...> wrote:
> >> That was the idea.  I've started a test case for item search.  I've ru=
n
> >> all the test cases recently and they still all pass.  The problem is w=
e
> >> only have about 5-10% test coverage.  Perhaps this should be a formal
> >> feature/support request to write test cases for the rest of the code?
> >>
> >> The test cases are easy to run once simple test is installed.  Should
> we
> >> bundle simpletest to make this easier for users/devs?
> >>
> >> -Kevin
> >
> > Would it be a lot of work to bundle it for the development snapshots
> > and then remove it for a release?
> >
> > I'd certainly run it on each snapshot and report any results if it was
> > bundled.
> >
> Not much work to bundle it.  We already maintain 3-4 third party
> software packages already.  It would just add an extra step to exclude
> it when packaging a release.
>
> -Kevin
>
>
> -------------------------------------------------------
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job
> easier
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronim=
o
> http://sel.as-us.falkag.net/sel?cmd=3Dlnk&kid=3D120709&bid=3D263057&dat=
=3D121642
> _______________________________________________
> Fofredux-devel mailing list
> Fof...@li...
> https://lists.sourceforge.net/lists/listinfo/fofredux-devel
>

Re: [Fofredux-devel] Errors occuring as of the 0519 snapshot and beyond.

[Miles B. <mil...@gm...>]

On 5/22/06, Evan Roth <eva...@gm...> wrote:
> Miles,  i see that kev has made a few validity checks before executing th=
e
> fatal code.  can you give some feedback as to whether or not you are stil=
l
> getting the error with the latest snapshot?  code revision of
> lib/model/feed.php is 424
>
> /evan

WOO HOO!!!

The options problem and the fatal error do not occur anymore in
today's snapshot.

Great work!

-Miles