Menu

foam-extend-4.1 Merge Request #40: Bugfix solutionControl: initialize faceU.oldTime() from U.oldTime() (open)

Merging...

Merged

Something went wrong. Please, merge manually

Checking if merge is possible...

Something went wrong. Please, merge manually

Sergey Lesnik wants to merge 1 commit from /u/slesnik/foam-extend-sl/ to nextRelease, 2021-03-19

This one is again about faceU.oldTime() used by time discretization schemes such as Euler in EulerDdtScheme<type>::fvcDdtConsistentPhiCorr(…). faceU.oldTime() is not set on initialization in solutionControl::calcTransientConsistentFlux(…). This matters on a restart or if a solution is present at 0.</type>

Steps to fix:
1. apply the patch
2. wmake libso $FOAM_SRC/finiteVolume
3. You may observe smaller initial residual of the pressure field if you run the test case (https://sourceforge.net/u/slesnik/icoDLBFoam/ci/master/tree/) starting at e.g. 0.05 comparing to the same run without the patch (you might wand to switch off the output of phi in controlDict: printPhi).

Commit Date  
[d6e8e9] (bugfixSolutionControl) by Sergey Lesnik Sergey Lesnik

Bugfix solutionControl: initialize faceU.oldTime() from U.oldTime()

2021-03-18 14:58:51 Tree

Discussion


Log in to post a comment.