FMSLogo Code

Add a comment

Undo the part of the fix for Bug #589 that removed the special handling of - from runparse_node.
This was necessary to make "SUM 1 -1" run; without it, it's "SUM (DIFFERENCE 1 1)" and is missing an input.

Add tests that when RUNPARSE is invoked on the output of RUNPARSE, the second invocation outputs its input.
I don't know if the system depends on this, but it's how RUNPARSE behaves.

Add some additional test coverage for RUNPARSE.

Fix Bug #589; The operator precedence of a negation operator no longer spread to its right.
For example, "2 *-1 + 100" now evaluates to 98, not 194.

The core of the bug is that the parenthesizer rewrote "-X" as "0 - X", which would then
be parsed as normal, with any following infix operators being applied. So the expression
"2 *-1 + 100" would be parenthesized as (2 * (0 - 1 + 100)) instead of ((2 * -1) + 100).

Fixing this required more changes than I had hoped for. In the end, I found the "0 - X"
rewrite to be inherently faulty. A special case is still necessary because "-" is, by default,
classified as an infix operator and the rest of the code assumes that infix operators are
infix and have a higher binding priority than normal procedures.

The new logic has two special cases for this rewrite, same as the old logic. However, the
new code localizes both to paren.cpp instead of implementing the same idea in both the
runparser and the parenthesizer. It's cleaner to put this in paren.cpp because the runparser
treats the word as a list of tokens and it's not possible to know when "-" is infix or prefix
without a parse tree.

Remove dib.o from the Makefile to fix a build break.
src/dib.cpp was removed in r5956.

Add some test coverage for Bug #589

Rework some logic in paren_infix to avoid a redundant assignment.
This was done primarily for clarity; I didn't like that right_arg included left_arg, even if temporarily.

Remove a special case of Minus_Tight from priority().
This does not need to be a special case, since it calcluated the same by the common case.
The priority is already specified in the prims table and specifying it redundantly in priority() violates the DRY principal.

Add/correct some comments in paren_infix