FMSLogo Code

Fix a bug where the definitions from the minieditor would sometimes be replaced with garbage characters or possibly crash.

The bug has always exited, but the symptoms of the bug were brought about by the update to wxWidgets 3.1.0, which changed the implementation of wxString enough so the prodedure body that was read from the mini-editor would be freed before its buffer was copied into the reader. The fix is to hold a reference to the wxString while its internal buffer is being used.

Enable wxStatusBar so that menu items can be disabled.

This is a regression introduced after rewriting the configure script to start by enabling features used instead of disabling ones that weren't used. Since FMSLogo does not use wxStatusBar, it made sense not to enable it. However, as described in bug #423, there's a quirk of wxWidgets where it requires the status bar to send "update UI events" that are used to disable menu items.

Rework the registration code for the Scintilla lexer module to be automatic, instead of having a programmatic interface.

While I prefer having explicit contracts, it's clear that the registration code will be different on platforms like GNU/Linux distros where I don't compile the wxWidgets library and cannot invoke its private internal functions. For these platforms, a completely different strategy will be required to register the lexer. Until that strategy is implemented, I will need to remove the lexer code completely so that the executable can at least be linked. Removing the programmatic contract for registration makes it easier to remove the lexer.

Note that bug #212 has been fixed, which is that the commander history is not sluggish when the cursor is moved over a very long line.

This bug was really in the OWL version and probably never existed in the wxWidgets version, but bug #401 prevent me from confirming this, since the very long lines were not visible until wxWidgets was upgraded to 3.1.0.

Note that bug #401 has been fixed. This was fixed by upgrading from wxWidgets 2.8.14 to 3.1.0.

Remove the ISWX test function. This was added so that the tests could run correctly on both the Borland OWL and the wxWidgets versions. Since the Borland OWL version has been deleted, ISWX now always returns "True and so is not needed. Removing it simplifies the test code.

Remove wxSizer flags that were ignored.

The debug build of wxWidgets-3.1.0 provides helpful asserts when you use their API incorrectly. Among these are providing sizer flags that are ignored, such as providing alignment with wxEXPAND, or horizontal alignment on horizontal box sizer. This revision removes all flags that were ignored, making the code simpler and more correct.

Fix a problem where the WINDOWSET tests would fail during the full test pass. They have always failed on the wxWidgets version because the MINIMIZE/MAXIMIZE/RESTORE tests would revive an editor window that was supposedely closed. This is an result of an intentional design descision of wxWidgets, when a window is destroyed, it is not destroyed immediately, it is destroyed when the application is idle. Since the application is not idle what the tests are running, if the EDITOR tests are run before the WINDOWSET tests, there would be a window named "Editor" that would conflict with the window that it created for testing.

Since this temporary window leaking doesn't have a user-facing impact, my fix was to move the WINDOWSET tests before the EDITOR tests, thereby avoiding the problem.

Set LDFLAGS that statically link to the C runtime so that the wxWidget sample applications can be run without having to change the PATH to include the C runtime DLLs.

Fix a build bug where the debug heap was being compiled into retails builds of FMSLogo. It looks like this is not a recent regression and may have been included in all released versions of the wxWidgets FMSLogo. The impact of this is minor, as it only changes the behavior of new and delete, and FMSLogo relied more on malloc and free.