PORTWRITEARRAY error messsage incorrectly refers to first input
A Logo programming environment for Microsoft Windows
Brought to you by:
david_costanzo
PORTWRITEARRAY accepts an array as it second input, which is the data to write to the open port. If the second input is not an array, it shows a message box which says that the first input must be an array. However, the first input must be a number, so this error message is misleading.
This is reproducible in MSWLogo 6.5b and FMSLogo 7.2.0.
Steps to Reproduce:
PORTWRITEARRAY 10 "not-an-array
What Happens:
You see a message box that says "first input must be an array"
Expected Result:
The error message says "second input must be an array"
I have committed [r4564] as a fix. The fix will be available in FMSLogo 7.3.0.
I had planned on updating the text of the dialog box, but I wouldn't have been able to fix the Russian or Greek translations, for which I cannot recognize the script. Instead, I decided to remove the message completely and throw a recoverable "doesn't like input" error.
This simplifies the code, makes translating FMSLogo slightly easier (one fewer message to translate), provides a better experience for the programmer (the error dialog boxes are a misfeature), and reduces the work for a tester running through the regression tests (a few fewer dialog boxes to dismiss on).
Related
Commit: [r4564]