#492 File>Open... and File>New lose definitions from startup.logoscript

[entuland]

I am running FMSLogo version 7.1.0, italian version.

Whenever I select "New" or "Open..." from the "File" menu I lose all the COPYDEFs that appear in startup.logoscript, for example:

1. launch FMSLogo
2. issue command "MOSTRA PENNA" ("SHOW PEN")
3. FMSLogo correctly prints "[pendown disegna [1 1] [0 0 0] [1]]"
4. select "File > Nuovo" from the menu
5. issue command "MOSTRA PENNA"
6. FMSLogo prints "Non so come fare PENNA" ("I don't know how to do PENNA")

The expected behavior is for "File > New" to leave FMSLogo in the same state as if it had just been opened, the same stands for "File > Open..." menu item, I would expect it to prepare FMSLogo as if it had just been opened and then load the selected file.

I've tested it on the Spanish version too (1034) and for some strange reason only part of the contents of startup-1034.logoscript get lost (the "#" procedure still works, whereas "copiaraton", "dibujalento" and so forth stop working)

I ignore the implementation details but I think that reloading startup.logoscript right after deleting the workspace in response to "File > New" and "File > Open..." should be enough to fix all of this for all the languages.

[David Costanzo]

I have tracked this back to a regression caused by the fix for [#146] made for FMSLogo 6.27.0 in [r3054]. There is no impact for the English FMSLogo, but the impact is as bad as you describe for all translated FMSLogo versions. Everything that's not a COPYDEF of a primitive gets erased with no obvious way to repopulate it. (The Spanish "#" procedure appears to work because there's also an English # in logolib.)

I'm a bit surprised with something so catastrophically wrong, no one complained earlier. Maybe it's hard for people who need a non-English FMSLogo to open bugs on an English site.

[David Costanzo]

I have implemented the fix for this. It will be released in FMSLogo 7.2.0.

My first attempt at the fix was in [r4404], which loaded startup.logoscript after erasing the contents of the workspace, as recommended in the bug description.

Then I fixed a slight regression with [r4405] where File -> New could load procedures into the workspace if current working directory contained a file that had the same name as a library routine.

[entuland]

Very good, I've updated my local repo and tested it, works fine now.

Just so you know, I've asked about the start of the italian training courses: it should be around September the 15th 2017, it would be great if you find the time to release FMSLogo 7.2.0 for that date.

[David Costanzo]

I've asked about the start of the italian training courses: it should be around September the 15th 2017, it would be great if you find the time to release FMSLogo 7.2.0 for that date.

In case you're not subscribed to the release notifications, I released 7.2.0 yesterday, about a month before strictly needed. If you find additional/new problems that negatively impact your training courses, there still might be enough time to get them fixed.

[entuland]

Hey there David, this is great news! Sorry for the very late reply.

My tests so far are all fine, thanks a lot for the time you took to release it!

Cheers