FMSLogo / Bugs / #241 CLOSE READER does not reset reader to []

#241 CLOSE READER does not reset reader to []

Milestone: v_6.06x

Status: closed-fixed

Owner: David Costanzo

Labels: Language Engine (245)

Priority: 5

Updated: 2006-11-21

Created: 2006-11-21

Creator: David Costanzo

Private: No

Running "CLOSE READER" leaves READER in an inconsistent state. It points to a file that is already closed. What's worse, this can cause FMSLogo to internally use a FILE* pointer that has already been closed. I have not seen this crash yet, but I have seen memory corruption around SETWRITE that may be related.

UCBLogo resets READER and WRITER to [] when they are closed. I think this is good, safe behavior that is worth emulating.

How Reproducible:
Every Time:

Steps to Reproduce:
OPENREAD "FMSLOGO.TXT
SETREAD "FMSLOGO.TXT
CLOSE READER
SHOW READER

What Happens:
FMSLOGO.TXT

Expected Result:
[]

David Costanzo - 2006-11-21

Logged In: YES
user_id=109252
Originator: YES

I have checked in a fix for this bug. It will be available in FMSLogo 6.12.0.

I have confirmed that this bug fix also fixed the memory corruption that halted the full test pass.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

David Costanzo - 2006-11-21

status: open --> closed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

David Costanzo - 2006-11-21

status: closed --> closed-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

CLOSE READER does not reset reader to []

A Logo programming environment for Microsoft Windows

Group

Searches

Help

#241 CLOSE READER does not reset reader to []

Related

Discussion